Re: pipex(4)/npppd(8): remove dummy PIPEX{G,S}MODE ioctl(2) calls

2021-01-02 Thread YASUOKA Masahiko
Yes, ok yasuoka On Wed, 30 Dec 2020 03:02:55 +0300 Vitaliy Makkoveev wrote: > This time pipex(4) related ioctl(2) calls PIPEX{S,G}MODE are pretty > dummy and were kept for backward compatibility reasons. The diff below > removes them. > > ok? > > Index: share/man/man4/pipex.4 > ==

Re: Wireguard: can't remove multiple peers at once.

2021-01-13 Thread YASUOKA Masahiko
Hi, On Thu, 14 Jan 2021 08:54:36 +0900 Yuichiro NAITO wrote: > Does anybody please review my code? > > Yasuoka-san is my coleague of my work. > So, he is interested in this topic. That’s why I CCed this mail. > I don’t mean he is an reviewer. > >> 2021/01/12 11:27、Yuichiro NAITO のメール: >> I have

Re: npppd(8)/pppac(4): remove dummy TUNSIFMODE ioctl(2) call

2021-01-31 Thread YASUOKA Masahiko
Yes, ok yasuoka On Fri, 29 Jan 2021 14:32:39 +0300 Vitaliy Makkoveev wrote: > Since OpenBSD 6.7 npppd(8) can't work over tun(4) anymore. I propose to > remove dummy TUNSIFMODE ioctl(2) call. > > Index: sys/net/if_pppx.c > === > RCS

Re: pppac(4): remove `sc_dead' logic

2021-02-10 Thread YASUOKA Masahiko
ok yasuoka Thanks, On Tue, 9 Feb 2021 12:06:08 +0300 Vitaliy Makkoveev wrote: > `sc_dead' is used to prevent pppac_ioctl() be called on dying pppac(4) > interface. But now if_detach() makes dying `ifp' inaccessible and waits > for references which are in-use. This logic is not required anymore.

2 diffs for dev/acpi/dsdt.c

2021-02-25 Thread YASUOKA Masahiko
Hi, My vaio repeatedly crashed by "Data modified on freelist"(*1) or other memory corruptions. After my long time debug, I found the route cause is a handling of references of LocalX, like the following: If ((SMRW (0x0B, 0x16, 0x21, RefOf (Local0)) == Zero)) In the called co

Re: 2 diffs for dev/acpi/dsdt.c

2021-02-27 Thread YASUOKA Masahiko
Hi, Let me update "diff #2". On Fri, 26 Feb 2021 13:42:32 +0900 (JST) YASUOKA Masahiko wrote: > My vaio repeatedly crashed by "Data modified on freelist"(*1) or other > memory corruptions. After my long time debug, I found the route cause > is a handling of r

diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
Hi, efiboot cannot load the kernel properly on some machines if booted from CD-ROM. In that case boot fails with a message like follow: booting cd0a:. [359648read symbols: Unknown error: code 255 As far as Asou and my test, this happens on hosts on VMware ESXi 6.7, 7.0 and asou's physica

Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
versed.. On Wed, 10 Mar 2021 20:35:41 +0900 (JST) YASUOKA Masahiko wrote: > efiboot cannot load the kernel properly on some machines if booted > from CD-ROM. In that case boot fails with a message like follow: > >booting cd0a:. [359648read symbols: Unknown error: code 255 >

Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-10 Thread YASUOKA Masahiko
On Wed, 10 Mar 2021 13:15:58 +0100 (CET) Mark Kettenis wrote: >> On Wed, 10 Mar 2021 20:35:41 +0900 (JST) >> YASUOKA Masahiko wrote: >> > efiboot cannot load the kernel properly on some machines if booted >> > from CD-ROM. In that case boot fa

monotonic time going back by wrong skews

2021-03-24 Thread YASUOKA Masahiko
Hi, I hit a problem which is caused by going back of monotonic time. It happens on hosts on VMware ESXi. I wrote the program which repeats the problem. % cc -o monotime monotime.c -lpthread % ./monotime 194964 Starting 562210 Starting 483046 Starting 148865 Starting 148865 Back 991.80804

Re: monotonic time going back by wrong skews

2021-03-24 Thread YASUOKA Masahiko
like 900, 900, 900, 900, 0, 900, 900, 900 you pick 0 which could lead > to some problems, right? Or am I missing something?" > > So could people give the minimum skew approach a spin on real machines > to see if there are any issues popping up? > > All the best, > Paul >

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread YASUOKA Masahiko
Hi, On Fri, 26 Mar 2021 09:30:43 +0100 Jan Klemkow wrote: > If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader > will hang while loading the kernel. Because, the UEFI loads the > bootloader on the same place in memory, where the bootloader will copy > the kernel. We are un

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread YASUOKA Masahiko
On Fri, 26 Mar 2021 12:12:44 +0100 (CET) Mark Kettenis wrote: >> Date: Fri, 26 Mar 2021 19:43:23 +0900 (JST) >> From: YASUOKA Masahiko >> >> Hi, >> >> On Fri, 26 Mar 2021 09:30:43 +0100 >> Jan Klemkow wrote: >> > If you want to boot O

Re: monotonic time going back by wrong skews

2021-03-28 Thread YASUOKA Masahiko
On Thu, 25 Mar 2021 19:41:35 +0100 (CET) Mark Kettenis wrote: >> From: Scott Cheloha >> Date: Thu, 25 Mar 2021 13:18:04 -0500 >> > On Wed, Mar 24, 2021 at 05:40:21PM +0900, YASUOKA Masahiko wrote: >> Which diff did you apply? Yasuoka provided two diffs. >>

Re: monotonic time going back by wrong skews

2021-04-05 Thread YASUOKA Masahiko
Hi, On Mon, 5 Apr 2021 10:43:00 +0300 Paul Irofti wrote: > On 05.04.2021 06:13, Scott Cheloha wrote: >> On Mon, Mar 29, 2021 at 02:00:01PM +0900, YASUOKA Masahiko wrote: >>> On Thu, 25 Mar 2021 19:41:35 +0100 (CET) >>> Mark Kettenis wrote: >>>>> From: S

Re: monotonic time going back by wrong skews

2021-04-05 Thread YASUOKA Masahiko
On Mon, 5 Apr 2021 14:24:03 +0200 (CEST) Mark Kettenis wrote: >> Date: Mon, 05 Apr 2021 19:14:49 +0900 (JST) >> From: YASUOKA Masahiko >> >> Hi, >> >> On Mon, 5 Apr 2021 10:43:00 +0300 >> Paul Irofti wrote: >> > On 05.04.2021 06:13, Scott

Re: monotonic time going back by wrong skews

2021-04-06 Thread YASUOKA Masahiko
pr 2021 09:21:40 +0200 Giovanni Bechis wrote: > On Mon, Apr 05, 2021 at 07:14:49PM +0900, YASUOKA Masahiko wrote: >> Hi, >> >> > Another issue that I see is that people have not reported, at least > [...] >> > publicly, that this runs fine on their normal OpenBSD

Re: wg(4): 'Address already in use' when wgrtable is changed

2022-07-21 Thread YASUOKA Masahiko
Hello, Let me ask "ok", The diff fixes the problem as follows: Configure wg0 without wgrtable # ifconfig wg0 create wgport 7111 wgkey `openssl rand -base64 32` up # ifconfig wg0 wg0: flags=80c3 mtu 1420 index 6 priority 0 llprio 3

Re: pipex(4): kill "Static" keyword

2022-07-22 Thread YASUOKA Masahiko
ok yasuoka On Mon, 18 Jul 2022 12:31:47 +0300 Vitaliy Makkoveev wrote: > We don't use "static" keyword for functions declaration to allow ddb(4) > debug. Also, many "Static" functions are called by pppx(4) layer outside > pipex(4) layer. > > This is the mostly mechanic diff, except the `pipex_pp

Re: pppac(4): don't grab netlock within pppacioctl()

2022-07-22 Thread YASUOKA Masahiko
ok yasuoka On Mon, 18 Jul 2022 13:50:37 +0300 Vitaliy Makkoveev wrote: > pipex(4) doesn't rely on netlock anymore. > > Index: sys/net/if_pppx.c > === > RCS file: /cvs/src/sys/net/if_pppx.c,v > retrieving revision 1.119 > diff -u -p

diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
b64decode(8) fails if a long line is given. % wc test 1 11370 test % % ./b64decode -r test > /dev/null b64decode: test: /dev/stdout: error decoding base64 input stream % uudecode.c 426 static int 427 base64_decode(void) 428 { 429 int n; 430

Re: diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
On Tue, 30 Aug 2022 11:56:53 +0200 Claudio Jeker wrote: > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: >> @@ -423,11 +423,13 @@ uu_decode(void) >> } >> } >> >> +#define ROUNDDOWN(x,y) (((x)/(y)) * (y)) >> + >> static

Re: diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
On Tue, 30 Aug 2022 14:09:40 +0200 Theo Buehler wrote: > On Tue, Aug 30, 2022 at 01:01:47PM +0200, YASUOKA Masahiko wrote: >> On Tue, 30 Aug 2022 11:56:53 +0200 >> Claudio Jeker wrote: >> > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: >> >

Re: pipex syzkaller keylen

2022-08-30 Thread YASUOKA Masahiko
Hi, Tested. ok yasuoka On Tue, 30 Aug 2022 15:41:29 +0200 Alexander Bluhm wrote: > Hi, > > I looks like syzkaller has found a missing input validation in pipex. > > https://syzkaller.appspot.com/bug?id=c7ac769bd7ee15549b8a2be188bcee07d98a5357 > > As I have no pipex setup, can anyone test thi

httpd: fix default request body size

2022-09-02 Thread YASUOKA Masahiko
Hello, For HTTP request body, if neither "Content-Encoding: chunked" nor "Content-Length" is specified, it should mean body length is 0. In RFC 9112 Section 6.3, 7.: | 7. If this is a request message and none of the above are true, then | the message body length is zero (no message body

divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, The diff is to fix a problem in a complex setup. Normal setup of divert-reply for TCP connection: client --- relayd --- server - transparently forward TCP connections - divert-reply is configured the outbound connection to the server - so that the PF state is removed when the PCB is de

Re: divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, On Fri, 2 Sep 2022 17:40:13 +0200 Alexander Bluhm wrote: > On Fri, Sep 02, 2022 at 03:04:34PM +0200, YASUOKA Masahiko wrote: >> The diff is to fix a problem in a complex setup. >> >> Normal setup of divert-reply for TCP connection: >> >>

Re: tcp timer mutex

2022-09-03 Thread YASUOKA Masahiko
ok yasuoka On Fri, 2 Sep 2022 14:44:29 +0200 Alexander Bluhm wrote: > + now = READ_ONCE(tcp_now); > + > /* >* Determine length of data that should be transmitted, >* and flags that will be used. > @@ -228,7 +231,7 @@ tcp_output(struct tcpcb *tp) >* to send, then

diff: fix panic in pf_state_export()

2022-09-20 Thread YASUOKA Masahiko
Hello, My colleague hit the following kernel panic when he is doing "psctl -ss" repeatedly by a script during a performance test. uvm_fault(0xfd811b869110, 0x10, 0, 1) -> e kernel: page fault trap, code=0 Stopped at pf_state_export+0x42: movq0x10(%rax),%rcx TIDPIDUI

Re: hostctl: Change from fixed length to variable length

2022-10-11 Thread YASUOKA Masahiko
Hello, On Wed, 05 Oct 2022 13:37:35 +0900 (JST) Masato Asou wrote: > From: "Theo de Raadt" > Date: Tue, 04 Oct 2022 21:58:13 -0600 >> Userland may not ask the kernel to allocate such a huge object. The >> kernel address space is quite small. First off, huge allocations will >> fail. >> >> But

Re: hostctl: Change from fixed length to variable length

2022-11-18 Thread YASUOKA Masahiko
On Wed, 12 Oct 2022 07:58:20 +0900 (JST) YASUOKA Masahiko wrote: > On Wed, 05 Oct 2022 13:37:35 +0900 (JST) > Masato Asou wrote: >> From: "Theo de Raadt" >> Date: Tue, 04 Oct 2022 21:58:13 -0600 >>> Userland may not ask the kernel to allocate such a huge obj

Re: hostctl: Change from fixed length to variable length

2022-11-18 Thread YASUOKA Masahiko
On Sat, 19 Nov 2022 14:41:18 +0900 (JST) YASUOKA Masahiko wrote: > On Wed, 12 Oct 2022 07:58:20 +0900 (JST) > YASUOKA Masahiko wrote: >> On Wed, 05 Oct 2022 13:37:35 +0900 (JST) >> Masato Asou wrote: >>> From: "Theo de Raadt" >>> Date: Tue, 04 Oct

Re: pppx(4): decrease netlock pressure in pppxioctl()

2022-11-19 Thread YASUOKA Masahiko
It doesn't seem to have a problem. Sorry for my delay. ok yasuoka On Wed, 9 Nov 2022 13:24:21 +0300 Vitaliy Makkoveev wrote: > ping... > > On Tue, Nov 01, 2022 at 03:16:02PM +0300, Vitaliy Makkoveev wrote: >> Push netlock down to pppx_add_session(). The 'pppx_if' structure has >> the `pxi_read

diff asr_run.3

2023-05-31 Thread YASUOKA Masahiko
Hi, asr_run.3 is explaining that ar_rrsetinfo must be freed only for the blocking function, but I think it must be freed regardless of the function blocking type. ok? Index: lib/libc/asr/asr_run.3 === RCS file: /cvs/src/lib/libc/asr

Re: tcp timer wrap around, use 64 bit

2023-07-06 Thread YASUOKA Masahiko
On Tue, 4 Jul 2023 12:14:47 +0300 Alexander Bluhm wrote: > After changing tcp now tick to milliseconds, it will wrap around > after 49 days of uptime. That may be a problem in some places of > our stack. Better use a 64 bit counter. I agree since we sometimes hit a problem from where we could n

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, Does using 64 bit for timer in tcpcb require this? ok? Index: sys/netinet/tcp.h === RCS file: /cvs/src/sys/netinet/tcp.h,v retrieving revision 1.24 diff -u -p -r1.24 tcp.h --- sys/netinet/tcp.h 19 May 2023 01:04:39 -

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 10:43:21 +0200 Claudio Jeker wrote: >> @@ -411,7 +412,7 @@ tcp_stats_display(unsigned long long tot >> P(tcpi, rcv_up, "%u") >> P(tcpi, rcv_wscale, "%hhu") >> P(tcpi, rfbuf_cnt, "%u") >> -P(tcpi,

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, This netstat diff is already needed to avoid compiler warnings since it uses struct tcpcb directly. ok? Index: usr.bin/netstat/inet.c === RCS file: /cvs/src/usr.bin/netstat/inet.c,v retrieving revision 1.177 diff -u -p -r1.177 i

Use u_long for struct mstat

2023-07-07 Thread YASUOKA Masahiko
Hi, I'd like to expand the counters in struct mbstat from u_short to u_long. When I was debugging a mbuf leak, I saw the result of "netstat -m" --- 28647 mbufs in use: 28551 mbufs allocated to data 4 mbufs allocated to packet headers 92 mbufs allocated to socket names and

Re: acpi: move acpiioctl to x86

2023-07-08 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 11:56:42 +0200 Tobias Heider wrote: > On Wed, Jul 05, 2023 at 04:53:33PM +0200, Tobias Heider wrote: >> I am planning to restructure the APM/sleep APIs to make it easier to suspend >> from more places like as a suspend keyboard shortcut. >> >> The acpiioctl handler is x86 speci

make mstat smaller

2023-07-08 Thread YASUOKA Masahiko
Hi, The diff makes the mbstat be the same size which is actually used. Also revert the previous that the mbstat is located on the stack. ok? Index: sys/kern/kern_sysctl.c === RCS file: /cvs/src/sys/kern/kern_sysctl.c,v retrieving re

make mbstat smaller (was Re: make mstat smaller)

2023-07-09 Thread YASUOKA Masahiko
On Sat, 08 Jul 2023 21:58:30 +0300 (EEST) YASUOKA Masahiko wrote: > The diff makes the mbstat be the same size which is actually used. > Also revert the previous that the mbstat is located on the stack. The userland program also needed to be changed. ok? Index: sys/kern/kern_sy

assign wsdisplay0 to the glass console

2023-07-19 Thread YASUOKA Masahiko
Hi, I noticed that the keyboard doesn't work for RAMDISK kernel on HP DL20 Gen10. The kernel assigns wsdisplay0 for VGA and wsdisplay1 for efifb. But actually the glass console is efieb but it doesn't have any keyboard assigned because the keyboard is assigned to wsdisplay0. GENERIC kernel does

attach azalia(4) for "Intel 700 Series HD Audio"

2023-07-30 Thread YASUOKA Masahiko
Hello, New vaio has an audio device which is not configured. "Intel 700 Series HD Audio" rev 0x01 at pci0 dev 31 function 3 not configured 0:31:3: Intel unknown 0x: Vendor ID: 8086, Product ID: 51ca 0x0004: Command: 0006, Status: 0010 0x0008: Class: 04 Multimedia,

diff: trigger acpiac_refresh when acpibat notification

2023-08-17 Thread YASUOKA Masahiko
Hi, Update the AC status when the battery notification is happened. Because the AC status notification doesn't happen on some machines. My vaio actually has this problem. Also Linux is doing the same thing https://github.com/torvalds/linux/blob/v6.4/drivers/acpi/ac.c#L165-L183 ok? comments? In

Re: diff: trigger acpiac_refresh when acpibat notification

2023-08-17 Thread YASUOKA Masahiko
pm」を使うことができます。 > > Battery level (percent) checking/バッテリーのレベル(パーセント)を確認するため:apm -l > Estimated battery duration (minutes)/バッテリーが持つ予定の時間まで(分)を確認するため:apm -m > > On 2023年08月17日 16:12, YASUOKA Masahiko wrote: >> Hi, >> >> Update the AC status when the battery notifi

Re: diff: trigger acpiac_refresh when acpibat notification

2023-08-17 Thread YASUOKA Masahiko
Let me clarify some. On Thu, 17 Aug 2023 16:12:07 +0900 (JST) YASUOKA Masahiko wrote: > Update the AC status when the battery notification is happened. > Because the AC status notification doesn't happen on some machines. At that time (plugging or unpluggin the AC), a battery n

Re: diff: trigger acpiac_refresh when acpibat notification

2023-08-18 Thread YASUOKA Masahiko
On Thu, 17 Aug 2023 10:07:27 -0500 joshua stein wrote: > On Thu, 17 Aug 2023 at 16:12:07 +0900, YASUOKA Masahiko wrote: >> Hi, >> >> Update the AC status when the battery notification is happened. >> Because the AC status notification doesn't happen on some machin

diff: relayd generate an output rule for "route to"

2023-09-12 Thread YASUOKA Masahiko
Hi, After 6.9 packets passed by "route-to" started to be evaluated when output. As the result, states are created for output direction, because it is not considered about "direct server return", has some problems (eg. the state is deleted because the state tracking is failed.) relayd(8) creates

Re: diff: trigger acpiac_refresh when acpibat notification

2023-09-13 Thread YASUOKA Masahiko
ping. I think we have no reason not having this. Alternatively acpiac_notify_triggered can be deleted and doing the triggering unconditionally is also good because it's simpler. comments? ok? On Thu, 17 Aug 2023 16:12:07 +0900 (JST) YASUOKA Masahiko wrote: > Hi, > > Update the

fix a wireguard mbuf leak

2023-09-21 Thread YASUOKA Masahiko
A leak may happens when wgpeer is deleted. ok? The state queue should be freeed when wg_peer is destroyed. diff from IIJ. Index: sys/net/if_wg.c === RCS file: /disk/cvs/openbsd/src/sys/net/if_wg.c,v retrieving revision 1.29 diff -u

Re: vmt(4): use shared netlock to protect ifnet data within vmt_tclo_broadcastip()

2023-09-24 Thread YASUOKA Masahiko
On Sat, 23 Sep 2023 15:38:40 +0300 Vitaliy Makkoveev wrote: > This makes ifnet protection consistent. Execute vmt_tclo_tick() timeout > handler in process context to allow context switch within > vmt_tclo_broadcastip(). ok yasuoka > Index: sys/dev/pv/vmt.c > =

Re: diff: init efifb even if VGA is probed.

2020-03-09 Thread YASUOKA Masahiko
Hi, Thank you for your test and feedback. On Fri, 6 Mar 2020 16:38:24 -0600 Andrew Daugherity wrote: > On Sun, Mar 1, 2020 at 10:41 PM YASUOKA Masahiko wrote: >> >> Hi, >> >> The problems you are pointing seem to be the same problem. >> >> > I&#

Re: Prevent memory corruption by pipex_timer()

2020-04-01 Thread YASUOKA Masahiko
Hi, Sorry for my silence. ok yasuoka for the daemon part. On Wed, 1 Apr 2020 09:27:10 +0200 Martin Pieuchot wrote: > On 31/03/20(Tue) 23:16, Vitaliy Makkoveev wrote: >> On Tue, Mar 31, 2020 at 06:15:46PM +0200, Martin Pieuchot wrote: >> > [...] >> > Well better fix npppd(8), no? Not crashing

Re: pipex(4) fix: check session existence before creation

2020-04-06 Thread YASUOKA Masahiko
ok yasuoka On Mon, 6 Apr 2020 19:54:20 +0300 Vitaliy Makkoveev wrote: > Deny to create pipex_session which is already exist. Newly created > session will be placed to list head so the caller of > pipex_*_lookup_session() will receive wrong session. > > Index: sys/net/if_pppx.c >

fix pppac(4) without pipex

2020-04-11 Thread YASUOKA Masahiko
Hi, The diff followings fixes panics when using pppac(4) with "pipex no". Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.83 diff -u -p -r1.83 if_pppx.c --- sys/net/if_pppx.c 10 Apr 2020 07

Re: diff: init efifb even if VGA is probed.

2020-05-28 Thread YASUOKA Masahiko
Hi, I'd like to conclude this issue. On Fri, 21 Feb 2020 14:09:07 +0900 (JST) YASUOKA Masahiko wrote: > I am testing a new hardware, HPE DL20 Gen10. > > When efiboot starts the kernel, the video display becomes distorted > and never recovered until CPU reset. > &

Re: diff: init efifb even if VGA is probed.

2020-05-28 Thread YASUOKA Masahiko
On Thu, 28 May 2020 17:01:48 +0900 (JST) YASUOKA Masahiko wrote: > Hi, > > I'd like to conclude this issue. > > On Fri, 21 Feb 2020 14:09:07 +0900 (JST) > YASUOKA Masahiko wrote: >> I am testing a new hardware, HPE DL20 Gen10. >> >> When efiboot sta

Re: diff: init efifb even if VGA is probed.

2020-05-28 Thread YASUOKA Masahiko
On Thu, 28 May 2020 12:31:31 +0200 (CEST) Mark Kettenis wrote: >> Date: Thu, 28 May 2020 17:01:48 +0900 (JST) >> From: YASUOKA Masahiko >> >> Hi, >> >> I'd like to conclude this issue. >> >> On Fri, 21 Feb 2020 14:09:07 +0900 (JST) >>

pf "route-to least-state" in an anchor doesn't work

2020-06-03 Thread YASUOKA Masahiko
Hi, pf.conf: anchor { pass in on rdomain 102 quick proto tcp to 10.0.0.101 port 8080 \ keep state ( sloppy ) route-to \ least-states sticky-address } table { 10.0.0.11@pair102 } this doesn't work. All packets going to 10.0.0.101 are dropped with 'no-route'. The pr

Re: pf "route-to least-state" in an anchor doesn't work

2020-06-03 Thread YASUOKA Masahiko
Hello, On Wed, 3 Jun 2020 23:30:56 +0200 Alexandr Nedvedicky wrote: > I'm OK with your change. Thank you for your review and comment. > However I would like to ask you to do yet another test. I wonder if things > will eventually work on unfixed PF if rules will be constructed as follows: > >

Re: install npppd.conf with mode 0600

2020-06-21 Thread YASUOKA Masahiko
The line in etc/mtree/special should be updated as well. npppd.conf type=file mode=0640 uname=root gname=wheel other than that, ok yasuoka On Sun, 21 Jun 2020 16:48:44 +0300 Vitaliy Makkoveev wrote: > We installing `npppd-users' with uid:gid root:wheel and mode 0600 > because it consists

Re: pipex(4): prevent `state_list' corruption

2020-06-22 Thread YASUOKA Masahiko
Yes, this seems right. ok yasuoka On Thu, 18 Jun 2020 23:53:25 +0300 Vitaliy Makkoveev wrote: > While pppac(4) destroy sessions by pipex_iface_fini() or by > pipex_ioctl() with PIPEXSMODE command, some sessions can be linked to > `state_list'. This case is not checked and sessions will never be

route add ::/0 ...

2020-06-28 Thread YASUOKA Masahiko
Hi, When "::/0" is used as "default", # route add ::/0 fe80::1%em0 add net ::/0: gateway fe80::1%em0: Invalid argument route command trims the sockaddr to { .len = 2, .family = AF_INET6 } for "::/0", but rtable_satoplen() refuses it. I think it should be accepted. ok? Allow sockaddr for p

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
Hi, On Mon, 29 Jun 2020 10:12:23 +0200 Martin Pieuchot wrote: > On 28/06/20(Sun) 20:41, YASUOKA Masahiko wrote: >> Hi, >> >> When "::/0" is used as "default", >> >> # route add ::/0 fe80::1%em0 >> add net ::/0: gateway fe80::1%em

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
On Mon, 29 Jun 2020 18:45:07 +0900 (JST) YASUOKA Masahiko wrote: > On Mon, 29 Jun 2020 10:12:23 +0200 > Martin Pieuchot wrote: >> On 28/06/20(Sun) 20:41, YASUOKA Masahiko wrote: >>> Hi, >>> >>> When "::/0" is used as "default", >>

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
On Mon, 29 Jun 2020 19:18:17 +0200 Klemens Nanni wrote: > On Mon, Jun 29, 2020 at 11:55:10PM +0900, YASUOKA Masahiko wrote: >> The function mask_addr() doesn't mask address for IPv4 and IPv6. Does >> any address family other than IPv4 or IPv6 require #1142:1148? The >&

Fix IPsec NAT-T for L2TP/IPsec

2021-05-12 Thread YASUOKA Masahiko
Hi, Radek reported a problem to misc@ that multiple Windows clients behind a NAT cannot use a L2TP/IPsec server simultaneously. https://marc.info/?t=16099681611&r=1&w=2 There is two problems. First is pipex(4) doesn't pass the proper ipsecflowinfo to ip_output(). Second is the IPsec po

Re: Fix IPsec NAT-T for L2TP/IPsec

2021-05-12 Thread YASUOKA Masahiko
On Wed, 12 May 2021 17:26:51 +0300 Vitaliy Makkoveev wrote: > On Wed, May 12, 2021 at 07:11:09PM +0900, YASUOKA Masahiko wrote: >> Radek reported a problem to misc@ that multiple Windows clients behind a NAT >> cannot use a L2TP/IPsec server simultaneously. >> &g

Re: Fix IPsec NAT-T for L2TP/IPsec

2021-05-12 Thread YASUOKA Masahiko
On Wed, 12 May 2021 19:15:29 +0300 Vitaliy Makkoveev wrote: >> On 12 May 2021, at 18:42, YASUOKA Masahiko wrote: >> On Wed, 12 May 2021 17:26:51 +0300 >> Vitaliy Makkoveev wrote: >>> On Wed, May 12, 2021 at 07:11:09PM +0900, YASUOKA Masahiko wrote: >>>>

Re: Fix IPsec NAT-T for L2TP/IPsec

2021-05-12 Thread YASUOKA Masahiko
On Wed, 12 May 2021 19:11:09 +0900 (JST) YASUOKA Masahiko wrote: > Radek reported a problem to misc@ that multiple Windows clients behind > a NAT cannot use a L2TP/IPsec server simultaneously. > > https://marc.info/?t=16099681611&r=1&w=2 > > There is two problems.

Re: Next command of GDB does not work properly unusual

2018-07-12 Thread YASUOKA Masahiko
Hi, > The next command of GDB does not work properly. > I use OpenBSD 6.3 and /usr/bin/gdb (GDB 6.3). It seems that gdb can't read the dwarf generated by clang properly. I found a better fix at the upstream. https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=ca5f395d6255337974262b

Re: Next command of GDB does not work properly unusual

2018-07-12 Thread YASUOKA Masahiko
On Thu, 12 Jul 2018 10:37:33 +0100 Stuart Henderson wrote: > On 2018/07/12 16:16, YASUOKA Masahiko wrote: >> > The next command of GDB does not work properly. >> > I use OpenBSD 6.3 and /usr/bin/gdb (GDB 6.3). >> >> It seems that gdb can't read the dwarf gen

Re: Next command of GDB does not work properly unusual

2018-07-12 Thread YASUOKA Masahiko
On Thu, 12 Jul 2018 19:14:19 +0900 (JST) YASUOKA Masahiko wrote: >> On 2018/07/12 16:16, YASUOKA Masahiko wrote: >>> > The next command of GDB does not work properly. >>> > I use OpenBSD 6.3 and /usr/bin/gdb (GDB 6.3). >>> >>> It seems that gdb

Re: [patch] switchd(8) on sparc64: panic: trap type 0x34

2018-08-20 Thread YASUOKA Masahiko
Hi, > panic: trap type 0x34 (mem address not aligned): pc=15864ec > npc=15864f0 pstate=99820006 (snip) > o...@eigenstate.org and I put together the following diff. I haven't been able > to check with the original reporter, and I don't have a machine to test it on, > so comments and/or tests would

Re: [patch] switchd(8) on sparc64: panic: trap type 0x34

2018-08-20 Thread YASUOKA Masahiko
On Mon, 20 Aug 2018 11:05:08 -0700 Ori Bernstein wrote: > On Mon, 20 Aug 2018 23:38:28 +0900 (JST), YASUOKA Masahiko > wrote: >> As far as I know, switch(4) assumes it receives packets located at 64 >> bit aligned memory. So if the code like below >> >>

Re: Using shift on external keyboards in softraid passphrases from efiboot

2018-08-22 Thread YASUOKA Masahiko
On Mon, 20 Aug 2018 13:50:13 +0200 Theo Buehler wrote: > On Thu, Aug 16, 2018 at 09:51:32PM +0200, Frank Groeneveld wrote: >> I haven't been able to type the passphrase of my softraid device on >> boot when using an external keyboard on my Thinkpad X260. Finally I >> had some time to debug this pr

Re: Using shift on external keyboards in softraid passphrases from efiboot

2018-08-23 Thread YASUOKA Masahiko
Hi, I think the diff should be brought to arm64 as well. ok? On Thu, 23 Aug 2018 11:21:57 +0900 (JST) YASUOKA Masahiko wrote: > On Mon, 20 Aug 2018 13:50:13 +0200 > Theo Buehler wrote: >> On Thu, Aug 16, 2018 at 09:51:32PM +0200, Frank Groeneveld wrote: >>> I haven&#x

Re: Using shift on external keyboards in softraid passphrases from efiboot

2018-08-24 Thread YASUOKA Masahiko
On Fri, 24 Aug 2018 10:55:52 +0200 Patrick Wildt wrote: > On Fri, Aug 24, 2018 at 10:47:27AM +0200, Theo Buehler wrote: >> On Fri, Aug 24, 2018 at 11:50:51AM +0900, YASUOKA Masahiko wrote: >> > Hi, >> > >> > I think the diff should be brought to arm64 as well.

Re: iostat: add "sp" column for CP_SPIN

2018-09-05 Thread YASUOKA Masahiko
Hi, Committed the diff for command. Thanks. As for the man page, it makes sense for me. ok yasuoka On Wed, 05 Sep 2018 10:33:37 +0200 Solene Rapenne wrote: > Solene Rapenne wrote: >> Naoki Fukaumi wrote: >> > hi tech@, >> > >> > new cpu state, CP_SPIN, was added, >> > https://marc.info/?l

Re: SEGV was occurred in libedit

2018-10-09 Thread YASUOKA Masahiko
Hi, On Wed, 10 Oct 2018 08:00:14 +0900 (JST) Masato Asou wrote: > When I use /usr/bin/bc command with MALLOC_OPTIONS=UJ, SEGV was > occurred in libedit. > > $ MALLOC_OPTIONS=UJ /usr/bin/bc > 10 + 20 + 30 + 40 + 50 + 60 + 70 + 80 + > 90 + Segmentation fault (c

Re: Exit status of pkg_add

2021-10-18 Thread YASUOKA Masahiko
Hi, # drop ccing misc@ The diff seems ok for me. ok to commit it in? On Tue, 19 Oct 2021 10:42:04 +0900 Yuichiro NAITO wrote: > Following patch changes pkg_add to return a error code, > if a package name is wrong. > > diff --git a/usr.sbin/pkg_add/OpenBSD/AddDelete.pm > b/usr.sbin/pkg_add/Ope

diff: ipsec.conf(5), clarify "aes" accepts 128:256 bits

2021-11-01 Thread YASUOKA Masahiko
I'd like to clarify "aes" in ipsec.conf accepts 128:256 bits. sbin/ipsecctl/ike.c: 201 case ENCXF_AES: 202 enc_alg = "AES"; 203 key_length = "128,128:256"; 204 br

diff: isakmpd.conf.5, clarify ANY can be used for some params

2021-11-01 Thread YASUOKA Masahiko
ok? Clarify that ANY can be used for several parameters of IPsec transform. Index: sbin/isakmpd/isakmpd.conf.5 === RCS file: /cvs/src/sbin/isakmpd/isakmpd.conf.5,v retrieving revision 1.135 diff -u -p -r1.135 isakmpd.conf.5 --- sbin/

Re: diff: ipsec.conf(5), clarify "aes" accepts 128:256 bits

2021-11-02 Thread YASUOKA Masahiko
Hi, On Tue, 2 Nov 2021 07:03:43 + Jason McIntyre wrote: > On Tue, Nov 02, 2021 at 12:02:07PM +0900, YASUOKA Masahiko wrote: >> I'd like to clarify "aes" in ipsec.conf accepts 128:256 bits. >> >> sbin/ipsecctl/ike.c: >> 201

Fix ipsp_spd_lookup() for transport mode (was Re: Fix IPsec NAT-T for L2TP/IPsec)

2021-11-20 Thread YASUOKA Masahiko
Hi, On Wed, 12 May 2021 19:11:09 +0900 (JST) YASUOKA Masahiko wrote: > Radek reported a problem to misc@ that multiple Windows clients behind > a NAT cannot use a L2TP/IPsec server simultaneously. > > https://marc.info/?t=16099681611&r=1&w=2 > > There is two p

Re: Fix ipsp_spd_lookup() for transport mode

2021-11-29 Thread YASUOKA Masahiko
Hi, Let me update the diff. Previous has a problem in ipsp_spd_lookup() which uses "rn" without initialization. On Sat, 20 Nov 2021 21:44:20 +0900 (JST) YASUOKA Masahiko wrote: > On Wed, 12 May 2021 19:11:09 +0900 (JST) > YASUOKA Masahiko wrote: >> Radek reported a

Re: Fix ipsp_spd_lookup() for transport mode

2021-12-01 Thread YASUOKA Masahiko
On Wed, 1 Dec 2021 00:27:06 +0100 Alexander Bluhm wrote: > On Tue, Nov 30, 2021 at 05:53:34PM +0300, Vitaliy Makkoveev wrote: >> Hi, >> >> This question is mostly for bluhm@. Should the gettdbbyflow() grab the >> extra reference on returned `tdbp' like other other gettdb*() do? I'm >> pointing th

Re: Fix ipsp_spd_lookup() for transport mode

2021-12-14 Thread YASUOKA Masahiko
Hi, On Tue, 14 Dec 2021 01:20:49 +0100 Alexander Bluhm wrote: > I don't know much about l2tp, pipex or npppd. So I cannot say if > the new logic is correct. But I guess you have tested that. Yes, I've tested some L2TP/IPsec cases already. > The tdb mutex and ref counting looks correct. > >>

Re: Fix ipsp_spd_lookup() for transport mode

2021-12-23 Thread YASUOKA Masahiko
Hi, On Mon, 20 Dec 2021 13:20:46 +0100 Alexander Bluhm wrote: > On Tue, Dec 14, 2021 at 06:25:20PM +0900, YASUOKA Masahiko wrote: >> Yes, if there is another better idea, it will be welcome. >> For this moment, the diff is the best idea for me. > > Sorry, no better idea.

Re: parallel ip forwarding

2021-12-23 Thread YASUOKA Masahiko
Hello, On Fri, 24 Dec 2021 00:55:04 +0100 Alexander Bluhm wrote: > On Fri, Dec 03, 2021 at 08:35:45PM +0100, Alexander Bluhm wrote: >> Note that IPsec still has the workaround to disable multiple queues. > > I think we can remove the ipsec_in_use workaround now. The IPsec > path is protected wi

Re: parallel ip forwarding

2021-12-30 Thread YASUOKA Masahiko
Hi, On Sat, 25 Dec 2021 21:50:47 +0300 Vitaliy Makkoveev wrote: > On Fri, Dec 24, 2021 at 12:50:23PM +0100, Alexander Bluhm wrote: >> On Fri, Dec 24, 2021 at 04:16:28PM +0900, YASUOKA Masahiko wrote: >> > > - npppd l2pt ipsecflowinfo is not MP safe >> > >>

Re: route add ::/0 ...

2020-07-06 Thread YASUOKA Masahiko
On Tue, 30 Jun 2020 02:42:02 +0200 Klemens Nanni wrote: > On Tue, Jun 30, 2020 at 09:00:30AM +0900, YASUOKA Masahiko wrote: >> inet_makenetandmask() had required another treatment. >> >> Also -prefixlen 0 for -inet has a bug >> >> % doas ./obj/route -T1

Re: route add ::/0 ...

2020-07-06 Thread YASUOKA Masahiko
Let me updated the diff. On Mon, 06 Jul 2020 17:54:30 +0900 (JST) YASUOKA Masahiko wrote: > On Tue, 30 Jun 2020 02:42:02 +0200 > Klemens Nanni wrote: >> On Tue, Jun 30, 2020 at 09:00:30AM +0900, YASUOKA Masahiko wrote: >>> inet_makenetandmask() had required another tre

receive interfacez for carp when real mac is used

2020-07-22 Thread YASUOKA Masahiko
Hi, Currently when using the real mac address for carp(4) interface, all packets are treated as their receive inteface is carp. This causes some problems. For example, IPv6 ndp doesn't work on an interface which is used for carpdev. Because it is assumed that reply packets are received with the

Re: receive interfacez for carp when real mac is used

2020-07-22 Thread YASUOKA Masahiko
The problem I was to fix had been fixed by dlg@'s commit today. https://marc.info/?l=openbsd-cvs&m=159538265604770&w=2 So the diff is not needed any more. Pointed out by dlg@. Thanks, On Wed, 22 Jul 2020 19:24:32 +0900 (JST) YASUOKA Masahiko wrote: > Hi, > > Current

pf: route-to {random,srchash} in an anchor

2020-07-23 Thread YASUOKA Masahiko
Hi, Last month, I fixed the problem "route-to least-state" in an anchor didn't work. https://marc.info/?t=15911745782&r=1&w=2 I noticed the same problem happens on "random" and "srchash" as well. ok? Use the table on root always if current table is not active. Index: sys/net/pf_lb.c =

pf: route-to least-states

2020-07-23 Thread YASUOKA Masahiko
Hi, The diff fixes 2 problems of "least-states": - states whose address is selected by sticky-address is not counted for the number of states. - interface is not selected properly if selected table entry specifies an interface. ok? Increase state counter for least-states when the address is

Re: pf: route-to least-states

2020-07-24 Thread YASUOKA Masahiko
Hi, Thank you for your review. On Fri, 24 Jul 2020 01:25:42 +0200 Alexandr Nedvedicky wrote: >> - interface is not selected properly if selected table entry specifies >> an interface. > > to be honest I don't quite understand what's going on here. > can you share some details of confi

Re: pf: route-to {random,srchash} in an anchor

2020-07-24 Thread YASUOKA Masahiko
Hi, On Thu, 23 Jul 2020 18:44:43 +0200 Alexandr Nedvedicky wrote: > On Thu, Jul 23, 2020 at 08:01:18PM +0900, YASUOKA Masahiko wrote: >> Hi, >> >> Last month, I fixed the problem "route-to least-state" in an anchor >> didn't work. >> >>

  1   2   3   4   >