Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-12-05 Thread Jeremie Courreges-Anglas
On Wed, Nov 06 2019, Hiltjo Posthuma wrote: [...] > Thanks for reviewing the patch. Sadly I noticed and made a stupid mistake. > When > NOSSL is set, but SMALL is not set. It will set scheme = HTTPS_URL for the > file handler. > > Below is the full updated patch: I think we don't want to

Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-11-06 Thread Hiltjo Posthuma
On Wed, Nov 06, 2019 at 08:33:09PM +0100, Jan Klemkow wrote: > Hi Hiltjo, > > On Wed, Nov 06, 2019 at 07:53:02PM +0100, Hiltjo Posthuma wrote: > > The below patch fixes the #ifndef's for usr.bin/ftp so any combination of > > SMALL > > and NOSSL will compile again. > > Diff looks good for me and

Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-11-06 Thread Jan Klemkow
Hi Hiltjo, On Wed, Nov 06, 2019 at 07:53:02PM +0100, Hiltjo Posthuma wrote: > The below patch fixes the #ifndef's for usr.bin/ftp so any combination of > SMALL > and NOSSL will compile again. Diff looks good for me and works in all ifdef combinations without any warning or error. OK jan@