Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-18 Thread Martin Pieuchot
On 18/06/20(Thu) 09:03, Martin Pieuchot wrote: > On 17/06/20(Wed) 11:50, Martin Pieuchot wrote: > > On 16/06/20(Tue) 06:18, Todd C. Miller wrote: > > > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > > > > > The diff below implements DragonFly's approach of adding a new kind of >

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-18 Thread Martin Pieuchot
On 17/06/20(Wed) 11:50, Martin Pieuchot wrote: > On 16/06/20(Tue) 06:18, Todd C. Miller wrote: > > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > > > The diff below implements DragonFly's approach of adding a new kind of > > > filter, EVFILT_EXCEPT, to report such conditions.

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-17 Thread Martin Pieuchot
On 16/06/20(Tue) 06:18, Todd C. Miller wrote: > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > The diff below implements DragonFly's approach of adding a new kind of > > filter, EVFILT_EXCEPT, to report such conditions. This extends the > > existing kqueue interface which is

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread William Ahern
On Tue, Jun 16, 2020 at 06:18:13AM -0600, Todd C. Miller wrote: > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > The diff below implements DragonFly's approach of adding a new kind of > > filter, EVFILT_EXCEPT, to report such conditions. This extends the > > existing kqueue

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Vitaliy Makkoveev
On Tue, Jun 16, 2020 at 03:10:02PM +0200, Martin Pieuchot wrote: > On 16/06/20(Tue) 06:18, Todd C. Miller wrote: > > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > > > The diff below implements DragonFly's approach of adding a new kind of > > > filter, EVFILT_EXCEPT, to report

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Todd C . Miller
On Tue, 16 Jun 2020 10:13:11 -0600, "Theo de Raadt" wrote: > Everytime someone did poll on select, or select on poll, or something > on something, the emulation ended up being dangerously buggy in the > first round. Agreed. > I hope such emulation isn't a goal in libc. What happens in the

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Theo de Raadt
Todd C. Miller wrote: > On Tue, 16 Jun 2020 16:21:14 +0300, Vitaliy Makkoveev wrote: > > > https://github.com/apple/darwin-xnu > > Note that the poll emulation in xnu was incomplete the last time I > checked. Granted, that was 10 years ago so it might be better now, > but at the time you

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Todd C . Miller
On Tue, 16 Jun 2020 16:21:14 +0300, Vitaliy Makkoveev wrote: > https://github.com/apple/darwin-xnu Note that the poll emulation in xnu was incomplete the last time I checked. Granted, that was 10 years ago so it might be better now, but at the time you couldn't poll much more than sockets. I

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Martin Pieuchot
On 16/06/20(Tue) 06:18, Todd C. Miller wrote: > On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > > > The diff below implements DragonFly's approach of adding a new kind of > > filter, EVFILT_EXCEPT, to report such conditions. This extends the > > existing kqueue interface which is

Re: New EVFILT_EXCEPT for POLLPRI & POLLRDBAND

2020-06-16 Thread Todd C . Miller
On Tue, 16 Jun 2020 12:48:58 +0200, Martin Pieuchot wrote: > The diff below implements DragonFly's approach of adding a new kind of > filter, EVFILT_EXCEPT, to report such conditions. This extends the > existing kqueue interface which is questionable. On the one hand this > allows userland