Bob Beck wrote:
> On Fri, Nov 27, 2015 at 02:50:57PM -0200, Walter Neto wrote:
>
> You have a number of places here where you introduce a line of 8 spaces
> after your #endif - please clean up the trailing spaces, they shouldn't be
> there.
>
> You also have uses of B_METAONLY that are not
Walter Neto wrote:
> > You also have uses of B_METAONLY that are not inside a #ifdef WAPBL in
> > ffs_balloc.c
> >
>
> Yeah, but I don't know what is the best way to correct it.
> Should I use:
> #ifdef WAPBL
> foo(..., flags | B_METAONLY, ...);
> #else
> foo(..., flags, ...);
>
On Sat, Nov 28, 2015 at 03:49:21PM -0700, Bob Beck wrote:
> On Fri, Nov 27, 2015 at 02:50:57PM -0200, Walter Neto wrote:
>
> You have a number of places here where you introduce a line of 8 spaces
> after your #endif - please clean up the trailing spaces, they shouldn't be
> there.
>
Ok,
Fixed diff
Ok beck@ and tedu@
--
Walter Neto
diff --git a/sys/sys/buf.h b/sys/sys/buf.h
index c47f3f9..fd38c28 100644
--- a/sys/sys/buf.h
+++ b/sys/sys/buf.h
@@ -254,6 +254,8 @@ struct cluster_save {
/* Flags to low-level allocation routines. */
#define B_CLRBUF 0x01/* Request
On Fri, Nov 27, 2015 at 02:50:57PM -0200, Walter Neto wrote:
You have a number of places here where you introduce a line of 8 spaces
after your #endif - please clean up the trailing spaces, they shouldn't be
there.
You also have uses of B_METAONLY that are not inside a #ifdef WAPBL in
After mpi@ review
--
Walter Neto
diff --git a/sys/sys/buf.h b/sys/sys/buf.h
index c47f3f9..fd38c28 100644
--- a/sys/sys/buf.h
+++ b/sys/sys/buf.h
@@ -254,6 +254,8 @@ struct cluster_save {
/* Flags to low-level allocation routines. */
#define B_CLRBUF 0x01/* Request allocated buffer
