Re: avoid uninitialised attr in rasops_scrollback()

> Thanks, looks good/ok. Shouldn't the eraserows call in > rasops_doswitch() also use scr->rs_defattr for the attr argument? Yes, indeed. Good catch!

Re: avoid uninitialised attr in rasops_scrollback()

On Tue, May 01, 2018 at 05:03:26PM +, Miod Vallat wrote: > > scrollback isn't part of wsdisplay_emulops but rather wsdisplay_accessops. > > It isn't clear how to properly get an attr in wsscrollback() > > GETCHAR/getchar is part of wsmoused and sc->sc_accessops->getchar > > may be NULL. > >

Re: avoid uninitialised attr in rasops_scrollback()

> scrollback isn't part of wsdisplay_emulops but rather wsdisplay_accessops. > It isn't clear how to properly get an attr in wsscrollback() > GETCHAR/getchar is part of wsmoused and sc->sc_accessops->getchar > may be NULL. Ok, ignore that. There is a simpler solution. Index: rasops.c

Re: avoid uninitialised attr in rasops_scrollback()

On Mon, Apr 30, 2018 at 06:13:00PM +, Miod Vallat wrote: > > On Sun, Apr 29, 2018 at 09:42:00AM +, Miod Vallat wrote: > > > > > > > Don't use attr uninitialised. Avoids glitches seen when using > > > > scrollback with radeondrm. > > > > > > That's horrible. The bg attribute should be

Re: avoid uninitialised attr in rasops_scrollback()

> On Sun, Apr 29, 2018 at 09:42:00AM +, Miod Vallat wrote: > > > > > Don't use attr uninitialised. Avoids glitches seen when using > > > scrollback with radeondrm. > > > > That's horrible. The bg attribute should be passed to the function, > > rather than computed here with possibly wrong

Re: avoid uninitialised attr in rasops_scrollback()

On Sun, Apr 29, 2018 at 09:42:00AM +, Miod Vallat wrote: > > > Don't use attr uninitialised. Avoids glitches seen when using > > scrollback with radeondrm. > > That's horrible. The bg attribute should be passed to the function, > rather than computed here with possibly wrong values. > You

Re: avoid uninitialised attr in rasops_scrollback()

> Date: Sun, 29 Apr 2018 16:46:30 +1000 > From: Jonathan Gray > > Don't use attr uninitialised. Avoids glitches seen when using > scrollback with radeondrm. ok kettenis@ > Index: rasops.c > === > RCS file:

Re: avoid uninitialised attr in rasops_scrollback()

> Don't use attr uninitialised. Avoids glitches seen when using > scrollback with radeondrm. That's horrible. The bg attribute should be passed to the function, rather than computed here with possibly wrong values.