Re: drm: fix debug build

2018-01-03 Thread Jonathan Gray
On Thu, Dec 21, 2017 at 04:11:44PM +0200, Paul Irofti wrote: > On Thu, Dec 21, 2017 at 02:25:41PM +0100, Mark Kettenis wrote: > > > Date: Thu, 21 Dec 2017 13:01:31 +0200 > > > From: Paul Irofti > > > > > > If no one objects, I will commit this tomorrow. > > > > Fix is wrong since it will break w

Re: drm: fix debug build

2017-12-21 Thread Paul Irofti
On Thu, Dec 21, 2017 at 02:25:41PM +0100, Mark Kettenis wrote: > > Date: Thu, 21 Dec 2017 13:01:31 +0200 > > From: Paul Irofti > > > > If no one objects, I will commit this tomorrow. > > Fix is wrong since it will break with gcc. Probably best to just use > %02x, just like we did for printing d

Re: drm: fix debug build

2017-12-21 Thread Mark Kettenis
> Date: Thu, 21 Dec 2017 13:01:31 +0200 > From: Paul Irofti > > If no one objects, I will commit this tomorrow. Fix is wrong since it will break with gcc. Probably best to just use %02x, just like we did for printing duids. > On Tue, Dec 19, 2017 at 11:14:19PM +0200, Paul Irofti wrote: > > Hi,

Re: drm: fix debug build

2017-12-21 Thread Jonathan Gray
On Thu, Dec 21, 2017 at 10:54:50PM +1100, Jonathan Gray wrote: > This appears to break the gcc DRMDEBUG build > > $ make atombios_dp.o CC=gcc COMPILER_VERSION=gcc4 > gcc -g -Werror -Wall -Wimplicit-function-declaration -Wno-uninitialized > -Wno-pointer-sign -Wno-address-of-packed-member -Wno-c

Re: drm: fix debug build

2017-12-21 Thread Jonathan Gray
This appears to break the gcc DRMDEBUG build $ make atombios_dp.o CC=gcc COMPILER_VERSION=gcc4 gcc -g -Werror -Wall -Wimplicit-function-declaration -Wno-uninitialized -Wno-pointer-sign -Wno-address-of-packed-member -Wno-constant-conversion -Wframe-larger-than=2047 -mcmodel=kernel -mno-red-zo

Re: drm: fix debug build

2017-12-21 Thread Paul Irofti
If no one objects, I will commit this tomorrow. On Tue, Dec 19, 2017 at 11:14:19PM +0200, Paul Irofti wrote: > Hi, > > I am currently trying to fix dual-monitor support for Intel HD Graphics 520. > The following fixes the build when DRM_DEBUG is enabled. OK? > > Paul > > > Index: dev/pci/drm/i