Re: ix(4): Add support for TCP Large Receive Offloading

2022-08-12 Thread Hrvoje Popovski
On 25.6.2022. 22:29, Jan Klemkow wrote: > There is a bug in the firmware of ix(4) NICs, at least with chip 82599 and > x540. I could not test it with x550 chips, but i guess they have the same > bug. Hi, I've tested tso with latest snapshot on x552 with or without vlan and everything seems to

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-10 Thread Hrvoje Popovski
On 10.6.2022. 0:24, Hrvoje Popovski wrote: > Hi, > > I tried with trunk lacp and tagged vlan700 over trunk0 and it's working > as expected. Everything is the same as before, only aggr0 is now trunk0. > > with tso > [ 4] 17.00-18.00 sec 1.09 GBytes 9.39 Gbits/sec 22622 KBytes > [ 4]

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-10 Thread Hrvoje Popovski
On 10.6.2022. 10:37, Hrvoje Popovski wrote: > while sending traffic from linux to openbsd ix0 with tso netstat while sending traffic smc24# netstat -sp tcp tcp: 1933441 packets sent 3923 data packets (684390 bytes) 0 data packets (0 bytes)

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-10 Thread Hrvoje Popovski
On 10.6.2022. 10:20, David Gwynne wrote: > > >> On 10 Jun 2022, at 08:24, Hrvoje Popovski wrote: >> >> On 9.6.2022. 19:25, Hrvoje Popovski wrote: >>> On 9.6.2022. 19:11, Jan Klemkow wrote: On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: > On 8.6.2022. 22:01, Hrvoje

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-10 Thread David Gwynne
> On 10 Jun 2022, at 08:24, Hrvoje Popovski wrote: > > On 9.6.2022. 19:25, Hrvoje Popovski wrote: >> On 9.6.2022. 19:11, Jan Klemkow wrote: >>> On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: On 8.6.2022. 22:01, Hrvoje Popovski wrote: > On 8.6.2022. 15:04, Jan

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 9.6.2022. 19:25, Hrvoje Popovski wrote: > On 9.6.2022. 19:11, Jan Klemkow wrote: >> On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: >>> On 8.6.2022. 22:01, Hrvoje Popovski wrote: On 8.6.2022. 15:04, Jan Klemkow wrote: > Could you show me, how your setup and your

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 9.6.2022. 19:11, Jan Klemkow wrote: > On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: >> On 8.6.2022. 22:01, Hrvoje Popovski wrote: >>> On 8.6.2022. 15:04, Jan Klemkow wrote: Could you show me, how your setup and your configuration looks like? >>> Yes, of course .. >>> >>>

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 8.6.2022. 22:01, Hrvoje Popovski wrote: > On 8.6.2022. 15:04, Jan Klemkow wrote: >> Could you show me, how your setup and your configuration looks like? > Yes, of course .. > > All my lab boxes are connected to switch (no flow-control). In this > setup ix0 and ix1 are in aggr and vlans 700 and

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-08 Thread Hrvoje Popovski
On 8.6.2022. 15:04, Jan Klemkow wrote: > Could you show me, how your setup and your configuration looks like? Yes, of course .. All my lab boxes are connected to switch (no flow-control). In this setup ix0 and ix1 are in aggr and vlans 700 and 800 are tagged on aggr3. I have tried tcpbench and

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-06 Thread Hrvoje Popovski
On 4.6.2022. 21:23, Hrvoje Popovski wrote: > On 1.6.2022. 11:21, Jan Klemkow wrote: >> I moved the switch to ifconfig(8) in the diff below. >> >> # ifconfig ix0 tso >> # ifconfig ix0 -tso >> >> I named it tso (TCP segment offloading), so I can reuse this switch >> also for the sending part. TSO

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-04 Thread Hrvoje Popovski
On 4.6.2022. 21:23, Hrvoje Popovski wrote: > Hi all, > > I've put this diff in production on clean source from this morning and > got panic. I'm not 100% sure if it's because of TSO because in a last > monts i had all kinds of diffs on production boxes. > Now I will run spanshot maybe clean

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-04 Thread Hrvoje Popovski
On 1.6.2022. 11:21, Jan Klemkow wrote: > I moved the switch to ifconfig(8) in the diff below. > > # ifconfig ix0 tso > # ifconfig ix0 -tso > > I named it tso (TCP segment offloading), so I can reuse this switch > also for the sending part. TSO is the combination of LRO and LSO. > > LRO: Large

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-31 Thread Stuart Henderson
Might need "make obj" -- Sent from a phone, apologies for poor formatting. On 31 May 2022 10:22:46 Hrvoje Popovski wrote: On 27.5.2022. 18:25, Jan Klemkow wrote: Hi, The following diff enables the TCP Large Receive Offloading feature for ix(4) interfaces. It also includes a default off

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-31 Thread Hrvoje Popovski
On 31.5.2022. 11:36, Theo Buehler wrote: >> smc24# cd /usr/src && make includes > > Do 'cd /usr/src && make obj' first. > Yes, thank you ...

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-31 Thread Theo Buehler
> smc24# cd /usr/src && make includes Do 'cd /usr/src && make obj' first.

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-31 Thread Hrvoje Popovski
On 27.5.2022. 18:25, Jan Klemkow wrote: > Hi, > > The following diff enables the TCP Large Receive Offloading feature for > ix(4) interfaces. It also includes a default off sysctl(2) switch. > > The TCP single stream receiving performance increased from 3.6 Gbit/s to > 9.4 Gbit/s. Measured

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-27 Thread David Gwynne
On Fri, May 27, 2022 at 06:25:00PM +0200, Jan Klemkow wrote: > Hi, > > The following diff enables the TCP Large Receive Offloading feature for > ix(4) interfaces. It also includes a default off sysctl(2) switch. > > The TCP single stream receiving performance increased from 3.6 Gbit/s to > 9.4

Re: ix(4): Add support for TCP Large Receive Offloading

2022-05-27 Thread Theo de Raadt
I really do not think sysctl makes sense for this. We do not create global knobs that affect network drivers like this. If there is going to be a knob, it should be per-interface, via ifconfig. Additionally, I am *extremely sceptical this code works. If the sysctl is changed, network