On Thu, Mar 15, 2018 at 08:37:06AM +0100, Anton Lindqvist wrote:
> On Tue, Mar 13, 2018 at 04:39:16PM +0800, Michael W. Bombardieri wrote:
> > Hello,
> >
> > Some errors and warnings printed by ksh have the function name
> > prefixed. __func__ could be used here instead of hard-coding
> > the name
Anton Lindqvist(an...@openbsd.org) on 2018.03.15 08:37:06 +0100:
> On Tue, Mar 13, 2018 at 04:39:16PM +0800, Michael W. Bombardieri wrote:
> > Hello,
> >
> > Some errors and warnings printed by ksh have the function name
> > prefixed. __func__ could be used here instead of hard-coding
> > the name
On Tue, Mar 13, 2018 at 04:39:16PM +0800, Michael W. Bombardieri wrote:
> Hello,
>
> Some errors and warnings printed by ksh have the function name
> prefixed. __func__ could be used here instead of hard-coding
> the name. The names are wrong for tty_init(), j_set_async(),
> j_change(), x_file_glo
> Please disregard my concern about consistency, I was missing something,
> not you
Sorry if it came out as out of place. I just feel like starting to
introduce the macro
in places where the function name is outright wrong might be a good idea,
since
if the function was changed once it makes sense
On Tue, Mar 13, 2018 at 12:33:36PM +0100, Klemens Nanni wrote:
> On Tue, Mar 13, 2018 at 04:39:16PM +0800, Michael W. Bombardieri wrote:
> > Some errors and warnings printed by ksh have the function name
> > prefixed. __func__ could be used here instead of hard-coding
> > the name. The names are wr
>Not sure if touching all error messages for __func__ is worth it or just
>too much churn in the end.
He already converted some so I don't see a reason to not introduce at least
that diff. If someone comes across something, he could just fix it then and
there if this issue is well-known.
On Tue,
On Tue, Mar 13, 2018 at 04:39:16PM +0800, Michael W. Bombardieri wrote:
> Some errors and warnings printed by ksh have the function name
> prefixed. __func__ could be used here instead of hard-coding
> the name. The names are wrong for tty_init(), j_set_async(),
> j_change(), x_file_glob() and c_ul
