Re: new rc.conf(8) manual

2014-08-19 Thread Robert Peichaer
On Tue, Aug 19, 2014 at 10:44:54PM +0200, Ingo Schwarze wrote:
 Hi,
 
 while working on rcctl(8), i noticed that the rc.conf(8) manual
 is of...  err, how can i express it politely...  somewhat doubtful
 quality.  Here is a stab at it.
 
 As a first step, i moved all the examples from the DESCRIPTION to
 the EXAMPLES esction.  After that, the DESCRIPTION section was
 basically empty, so i had clean earth to till.
 
 Do not attempt to read the diff.  Just apply it and read the result.
 
 OK?
   Ingo

Hi Ingo

In the Base system daemon configuration variables section, in the
last paragraph this is incorrect.

... including a string containing only a single blank character, ...

Looking at the _rc_parse_conf() code in rc.subr says, that any leading
and trailing blanks on the value side of key=value get stripped away.

And maybe it's worth a note that in case of multiple lines with the same
key, only the last is used.

Besides that OK rpe@



Re: new rc.conf(8) manual

2014-08-19 Thread Ingo Schwarze
Hi Robert,

Robert Peichaer wrote on Wed, Aug 20, 2014 at 12:39:51AM +0200:

 In the Base system daemon configuration variables section, in the
 last paragraph this is incorrect.
 
 ... including a string containing only a single blank character, ...
 
 Looking at the _rc_parse_conf() code in rc.subr says, that any leading
 and trailing blanks on the value side of key=value get stripped away.

ischwarze@isnote $ grep ^tftpd /etc/rc.conf.local
tftpd_flags= 
ischwarze@isnote $ sudo /etc/rc.d/tftpd -d start  /dev/null 
usage: tftpd [-46cdv] [-l address] [-p port] [-r socket] directory
ischwarze@isnote $ sudoedit /etc/rc.conf.local
ischwarze@isnote $ grep ^tftpd /etc/rc.conf.local
tftpd_flags=
ischwarze@isnote $ sudo /etc/rc.d/tftpd -d start  /dev/null 
ischwarze@isnote $ ps ax | grep tftp 
 8194 ??  Is  0:00.00 /usr/sbin/tftpd /tftpboot

Works for me...

I don't understand why it doesn't work for you.

 And maybe it's worth a note that in case of multiple lines with the same
 key, only the last is used.

Well, you might already implicitly conclude that from the second
paragraph:

 It is advisable to leave rc.conf untouched, and instead create
 and edit a new rc.conf.local file.  Variables set in this file
 will override variables previously set in rc.conf.

But we could make that more explicit:

 It is advisable to leave rc.conf untouched, and instead create 
 and edit a new rc.conf.local file.  Since only the last assignment
 to any variable takes effect, variables set in this file override
 variables previously set in rc.conf.

 Besides that OK rpe@

Thanks for checking!

Yours,
  Ingo