Re: rasops(9): Use proper RGB values for the ANSI color palette

2017-01-07 Thread Mark Kettenis
> Date: Sat, 7 Jan 2017 12:20:06 +
> From: Visa Hankala 
> 
> On Sat, Jan 07, 2017 at 12:23:31AM +0100, Frederic Cambus wrote:
> > Hi tech@,
> > 
> > Here is a diff to use proper RGB values for the ANSI color palette in
> > rasops(9).
> > 
> > Comments? OK?
> 
> I prefer the old palette because its contrast is higher.

Right.  I don't see why we should change this.  On top of that, on
sparc64 the colors are carefully matched to what OpenFirmware uses for
the console.  So changing white will make things look ugly.

> > Index: sys/dev/rasops/rasops.c
> > ===
> > RCS file: /cvs/src/sys/dev/rasops/rasops.c,v
> > retrieving revision 1.44
> > diff -u -p -r1.44 rasops.c
> > --- sys/dev/rasops/rasops.c 15 Dec 2016 19:18:41 -  1.44
> > +++ sys/dev/rasops/rasops.c 6 Jan 2017 22:11:02 -
> > @@ -48,21 +48,21 @@
> >  /* ANSI colormap (R,G,B) */
> >  
> >  #defineNORMAL_BLACK0x00
> > -#defineNORMAL_RED  0x7f
> > -#defineNORMAL_GREEN0x007f00
> > -#defineNORMAL_BROWN0x7f7f00
> > -#defineNORMAL_BLUE 0x7f
> > -#defineNORMAL_MAGENTA  0x7f007f
> > -#defineNORMAL_CYAN 0x007f7f
> > -#defineNORMAL_WHITE0xc7c7c7/* XXX too dim? */
> > +#defineNORMAL_RED  0xaa
> > +#defineNORMAL_GREEN0x00aa00
> > +#defineNORMAL_BROWN0xaa5500
> > +#defineNORMAL_BLUE 0xaa
> > +#defineNORMAL_MAGENTA  0xaa00aa
> > +#defineNORMAL_CYAN 0x00
> > +#defineNORMAL_WHITE0xaa
> >  
> > -#defineHILITE_BLACK0x7f7f7f
> > -#defineHILITE_RED  0xff
> > -#defineHILITE_GREEN0x00ff00
> > -#defineHILITE_BROWN0x00
> > -#defineHILITE_BLUE 0xff
> > -#defineHILITE_MAGENTA  0xff00ff
> > -#defineHILITE_CYAN 0x00
> > +#defineHILITE_BLACK0x55
> > +#defineHILITE_RED  0xff
> > +#defineHILITE_GREEN0x55ff55
> > +#defineHILITE_BROWN0x55
> > +#defineHILITE_BLUE 0xff
> > +#defineHILITE_MAGENTA  0xff55ff
> > +#defineHILITE_CYAN 0x55
> >  #defineHILITE_WHITE0xff
> >  
> >  const u_char rasops_cmap[256 * 3] = {
> > 
> 
> 



Re: rasops(9): Use proper RGB values for the ANSI color palette

2017-01-07 Thread Visa Hankala
On Sat, Jan 07, 2017 at 12:23:31AM +0100, Frederic Cambus wrote:
> Hi tech@,
> 
> Here is a diff to use proper RGB values for the ANSI color palette in
> rasops(9).
> 
> Comments? OK?

I prefer the old palette because its contrast is higher.

> Index: sys/dev/rasops/rasops.c
> ===
> RCS file: /cvs/src/sys/dev/rasops/rasops.c,v
> retrieving revision 1.44
> diff -u -p -r1.44 rasops.c
> --- sys/dev/rasops/rasops.c   15 Dec 2016 19:18:41 -  1.44
> +++ sys/dev/rasops/rasops.c   6 Jan 2017 22:11:02 -
> @@ -48,21 +48,21 @@
>  /* ANSI colormap (R,G,B) */
>  
>  #define  NORMAL_BLACK0x00
> -#define  NORMAL_RED  0x7f
> -#define  NORMAL_GREEN0x007f00
> -#define  NORMAL_BROWN0x7f7f00
> -#define  NORMAL_BLUE 0x7f
> -#define  NORMAL_MAGENTA  0x7f007f
> -#define  NORMAL_CYAN 0x007f7f
> -#define  NORMAL_WHITE0xc7c7c7/* XXX too dim? */
> +#define  NORMAL_RED  0xaa
> +#define  NORMAL_GREEN0x00aa00
> +#define  NORMAL_BROWN0xaa5500
> +#define  NORMAL_BLUE 0xaa
> +#define  NORMAL_MAGENTA  0xaa00aa
> +#define  NORMAL_CYAN 0x00
> +#define  NORMAL_WHITE0xaa
>  
> -#define  HILITE_BLACK0x7f7f7f
> -#define  HILITE_RED  0xff
> -#define  HILITE_GREEN0x00ff00
> -#define  HILITE_BROWN0x00
> -#define  HILITE_BLUE 0xff
> -#define  HILITE_MAGENTA  0xff00ff
> -#define  HILITE_CYAN 0x00
> +#define  HILITE_BLACK0x55
> +#define  HILITE_RED  0xff
> +#define  HILITE_GREEN0x55ff55
> +#define  HILITE_BROWN0x55
> +#define  HILITE_BLUE 0xff
> +#define  HILITE_MAGENTA  0xff55ff
> +#define  HILITE_CYAN 0x55
>  #define  HILITE_WHITE0xff
>  
>  const u_char rasops_cmap[256 * 3] = {
>