Re: trunk vs busy ports

2015-11-20 Thread David Gwynne
> On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. >> >> perhaps a better check is to see whether there are pending packets >> on the send

Re: trunk vs busy ports

2015-11-20 Thread Reyk Floeter
On Fri, Nov 20, 2015 at 11:27:05PM +1000, David Gwynne wrote: > > > On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > >> IFF_OACTIVE means the hardware ring is full, not if it is busy. > >> > >> perhaps a

Re: trunk vs busy ports

2015-11-20 Thread Hrvoje Popovski
On 20.11.2015. 6:36, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. > > perhaps a better check is to see whether there are pending packets > on the send queue? > > i could also argue we dont need the check at all, but this is less > of a semantic change.

Re: trunk vs busy ports

2015-11-20 Thread Reyk Floeter
On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. > > perhaps a better check is to see whether there are pending packets > on the send queue? > > i could also argue we dont need the check at all, but this is less > of

Re: trunk vs busy ports

2015-11-20 Thread David Gwynne
> On 20 Nov 2015, at 8:18 PM, Martin Pieuchot wrote: > > On 20/11/15(Fri) 15:36, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. > > As discussed earlier, I'd still love to have a document (manpage?) > describing these flags so we can

Re: trunk vs busy ports

2015-11-20 Thread Hrvoje Popovski
On 20.11.2015. 13:26, Hrvoje Popovski wrote: > On 20.11.2015. 6:36, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. >> >> perhaps a better check is to see whether there are pending packets >> on the send queue? >> >> i could also argue we dont need the check

Re: trunk vs busy ports

2015-11-20 Thread Martin Pieuchot
On 20/11/15(Fri) 15:36, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. As discussed earlier, I'd still love to have a document (manpage?) describing these flags so we can agree on when to use them. > perhaps a better check is to see whether there are

Re: trunk vs busy ports

2015-11-20 Thread sven falempin
On Fri, Nov 20, 2015 at 9:00 AM, Reyk Floeter wrote: > On Fri, Nov 20, 2015 at 11:27:05PM +1000, David Gwynne wrote: > > > > > On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > > > > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > > >>