Re: Test failure with Apache::Test 1.03, Apache/2.0.40 and perl-5.8.1-to-be

2003-07-11 Thread Randy Kobes
On Fri, 11 Jul 2003, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: [ .. ] > > Now I get a different failure ("Alias" is now invalid): [ .. ] > > waiting for server to start: .Syntax error on line 76 of > > /home/slavenr/work2/httpd-test/perl-framework/Apache-Test/t/conf/httpd.conf: > > Invalid co

Re: [patch] have_apache_mpm()

2003-07-11 Thread William A. Rowe, Jr.
At 12:21 PM 7/11/2003, Geoffrey Young wrote: >in either case, I still think have_apache_mpm() is a decent API for >Apache-Test, no matter how it's implemented behind the scenes. does it make >sense to get that in first as I last proposed then change the implementation >later? I guess the othe

Re: [patch] have_apache_mpm()

2003-07-11 Thread Stas Bekman
Geoffrey Young wrote: William A. Rowe, Jr. wrote: > At 07:02 PM 7/9/2003, Geoffrey Young wrote: > > >> William A. Rowe, Jr. wrote: >> >>> It seems like the API for ap_mpm_query would be simpler to >>> follow, just extended to run outside-of-apache. >> >> probably, and it would certainly b

Re: Test failure with Apache::Test 1.03, Apache/2.0.40 and perl-5.8.1-to-be

2003-07-11 Thread Stas Bekman
[EMAIL PROTECTED] wrote: Randy Kobes wrote: On Sun, 6 Jul 2003, Slaven Rezic wrote: make test fails with following output: /usr/perl5.8.1/bin/perl -Iblib/arch -Iblib/lib \ t/TEST -clean APACHE= APXS= APACHE_PORT= APACHE_USER= APACHE_GROUP= \ /usr/perl5.8.1/bin/perl -Iblib/arch -Iblib/lib \ t/TEST

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
David Wheeler wrote: On Friday, July 11, 2003, at 09:27 AM, Sander Temme wrote: The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? Yes, th

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread David Wheeler
On Friday, July 11, 2003, at 09:27 AM, Sander Temme wrote: The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? Yes, the redirect_ok subrouti

Re: [patch] have_apache_mpm()

2003-07-11 Thread Geoffrey Young
William A. Rowe, Jr. wrote: > At 07:02 PM 7/9/2003, Geoffrey Young wrote: > > >> William A. Rowe, Jr. wrote: >> >>> It seems like the API for ap_mpm_query would be simpler to >>> follow, just extended to run outside-of-apache. >> >> probably, and it would certainly be safer than checking -V >> out

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Sander Temme
on 7/11/03 9:06, David Wheeler at [EMAIL PROTECTED] wrote: > The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? > --- TestRequest.pm.~1.8

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread David Wheeler
On Friday, July 11, 2003, at 02:22 AM, Stas Bekman wrote: diff -u -r1.81 TestRequest.pm --- Apache-Test/lib/Apache/TestRequest.pm 8 Jul 2003 07:56:24 - 1.81 +++ Apache-Test/lib/Apache/TestRequest.pm 11 Jul 2003 04:28:45 - @@ -88,14 +88,12 @@ $UA = undef; } -

Re: Test failure with Apache::Test 1.03, Apache/2.0.40 and perl-5.8.1-to-be

2003-07-11 Thread slaven
> Randy Kobes wrote: > > On Sun, 6 Jul 2003, Slaven Rezic wrote: > > > >>make test fails with following output: > >> > >>/usr/perl5.8.1/bin/perl -Iblib/arch -Iblib/lib \ > >>t/TEST -clean > >>APACHE= APXS= APACHE_PORT= APACHE_USER= APACHE_GROUP= \ > >>/usr/perl5.8.1/bin/perl -Iblib/arch -Iblib/lib

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
Sander Temme wrote: on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote: Does this work? else if ($redir) { $RedirectOK = $redir; } It does. However, isn't this the same condition as in the top if clause? Wouldn't you want to: Index: Apache-Test/lib/Apache/TestRequest.pm ==

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Sander Temme
on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote: > > Does this work? > > else if ($redir) { >$RedirectOK = $redir; > } It does. However, isn't this the same condition as in the top if clause? Wouldn't you want to: Index: Apache-Test/lib/Apache/TestRequest.pm ==

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
Sander Temme wrote: on 7/10/03 12:56, Sander Temme at [EMAIL PROTECTED] wrote: parameter to the request invocations in t/apache/acceptpathinfo.t. Neither produces any result. Am I looking in the right place? Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by liberally sprinklin