Re: [Thunar-dev] Ejecting USB flash drives

2011-02-22 Thread Tino Keitel
On Tue, Feb 22, 2011 at 17:42:49 +0100, Harald Judt wrote:
 Hi,
 
 Since thunar switched to udev, the unmount action has been
 replaced with an eject action which unfortunately removes the
 drive from the list in the left-pane menu.
 
 I do not want that; I want the USB flash drive in my list as long as
 it is physically attached to the computer. Eject is wrong here
 anyway, you can't eject it like you can a CD or DVD. How can I
 revert this annoying behaviour?
 
 @thunar-dev: If this is only possible via patching the sources, I'm
 very willing to do it this way.

I HAL times, thunar gathered the eject capability from HAL and used it
if the HAL entry had it set.  So to enable/disable the eject entry you
had to change/add according entries in a HAL fdi file.  I don't know
how it currently works, but maybe a similar interface exists that just
needs to be adjusted to your needs.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] Ejecting USB flash drives

2011-02-22 Thread Tino Keitel
On Tue, Feb 22, 2011 at 20:22:20 +0100, Tino Keitel wrote:
 On Tue, Feb 22, 2011 at 17:42:49 +0100, Harald Judt wrote:
  Hi,
  
  Since thunar switched to udev, the unmount action has been
  replaced with an eject action which unfortunately removes the
  drive from the list in the left-pane menu.
  
  I do not want that; I want the USB flash drive in my list as long as
  it is physically attached to the computer. Eject is wrong here
  anyway, you can't eject it like you can a CD or DVD. How can I
  revert this annoying behaviour?
  
  @thunar-dev: If this is only possible via patching the sources, I'm
  very willing to do it this way.
 
 I HAL times, thunar gathered the eject capability from HAL and used it
 if the HAL entry had it set.  So to enable/disable the eject entry you
 had to change/add according entries in a HAL fdi file.  I don't know
 how it currently works, but maybe a similar interface exists that just
 needs to be adjusted to your needs.

I found eject related settings in
/usr/share/polkit-1/actions/org.freedesktop.udisks.policy:

  action id=org.freedesktop.udisks.drive-eject
[...]
defaults
  allow_anyno/allow_any
  allow_inactiveno/allow_inactive
  allow_activeyes/allow_active
/defaults
  /action

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] thunar-volman ported to udev/GIO

2010-07-21 Thread Tino Keitel
On Wed, Jul 21, 2010 at 14:14:54 +0200, Jannis Pohlmann wrote:
 
 What you need to test these changes is the jannis/port-to-udev
 branch of Thunar and the branch with the same name of thunar-volman.
 Enjoy!

Does this work with xfce 4.6, or only with 4.7?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] Thunar disturbs hard disk spindown

2010-01-26 Thread Tino Keitel
On Tue, Jan 26, 2010 at 13:17:50 +0100, Tino Keitel wrote:
 Hi,
 
 sometimes I notice that a process called thunar-vfs-mime causes my hard
 disk to spin up, according to the kernel log after
 echo 1  /proc/sys/vm/block_dump:
 
 7thunar-vfs-mime(8315): dirtied inode 3269093 (applications) on dm-5
 7thunar-vfs-mime(8315): dirtied inode 3268654 (defaults.list.CEFS6U)
 on dm-5
 7thunar-vfs-mime(8315): WRITE block 107040736 on dm-5
 7thunar-vfs-mime(8315): dirtied inode 3268657 (?) on dm-5
 2010-01-26_12:12:15.71294 Spinning up /dev/sda after 4 minutes.
 7flush-254:4(1196): WRITE block 455352 on dm-4
 2010-01-26_12:13:15.71760 Spinning down /dev/sda.

Minor addition: the PID changes each time, so it seems to be triggered
by some other service.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


[Thunar-dev] Thunar disturbs hard disk spindown

2010-01-26 Thread Tino Keitel
Hi,

sometimes I notice that a process called thunar-vfs-mime causes my hard
disk to spin up, according to the kernel log after
echo 1  /proc/sys/vm/block_dump:

7thunar-vfs-mime(8315): dirtied inode 3269093 (applications) on dm-5
7thunar-vfs-mime(8315): dirtied inode 3268654 (defaults.list.CEFS6U)
on dm-5
7thunar-vfs-mime(8315): WRITE block 107040736 on dm-5
7thunar-vfs-mime(8315): dirtied inode 3268657 (?) on dm-5
2010-01-26_12:12:15.71294 Spinning up /dev/sda after 4 minutes.
7flush-254:4(1196): WRITE block 455352 on dm-4
2010-01-26_12:13:15.71760 Spinning down /dev/sda.

I use Debian Sid with the following versions:

ii libthunar-vfs-1-2 1.0.1-2
ii thunar 1.0.1-2
ii thunar-data 1.0.1-2
ii thunar-thumbnailers 0.4.1-2
ii thunar-volman 0.3.80-3

Is this just a misconfiguration, or a bug? Usually, the HD keeps
spinned down for 30-80 minutes.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] Opened Thunar window makes mount.ntfs-3g consume too much CPU time.

2010-01-26 Thread Tino Keitel
On Tue, Jan 26, 2010 at 21:02:40 +0200, v...@ukr.net wrote:
 On Tue, 26 Jan 2010 19:01:15 +0100
 Nick Schermer nickscher...@gmail.com wrote:
  
  Stop hijacking threads on the ml, but report bugs or start a new thread.
  
  Thanks,
  Nick
 
   Ok. If the thing I wrote about is a different problem - here is a
 separate thread. :)

Hint: A reply to another mail doesn't start a new thread just because
you change the subject. You mail is still marked as being the answer to
another mail (look into the References: and In-Reply-To: headers of
your mail). Only writing a _new_ mail (an not replying to another mail)
starts a new thread.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] Ownership of auto-mounted devices

2009-08-04 Thread Tino Keitel
On Mon, Aug 03, 2009 at 16:35:51 +1000, Jonathan Hepburn wrote:

[...]

 Could someone please point me in approximately the right direction, if
 not just tell me the solution? Where is the ownership of removable
 devices decided?

I think to fix this, a few more defails are required. How exactly is
the HD mounted?  Through in-kernel ntfs or with fuse and ntfs3g? Could
you post the output of the mount command after you plugged in the HD?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to apply actions to multiple files

2009-07-07 Thread Tino Keitel
On Tue, Jul 07, 2009 at 18:48:43 +0200, Jelle de Jong wrote:
 Tino Keitel wrote:
  On Tue, Jul 07, 2009 at 10:25:12 +0200, Jelle de Jong wrote:
  Tino Keitel wrote:
  Hi folks,
 
  I'd like to know how to apply a custom action to multiple selected
  files. In this case, I have photos from my camera, which need to be
  rotated manually if taken in portrait orientation (no builtin sensor).
  I tried the custom actions, but they don't seem to work if more than
  one file is selected. Is there a different way to do this?
 
  Regards,
  Tino
  Hi Tino,
 
  You can use something like this in the custom action config:
 
  #Name:  Convert Image
  #Description:   Create special new image(s)
  #Command:   x-terminal-emulator -e
  /usr/share/pct-thunar-scripts/scripts/convert-image %F
  #Patterns:  *
  #Image Files:   True
  
  As I wrote above, I already tried to add a custom action, which looked
  pretty much like the one you suggested (unless I miss the point). But
  it's useless, as it is not present in the context menu if I select more
  than one file. Or am I doing something wrong?
 
 remove the current custom action
 
 thunar -q to kill current thunar
 
 add custom action make use to use * as patterns en true for image file check
 
 thunar -q to kill the current thunar and restart and test the custom action.

I repeated this (actually, it was the same I tried before, without the
thunar -q calls), but got the same result. The custom action is visible
when 1 file is selected, but not visible if 2 files are selected, so it
is useless for my task. At least I don't see the entry in the context
menu.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] eject usb-harddrive

2008-04-29 Thread Tino Keitel
On Tue, Apr 29, 2008 at 15:33:11 +0200, Simon Steinbeiß wrote:

[...]

 Anyways, I think that it could be sufficient as a workaround to:
 - either have a customised action in thunar only be applied to this specific 
 drive and
 spinning it down
 - or trying to hack whatever function is used by thunar to eject media like
 usb-harddrives so that it would not just unmount but also spindown the drive.

Forgot to ask one thing: do you have an eject button for your drive,
or only unmount? The Xfce 4.4.2 release was somewhat buggy regarding
the detection of removable media and providing the eject funktion in
the GUI. If you only see unmount in the context menu of the drive,
you could try exo-eject in the command line to see if that works for
you.

Regards,
Tino

___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] eject usb-harddrive

2008-04-29 Thread Tino Keitel
On Tue, Apr 29, 2008 at 16:30:10 +0200, Simon Steinbeiß wrote:

[...]

 As mentioned above, I do see the eject button. Anyways, I tried exo-eject 
 to see
 whether this would give me a more comprehensive error message, well here it 
 is (the
 command I ran was exo-eject
 -h SAME_AS_BELOW -e):
 Failed to eject
 /org/freedesktop/Hal/devices/storage_serial_WD_1200BEVExternal_575845333037343330353232_0_0.
 No property info.interfaces on device with
 id 
 /org/freedesktop/Hal/devices/storage_serial_WD_1200BEVExternal_575845333037343330353232_0_0.

Could you post the output of lshal while the drive is attached and
mounted?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] eject usb-harddrive

2008-04-29 Thread Tino Keitel
On Tue, Apr 29, 2008 at 20:22:18 +0200, Simon Steinbeiß wrote:

[...]

 Tried sudo eject -v /dev/wdpassport with the output that the eject 
 succeeded. (see the
 full output here: http://pastebin.org/32834)
 Anyhow, when I unplugged the usb-cable (that is also powering the hdd) it 
 made this awful
 sound described in the bugreport mentioned earlier.
 So it seems eject simply doesn't spin down the harddrive. Should it?

From theory, if you use eject -s, eject sends a START STOP UNIT
command, which should spin it down.

I'll try to check it myself tomorrow.

Btw., I attached an example fdi file for my card reader, to add the
requires_eject property. Maybe HAL does the right thing if you adopt it
to your hard disk and copy it to /etc/hal/fdi/policy (check with lshal
if it is really set) and then use exo-eject.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] ThunarVFS, volumes and pathes

2008-02-19 Thread Tino Keitel
On Wed, Feb 20, 2008 at 08:09:03 +0100, Christophe Chapuis wrote:
 Well, looks like I've partially found why my problem occurs...
 It looks like when I'm listing all the known volumes and ask for they
 mount path, it returns me pathes like file:///media/sda1,
 file:///media/sda2, ..., the volume being mounted or not. Therefore
 I understand that as a consequence
 thunar_vfs_volume_manager_get_volume_by_info doesn't work well.
 
 I don't have any idea where it did take that sort of path, it's not at
 all like that in my fstab, for example.

thunar can also do automatic mounts (thunar-volman), without fstab
entries. The mount path is /media/some label, so it seems to fill in
the path that is used for automatic mounts.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] Problem with thumbnails

2008-02-18 Thread Tino Keitel
On Sun, Feb 17, 2008 at 12:16:50 -0500, Erik Harrison wrote:
 On Feb 17, 2008 6:37 AM, Erlend Davidson [EMAIL PROTECTED] wrote:
 
   Hehe, high-performance and large images? It is possible to load and
   store thumbnails inside the EXIF data AFAIK. I imagine large JPEGs
   will sometimes have that. The thumbnailer could check for that and
   fail otherwise.
  
  Most images produced by a digital camera will have a thumbnail stored in
  the exiv data (it's the same thumbnail the camera uses to display the
  image on the LCD).  Thunar already extracts those (this came in 0.8.0,
  and gives very good performance).
 
   Or, the thumbnailer should gracefully fail when overwhelmed, and let
   Thunar use the generic icon for that mime type.
  Well the problem is how to tell when you're overwhelmed?  Difference
  people have difference ideas of when a thumbnailer should and shouldn't
  run... I think most people would say don't run if it's going to use swap
  space, I would say don't run if it's going to adversely affect the
  apparent responsiveness of the operating environment.  If you're running
  a remote filesystem (fusesmb / sshfs) then the file-sizes which are safe
  to thumbnail change dramatically.
 
 
 Which is why I wasn't arguing for a constant file size. I figured a
 simple timeout would scale nicely.

Thunar could also set a memory limit to the thumbnailer process (via
ulimit or similar), so that the thumbnailer process is killed if it
starts eating too much memory. Thunar woulld have to find out the hosts
memory size to calculate a sensible limit, though. IMHO a fixed value
would not work well here to satify all users. Another idea is a config
item where the user can set a maximum size for the thumbnailer process.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote:
 Yves-Alexis Perez wrote:
  I can confirm that I have no Eject button in the shortcuts pane
  without the patch, and and Eject button with the patch.
  Committed. Bug Brian to fix xfdesktop as well.
  
  Are there patches against 4.4.2?
 
 http://thunar.xfce.org/download/sources/Thunar/0.9.0/Thunar-0.9.0-use-eject-where-necessary.patch

I think that Yves-Alexis asked for an official patch for xfdesktop4. My
version can be found here:

http://bugzilla.xfce.org/show_bug.cgi?id=3738

Brian already commented it[1], and I use it for several weeks now on 2
computers.

Regards,
Tino

[1] http://www.mail-archive.com/thunar-dev@xfce.org/msg03506.html
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Jan 09, 2008 at 18:36:27 +0100, Yves-Alexis Perez wrote:
 On Wed, Jan 09, 2008 at 01:22:34PM +, Tino Keitel wrote:
  On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote:
   Yves-Alexis Perez wrote:
I can confirm that I have no Eject button in the shortcuts pane
without the patch, and and Eject button with the patch.
Committed. Bug Brian to fix xfdesktop as well.

Are there patches against 4.4.2?
   
   http://thunar.xfce.org/download/sources/Thunar/0.9.0/Thunar-0.9.0-use-eject-where-necessary.patch
  
  I think that Yves-Alexis asked for an official patch for xfdesktop4. My
  version can be found here:
  
  http://bugzilla.xfce.org/show_bug.cgi?id=3738
  
  Brian already commented it[1], and I use it for several weeks now on 2
  computers.
  
 You'll be glad, Simon Huggins just uploaded an xfdesktop with your patch :)
 
 By the way (and this is a new thread I guess), for some devices it's ok to
 have eject and umount. The only one I'm thinking of is RW CD/DVD where if the

I noticed that xfdesktop4 and thunar behaved differently in this case
and asked what I should implement, see
http://www.mail-archive.com/thunar-dev@xfce.org/msg03504.html and
Brian's reply.

Changing both to show Eject _and_ Unmount is easy, though.

Regards,
Tino

___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2008-01-09 Thread Tino Keitel
On Wed, Jan 09, 2008 at 19:40:22 +0100, Tino Keitel wrote:
 On Wed, Jan 09, 2008 at 18:36:27 +0100, Yves-Alexis Perez wrote:
  On Wed, Jan 09, 2008 at 01:22:34PM +, Tino Keitel wrote:
   On Wed, Dec 12, 2007 at 09:36:04 +0100, Benedikt Meurer wrote:
Yves-Alexis Perez wrote:
 I can confirm that I have no Eject button in the shortcuts pane
 without the patch, and and Eject button with the patch.
 Committed. Bug Brian to fix xfdesktop as well.
 
 Are there patches against 4.4.2?

http://thunar.xfce.org/download/sources/Thunar/0.9.0/Thunar-0.9.0-use-eject-where-necessary.patch
   
   I think that Yves-Alexis asked for an official patch for xfdesktop4. My
   version can be found here:
   
   http://bugzilla.xfce.org/show_bug.cgi?id=3738
   
   Brian already commented it[1], and I use it for several weeks now on 2
   computers.
   
  You'll be glad, Simon Huggins just uploaded an xfdesktop with your patch :)
  
  By the way (and this is a new thread I guess), for some devices it's ok to
  have eject and umount. The only one I'm thinking of is RW CD/DVD where if 
  the
 
 I noticed that xfdesktop4 and thunar behaved differently in this case
 and asked what I should implement, see
 http://www.mail-archive.com/thunar-dev@xfce.org/msg03504.html and

Wrong mail. I mean this one:

http://www.mail-archive.com/thunar-dev@xfce.org/msg03496.html

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Tino Keitel
On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote:
 On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote:
  Tino Keitel wrote:
   On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote:
   Tino Keitel wrote:
   I can confirm that I have no Eject button in the shortcuts pane
   without the patch, and and Eject button with the patch.
   Committed. Bug Brian to fix xfdesktop as well.
   
   I patched xfdesktop in a minimal way (see the attachment), which lead
   to the following inconsistency:
   
   In thunar, either Eject or Unmount is shown in the menu, depending
   on thunar_vfs_volume_is_ejectable(). In xfdesktop, both Eject and
   Unmount are shown when thunar_vfs_volume_is_ejectable() returns
   true.
   
   What behaviour should be preferred?
  
  Eject.  Feel free to cook up a patch, open a bug on bugzilla, and attach it.
 
 Done.

Hi Brian,

what do you think about the patch? It does not hurry for Xfce itself,
but the Debian maintainers wait for a comment to decide if this fix can
be included in the 4.4.2 build for Debian.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-12 Thread Tino Keitel
On Wed, Dec 12, 2007 at 10:16:11 -0800, Brian J. Tarricone wrote:

[...]

 P.S.  Also, what happens for the Floppy Drive icon?  Sounds pretty 
 confusing to have an Eject menu item that -- physically -- appears to 
 do nothing (unless you're on an old Mac).

When your floppy device HAL entry contains requires_eject, then
Thunar will create an Eject menu entry. So when the hardware doesn't
support eject, but HAL reports it, then HAL is wrong, not Xfce. :-)

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


[Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
Hi,

the changelog for Thunar 0.9.0 mentions this:

---
Use the correct HAL property to determine whether a given volume or
device requires eject (Bug #3119).
---

As I wasn't aware that #3119 was already fixed in SVN, I opened #3466
and created my own fix. It asks HAL for the eject flag:

+  /* an eject menu entry is shown if this returns true */
+  volume_hal-eject = libhal_drive_requires_eject (hd);

The SVN changeset for revision 25647 shows that Benny did it in the
same way:

+  /* check if the drive requires eject */
+  volume_hal-requires_eject = libhal_drive_requires_eject (hd);

However, all the devices that previously had an eject button in the
context menu don't have it anymore with 4.4.2. I checked the lshal
output and the eject property is still there for the device:

storage.requires_eject = true  (bool)

I noticed that the changes done by Benny use a function
thunar_vfs_volume_is_ejectable(), whereas I just modified
thunar_vfs_volume_is_disc() to return true for devices with the eject
flag.

I assume that the new eject feature in 4.4.2 is tested and working, I
just don't know _how_ it works. Can anyone enlighten me what I have to
do to get the eject button back for my iPod, card reader etc.?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 09:29:24 +0100, Benedikt Meurer wrote:

[...]

 Hm, there seems to be an error in thunar-shortcuts-view.c. The Eject
 Volume action is only added for discs. Try the attached patch.

Thanks for the quick reply, I'll try the patch and report back.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 09:29:24 +0100, Benedikt Meurer wrote:

[...]

 Hm, there seems to be an error in thunar-shortcuts-view.c. The Eject
 Volume action is only added for discs. Try the attached patch.

While looking at the source, I wondered if the same patch is necessary
for thunar-tree-view.c, too.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote:
 Tino Keitel wrote:
  I can confirm that I have no Eject button in the shortcuts pane
  without the patch, and and Eject button with the patch.
 
 Committed. Bug Brian to fix xfdesktop as well.

I patched xfdesktop in a minimal way (see the attachment), which lead
to the following inconsistency:

In thunar, either Eject or Unmount is shown in the menu, depending
on thunar_vfs_volume_is_ejectable(). In xfdesktop, both Eject and
Unmount are shown when thunar_vfs_volume_is_ejectable() returns
true.

What behaviour should be preferred?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Wed, Dec 12, 2007 at 00:38:55 +0100, Tino Keitel wrote:
 On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote:
  Tino Keitel wrote:
   I can confirm that I have no Eject button in the shortcuts pane
   without the patch, and and Eject button with the patch.
  
  Committed. Bug Brian to fix xfdesktop as well.
 
 I patched xfdesktop in a minimal way (see the attachment), which lead

Forgot the attachment.

Here it is.

Regards,
Tino
diff -ru xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c
--- xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c	2007-11-17 20:31:41.0 +0100
+++ xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c	2007-12-11 22:14:46.005592273 +0100
@@ -573,8 +573,7 @@
  icon);
 }
 
-if(thunar_vfs_volume_is_disc(volume)
-thunar_vfs_volume_is_ejectable(volume))
+if(thunar_vfs_volume_is_ejectable(volume))
 {
 mi = gtk_image_menu_item_new_with_mnemonic(_(E_ject Volume));
 gtk_widget_show(mi);
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote:
 Tino Keitel wrote:
  On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote:
  Tino Keitel wrote:
  I can confirm that I have no Eject button in the shortcuts pane
  without the patch, and and Eject button with the patch.
  Committed. Bug Brian to fix xfdesktop as well.
  
  I patched xfdesktop in a minimal way (see the attachment), which lead
  to the following inconsistency:
  
  In thunar, either Eject or Unmount is shown in the menu, depending
  on thunar_vfs_volume_is_ejectable(). In xfdesktop, both Eject and
  Unmount are shown when thunar_vfs_volume_is_ejectable() returns
  true.
  
  What behaviour should be preferred?
 
 Eject.  Feel free to cook up a patch, open a bug on bugzilla, and attach it.

Done.

Btw., the 4.4.2 version is missing in Bugzilla.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] How to use the eject function

2007-12-11 Thread Tino Keitel
On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote:
 Done.

It's bug #3738.
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


Re: [Thunar-dev] backup files

2007-11-08 Thread Tino Keitel
On Thu, Nov 08, 2007 at 10:55:36 +, Erlend Davidson wrote:

[...]

 Wow - that's cool!  Would it be possible to filter files by pattern too 
 (I think this would be more useful).

I already thought about this, too. But no time to implement it, yet.

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev


[Thunar-dev] no responses to thunar bugs

2007-09-03 Thread Tino Keitel
Hi,

one month ago I started to submit thunar related patches to
bugzilla.xfce.org (2856, 3038, 3466). I got no response for any of
them. Even if the developers think that the patches are totally crap
(some of them are merely intended as a quick fix, so that it works for
me), I'd like to get such a comment, so I can try to improve them.

I also reported an issue on the xfce mailing list and was asked to open
a bug for it. So I did, I also submitted a fix for the bug. Later I
discovered that the same problem was already fixed in SVN trunk. So for
me the lack of response already lead to a waste of time by fixing
things that are already fixed.

Is there a better way to get a response for thunar related patches than
bugzilla.xfce.org?

Regards,
Tino
___
Thunar-dev mailing list
Thunar-dev@xfce.org
http://foo-projects.org/mailman/listinfo/thunar-dev