Re: [tw5] Re: Journal Button truncates existing tiddler

I’ve posted a fix here: https://github.com/Jermolene/TiddlyWiki5/commit/b95aa6ec6ad51672e9ed26ab94d7fe799698782c Best wishes Jeremy. > On 10 May 2018, at 09:34, PMario wrote: > >

Re: [tw5] Re: Journal Button truncates existing tiddler

On Thursday, May 10, 2018 at 10:11:29 AM UTC+2, BurningTreeC wrote: > > @BTC ... You may create your PR based on Jeremy's latest master :) >> So we can fix both issues >> > > Now I understand, there's the issue with the trailing whitespace and the > overwriting-problem > I'll wait a minute in

Re: [tw5] Re: Journal Button truncates existing tiddler

On Thursday, May 10, 2018 at 10:09:08 AM UTC+2, Jeremy Ruston wrote: > > We can’t use action-createtiddler for this. The tm-new-journal message is > specifically designed to be the means by which the new journal is created, > and has different behaviour. What problem are you trying to fix with

Re: [tw5] Re: Journal Button truncates existing tiddler

> > @BTC ... You may create your PR based on Jeremy's latest master :) > So we can fix both issues > Now I understand, there's the issue with the trailing whitespace and the overwriting-problem I'll wait a minute in case that someone is faster than me again ;) > > -m > > > > -- You received

Re: [tw5] Re: Journal Button truncates existing tiddler

We can’t use action-createtiddler for this. The tm-new-journal message is specifically designed to be the means by which the new journal is created, and has different behaviour. What problem are you trying to fix with it? Best wishes Jeremy. > On 10 May 2018, at 09:07, PMario

Re: [tw5] Re: Journal Button truncates existing tiddler

@BTC ... You may create your PR based on Jeremy's latest master :) So we can fix both issues -m -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [tw5] Re: Journal Button truncates existing tiddler

Hi Mario > > I think, action-createtiddler is the right way to go. .. Since there are > actually 2 problems. .. If the journal tiddler already exists, it will be > overwritten, if the name is the same. ... Have you tried the fix I commited? I think it fixes the overwriting problem. Best

Re: [tw5] Re: Journal Button truncates existing tiddler

Hi Jeremy, I think, action-createtiddler is the right way to go. .. Since there are actually 2 problems. .. If the journal tiddler already exists, it will be overwritten, if the name is the same. ... -m -- You received this message because you are subscribed to the Google Groups

Re: [tw5] Re: Journal Button truncates existing tiddler

Apologies, I’m only just catching up with this thread, but I’ve now pushed an alternate solution that hopefully fixes the problem with the extraneous space: https://github.com/Jermolene/TiddlyWiki5/commit/e6466b2c320cdab46a74aa343b6c56c5783e3f94

[tw5] Re: Journal Button truncates existing tiddler

@pmario making a PR right now - using the action-createtiddler instead of the tm-new-tiddler, which creates unique titles if the journal already exists -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop

[tw5] Re: Journal Button truncates existing tiddler

We probably need to rewrite the NewJournal buttons, so that they create new titles, if the $:/config/NewJournal/Text is existing or the tiddler is already existing. ... -m -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from

[tw5] Re: Journal Button truncates existing tiddler

On Thursday, May 10, 2018 at 1:48:36 AM UTC+2, TonyM wrote: > > > *So the bug that needs fixing is to remove the unwanted space from the end > of the New Journal Tiddler name.* > > >- The extra space is not found in $:/config/NewJournal/Text >- It occurs in New Journal and New Journal

[tw5] Re: Journal Button truncates existing tiddler

I added my solution to there, Thanks On Thursday, May 10, 2018 at 10:36:49 AM UTC+10, Diego Mesa wrote: > > semi-related: https://github.com/Jermolene/TiddlyWiki5/issues/3028 > > On Wednesday, May 9, 2018 at 6:08:48 PM UTC-5, Sean Boyle wrote: >> >> Is it just my imagination, or has this problem

[tw5] Re: Journal Button truncates existing tiddler

semi-related: https://github.com/Jermolene/TiddlyWiki5/issues/3028 On Wednesday, May 9, 2018 at 6:08:48 PM UTC-5, Sean Boyle wrote: > > Is it just my imagination, or has this problem found its way back into TW > 5.1.16? > >1. Create a journal tiddler using the new journal button >2.

[tw5] Re: Journal Button truncates existing tiddler

Sean, I presume you have set the Title of new journal tiddlers to -MM-DD or some variant there of hat does not include time. What I have notices on my wiki and tiddlywiki.com is that the new tiddler is created with a draft title of -MM-DD which when saved has the trailing space