Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-23 Thread Simon Huber
> > Especially the tm-modal message: if I want to delete a tiddler in a new > window, the modal to confirm the action appears in the root window, > tm-notify acts the same way. > Sorry, I meant the alerts for cancelling or deleting tiddlers Now I figured out how to register the new window at

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Simon Huber
Hi Jeremy, hi Andreas, I'm sorry that I cannot dig into this myself, I'm not understanding the mechanism wel enough right now. But I'll keep investigating so maybe at one point I can contribute. If we think about solving this, maybe we should also think about tm-modal and tm-notify not

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Jeremy Ruston
Hi All, The popup mechanism not working with external windows is definitely a bug, and it would be terrific to fix it. As you’ve discovered, the two mechanisms were written without regard for one another: https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/startup/windows.js

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Simon Huber
No - I'm not having success. Here I depend on help from above -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Simon Huber
thanks a lot Andreas, I've now been trying .../startup/windows.js , which handles the tm-open-window message couldn't I also try to register it from within there, when the window gets opened? I'll take a look at your tips, the second seems more appropriate to me, changing that much like in

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread 'Andreas Hahn' via TiddlyWikiDev
Hi Simon, that is almost the right place yes, if you have a look at |core/modules/startup/startup.js| [1], you will see that it initializes it without the rootElement being given anyway. The next problem is that all widgets regardless of the window they are rendered in will use

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Simon Huber
Hi, Andreas I tried hacking a bit in popup.js to see if I can register it to something different but my js knowledge is limited, I don't know what to use. Right now it does this.rootElement = options.rootElement || document.documentElement; on top of popup.js I think this must be where it can

Re: [twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread 'Andreas Hahn' via TiddlyWikiDev
Hi Simon, unfortunately this is a shortcoming of the current PopupMechanism in TiddlyWiki and will require changes to the core. The only way to open and close the popup seems to be with a button. If you happen to know javascript you could in theory write a plugin/widget to fix this by

[twdev] [TW5] enable cancelling popups in tc-single-tiddler-window

2018-02-21 Thread Simon Huber
Hi all, Is there a way to cancel popups or dropdowns created in a single-tiddler window by clicking in that window, not in the root window? As you can see here right now tw doesn't handle that: http://rocketdock.tiddlyspot.com you can click the rocket to open a new window and try the search