Re: [Tigervnc-devel] [PATCH] Retain DPI when changing framebuffer size

2009-06-02 Thread Adam Tkac
On Tue, Jun 02, 2009 at 02:02:19PM +0200, Pierre Ossman wrote: > On Tue, 2 Jun 2009 13:09:08 +0200 > Adam Tkac wrote: > > > > > Hm, patch doesn't look fine for me. > > > > First, we should use same DPI in vfbScreenInit and vncRandRSetConfig > > functions. > > It does since it first fetches the

Re: [Tigervnc-devel] [PATCH] Retain DPI when changing framebuffer size

2009-06-02 Thread Pierre Ossman
On Tue, 2 Jun 2009 13:09:08 +0200 Adam Tkac wrote: > > Hm, patch doesn't look fine for me. > > First, we should use same DPI in vfbScreenInit and vncRandRSetConfig > functions. It does since it first fetches the existing DPI. Duplicating the code from vfbScreenInit just increases the risk of g

Re: [Tigervnc-devel] [PATCH] Retain DPI when changing framebuffer size

2009-06-02 Thread Adam Tkac
On Tue, Jun 02, 2009 at 11:07:33AM +0200, Pierre Ossman wrote: > DPI is still a complete mess in X, and I don't see any point in trying > to create a proper value as we don't have any knowledge of the physical > screen in VNC. Instead we should try to retain the initial DPI at all > times as that m

[Tigervnc-devel] [PATCH] Retain DPI when changing framebuffer size

2009-06-02 Thread Pierre Ossman
DPI is still a complete mess in X, and I don't see any point in trying to create a proper value as we don't have any knowledge of the physical screen in VNC. Instead we should try to retain the initial DPI at all times as that makes things behave fairly consistent. This should be in 1.0. Index: x