Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Thu, 12 Jul 2012 18:04:40 +0200 Adam Tkac wrote: > > I dived into vncHooks and xserver sources and attached patch should fix both > screen artefacts and XDrawArc crashes. It reverts r4220 and fixes > vncHooksFillSpans hook which used wrong clip pointer. > -Inf Hooking pixmaps is just askin

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread DRC
On 7/13/12 3:09 AM, Pierre Ossman wrote: >> I dived into vncHooks and xserver sources and attached patch should fix both >> screen artefacts and XDrawArc crashes. It reverts r4220 and fixes >> vncHooksFillSpans hook which used wrong clip pointer. >> > > -Inf > > Hooking pixmaps is just asking for

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Fri, 13 Jul 2012 05:18:16 -0500 DRC wrote: > > Maybe I'm missing something, but isn't the goal to hook only drawing > commands that actually produce visible information? That being the > case, isn't the relevant data already being hooked when the pixmap gets > copied to the window using XCop

Re: [Tigervnc-devel] [PATCH] revert r4220 to fix bug #3415308

2012-07-13 Thread Pierre Ossman
On Fri, 13 Jul 2012 12:50:00 +0200 Pierre Ossman wrote: > On Fri, 13 Jul 2012 05:18:16 -0500 > DRC wrote: > > > > > Maybe I'm missing something, but isn't the goal to hook only drawing > > commands that actually produce visible information? That being the > > case, isn't the relevant data alr