On 7/13/12 3:09 AM, Pierre Ossman wrote: >> I dived into vncHooks and xserver sources and attached patch should fix both >> screen artefacts and XDrawArc crashes. It reverts r4220 and fixes >> vncHooksFillSpans hook which used wrong clip pointer. >> > > -Inf > > Hooking pixmaps is just asking for problems. You'll be using the > pixmap's coordinates for tracking changes, which makes absolutely no > sense there is no fundamental connection to screen coordinates (like > there is for windows). > > We need to find a proper way to deal with this specific case (borders). > It might be that it's impossible to hook the actual drawing itself, but > then we'll have to look at its triggering conditions instead and > duplicate some of the border logic. E.g. hooking expose events and > checking window flags.
Maybe I'm missing something, but isn't the goal to hook only drawing commands that actually produce visible information? That being the case, isn't the relevant data already being hooked when the pixmap gets copied to the window using XCopyArea()? ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
