Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread Pierre Ossman
Hi Martin, Looks good to me, with two notes: > vncviewer/keysyms.cxx | 71 > +++ > vncviewer/keysyms.h | 30 ++ Perhaps another name might be better as to not confuse this with the X11/VNC keysym handling? menukey.*? > +

Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4646] trunk/vncviewer

2011-08-26 Thread Peter Åstrand
I never said the rest of the code was doing the right thing, either. I think you're missing my point. Instead of manually including config.h in every file that needs NLS, why not simply put add_definitions(-DENABLE_NLS=1) in CMakeLists.txt? Seems much less error prone. config.h is used for ma

[Tigervnc-devel] 1.1 has no --help on ms windows

2011-08-26 Thread Antoine Martin
Hi, Only just tested 1.1, as reported previously the "winvnc4.exe --help" still does not show anything in a DOS window, but I do get the help output when I launch it from my python wrapper!? Also, the website still points to 1.0.1 as being the current version... Cheers Antoine --

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread Martin Koegler
On Fri, Aug 26, 2011 at 09:36:25AM +0200, Pierre Ossman wrote: > Looks good to me, with two notes: > > > vncviewer/keysyms.cxx | 71 > > +++ > > vncviewer/keysyms.h | 30 ++ > > Perhaps another name might be better as to n

Re: [Tigervnc-devel] 1.1 has no --help on ms windows

2011-08-26 Thread DRC
On 8/26/11 1:01 PM, Antoine Martin wrote: > Only just tested 1.1, as reported previously the "winvnc4.exe --help" > still does not show anything in a DOS window, but I do get the help > output when I launch it from my python wrapper!? > Also, the website still points to 1.0.1 as being the current v

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread DRC
On 8/26/11 12:29 PM, Martin Koegler wrote: > The three column approach would proably be the best. +1 -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified mana