Hi Martin, Looks good to me, with two notes:
> vncviewer/keysyms.cxx | 71 > +++++++++++++++++++++++++++++++++++++++++++ > vncviewer/keysyms.h | 30 ++++++++++++++++++ Perhaps another name might be better as to not confuse this with the X11/VNC keysym handling? menukey.*? > + {"Scroll_Lock", FL_Scroll_Lock}, > ... > + {"Page_Up", FL_Page_Up}, > + {"Page_Down", FL_Page_Down}, Since these strings are what's presented to the user, it would be nice if we could have a space instead of _. I guess you did this to make it easier to use them on the command line? What does everyone else think? Which interface is most important? Should we perhaps have three columns to cater to both needs? Rgds -- Pierre Ossman OpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio AB Web: http://www.cendio.com A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel