Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-13 Thread Pierre Ossman
On Thu, 8 Oct 2009 13:51:58 +0200 Adam Tkac at...@redhat.com wrote: On Thu, Oct 08, 2009 at 06:30:10PM +0700, Antoine Martin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 please check my comments directly in the patch. Note I can't test winvnc bits because currently I don't

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-13 Thread DRC
I would tend to agree. Also, we're going to start building with MinGW at some point in the not-so-distant future. Pierre Ossman wrote: I'd prefer if this was backed out. As I said, this just hides the obvious unicode handling errors without actually verifying that the rest of the code can

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-08 Thread Adam Tkac
On Thu, Oct 08, 2009 at 03:33:53AM +0700, Antoine Martin wrote: Antoine Martin wrote: Hi, Hi, please check my comments directly in the patch. Note I can't test winvnc bits because currently I don't have any VC++ environment but changes there look fine for me. You don't have to attach new

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-08 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 please check my comments directly in the patch. Note I can't test winvnc bits because currently I don't have any VC++ environment but changes there look fine for me. You don't have to attach new patch, only let us know if changes suggested below

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-08 Thread Adam Tkac
On Thu, Oct 08, 2009 at 06:30:10PM +0700, Antoine Martin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 please check my comments directly in the patch. Note I can't test winvnc bits because currently I don't have any VC++ environment but changes there look fine for me. You don't

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-08 Thread Pierre Ossman
On Thu, 08 Oct 2009 03:06:49 +0700 Antoine Martin anto...@nagafix.co.uk wrote: Hi, I eventually managed to build TigerVNC with VC++ 9 Attached are the trivial changes that I had to make. Can anyone suggest a better way of fixing those compilation errors? What sort of a patch would be

[Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-07 Thread Antoine Martin
Hi, I eventually managed to build TigerVNC with VC++ 9 Attached are the trivial changes that I had to make. Can anyone suggest a better way of fixing those compilation errors? What sort of a patch would be acceptable for merging? Mostly, just: * casts * afxres.h - windows.h (and add #define

Re: [Tigervnc-devel] [PATCH] building with Visual Studio C++ 2008 v9.0

2009-10-07 Thread Antoine Martin
DRC wrote: It shouldn't be necessary to comment out anything in stdio.h. You can pass the following arguments to cl to turn off the secure deprecation warnings: -wd4996 -D_CRT_SECURE_NO_DEPRECATE Hah, I'll have to figure out where that goes... (new to VC++) Other than that, I would change