cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java StandardManager.java

2005-06-16 Thread remm
remm2005/06/16 02:50:12 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java StandardManager.java Log: - 34760: Passivating session should not make stop fail. Revision ChangesPath 1.60 +3 -2

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:41:25 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: After deserializing a StandardSession, reinit its transient listeners and notes fields, to prevent NPEs when they are accessed. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-06-15 Thread luehe
luehe 2005/06/15 16:50:12 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverted the scope of readObject() and writeObject() from protected to private, in order to give subclasses an opportunity to implement their

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2005/03/25 08:49:28 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Commented out session validity check in StandardSession.getId(). Will revisit for 5.5.10. There will be two options for the

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-23 Thread Jan Luehe
Yoav, Yoav Shapira wrote: Hola, My believe is that the above errata will be reflected in the next (maintenance) release of the servlet spec. I will remind the servlet spec lead that this needs to happen. Jan What's the ETA on this maintenance spec release? work is supposed to start

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: billbarker2005/03/21 19:50:03 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: From the comments for R1.11, it seems that some early version of the spec had an exception here. However, this didn't

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java [EMAIL

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
Bill Barker wrote: - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread billbarker
billbarker2005/03/22 07:26:44 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverting change. Note to self: Next time check the errata as well as -fr Revision ChangesPath 1.53 +6 -2

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: billbarker2005/03/22 07:26:44 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverting change. Note to self: Next time check the errata as well as -fr I think someone closer to the spec needs to

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, March 22, 2005 7:46 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java [EMAIL

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Jan Luehe
Remy Maucherat wrote: Bill Barker wrote: - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, March 22, 2005 1:57 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-22 Thread Yoav Shapira
Hola, My believe is that the above errata will be reflected in the next (maintenance) release of the servlet spec. I will remind the servlet spec lead that this needs to happen. Jan What's the ETA on this maintenance spec release? Yoav

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, March 21, 2005 8:25 AM Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java remm2005/03/21 08:25:53 Modified:catalina/src/share

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread remm
remm2005/03/21 12:02:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Undo change. Revision ChangesPath 1.51 +4 -4

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-21 Thread billbarker
billbarker2005/03/21 19:50:03 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: From the comments for R1.11, it seems that some early version of the spec had an exception here. However, this didn't survive to the final spec

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-07-15 Thread remm
remm2004/07/15 07:42:39 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - I looked in the spec, and I don't think the notifications should be sent when replacing an attribute with the same instance. - Also add some

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-06-02 Thread remm
remm2004/06/02 03:18:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Replace this with getSession() as suggested by Filip. Revision ChangesPath 1.44 +11 -9

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread jfarcand
jfarcand2004/04/01 09:39:53 Modified:catalina/src/share/org/apache/catalina Globals.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Minor fixe. Instead of using an exclude list, make the variable transient.

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread daniel andefors
Hi, IMO, this will not work if you are trying to avoid serializing attributes with the name javax.security.auth.subject. Daniel From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread Jeanfrancois Arcand
! -- Jeanfrancois Daniel From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java Date: 1 Apr 2004 17:39:53 - jfarcand2004/04/01 09:39:53

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread daniel andefors
From: Jeanfrancois Arcand [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java Date: Thu, 01 Apr 2004 14:13:42

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-04-01 Thread jfarcand
jfarcand2004/04/01 12:18:15 Modified:catalina/src/share/org/apache/catalina Globals.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Re-add initinal work since it doesn't seems to work (my bad) Thanks to

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-25 Thread markt
markt 2004/03/25 14:17:54 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 18479. Non-serializable sessions attributes should be removed (so valueUnbound is called). This aligns the actual functionality with

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-12 Thread luehe
luehe 2004/03/12 14:36:46 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: set accessCount to 0 (instead of 1) in recycle() Revision ChangesPath 1.40 +2 -2

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-11 Thread Jan Luehe
Remy Maucherat wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 (HttpSession.setMaxInactiveInterval()

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-11 Thread luehe
luehe 2004/03/11 11:56:52 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Reverted previous change, as it breaks the fix for Bugzilla 26051. Test case for Bugtraq 4839736 (see revision 1.20) is invalid. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread luehe
luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 (HttpSession.setMaxInactiveInterval() doesn't behave as expected), which had been originally fixed in

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 (HttpSession.setMaxInactiveInterval() doesn't behave as expected), which had been

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-10 Thread Remy Maucherat
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: luehe 2004/03/10 20:18:31 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed regression re: Bugtraq 4839736 (HttpSession.setMaxInactiveInterval() doesn't behave as

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-03-04 Thread jfarcand
jfarcand2004/03/04 09:51:16 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Avoid serializing Subject/Principal when persisting the session. Revision ChangesPath 1.36 +27 -2

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-23 Thread remm
remm2004/01/23 14:29:32 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Bug 26341: When calling the removeAttributes during session expiration, notified attributes should see the session as invalid. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-22 Thread remm
remm2004/01/22 10:21:21 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Improvements to session activity tracking, handling the case where the session is new, as well as cross context. - If this doesn't work, I

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-21 Thread remm
remm2004/01/21 02:46:59 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Remove some synchronization. - Avoid useless event objects allocation. - Minimize the amount of hashmap lookups. - Bug 26051: session must

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-19 Thread Mark Thomas
My hair splitting detector is beeping. This session code will need to be optimized, BTW. Will do. Tomorrow OK? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-19 Thread remm
remm2004/01/19 15:39:05 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Don't call expire after calling isValid. - Bug 26261, submitted by Paul Harvey. Revision ChangesPath 1.29 +5 -11

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread markt
markt 2004/01/18 12:37:52 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Fix bug 12363. valueBound() must be called before the object is made available via getAttribute() . Submitted by: Pablo Morales Revision

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread Mark Thomas
Resending from right account. My hair splitting detector is beeping. This session code will need to be optimized, BTW. Will do. Tomorrow OK? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-12-31 Thread remm
remm2003/12/31 13:24:56 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Bug 25792: Fix session timeout implementation, which could lead to incorrect invalidation in some cases. - Submitted by Jarno Peltoniemi. -

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-11-25 Thread remm
remm2003/11/24 23:56:27 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - It seems that, for consistency, getLastAccessedTime should not throw an ISE while expiring. This allows addressing bug 9077. - Patch

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-10-02 Thread jfarcand
jfarcand2003/10/02 10:10:54 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix for bugzilla 23525 HttpSessionListener implementors are called to late according to Servlet Specification 2.4 Final Draft 3. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-10-02 Thread jfarcand
jfarcand2003/10/02 18:53:17 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: We also need to call the listener when the session is invalidated because we can't predict the interval between the time the session is marked

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-08-10 Thread remm
remm2003/08/09 12:04:29 Modified:catalina/src/share/org/apache/catalina Context.java catalina/src/share/org/apache/catalina/core ApplicationContext.java StandardContext.java StandardContextValve.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-03-12 Thread luehe
luehe 2003/03/12 18:26:32 Modified:catalina/src/share/org/apache/catalina/core StandardHostValve.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fixed Bugtraq 4661001:

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-03-11 Thread jfarcand
jfarcand2003/03/11 19:53:15 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Forgot to commit this one. Add a doPrivileged block. Revision ChangesPath 1.14 +18 -6

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-02-18 Thread luehe
luehe 2003/02/18 16:33:28 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix for Bugtraq 4688277: Invoking session.invalidate() after setting max inactive interval to 0 does not throw IllegalStateException The

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2003-02-10 Thread remm
remm2003/02/10 01:59:01 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Experiment: add some syncing in Session.expire. Revision ChangesPath 1.12 +58 -49

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:48:24 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Fix typo in LocalStrings property Revision ChangesPath 1.9 +5 -5

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-12-31 Thread glenn
glenn 2002/12/31 04:53:45 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: oops, revert last change Revision ChangesPath 1.10 +5 -5

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-11-26 Thread jfarcand
jfarcand2002/11/26 11:56:10 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: Change HttpSessionListener.sessionDestroyed() from notifying after the invalidation to notifying before the invalidation (Servlet 2.4 spec change).

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-08-29 Thread bobh
bobh2002/08/29 15:23:38 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - fix for some of bug 12147 Namely, logout() was deferring to the SingleSignOn bit to perform the logout - however if SingleSignOn isn't being

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-08-12 Thread patrickl
patrickl2002/08/12 12:12:44 Modified:catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java catalina/src/share/org/apache/catalina/session StandardSession.java Log: This patch causes logout() and

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2002-07-23 Thread remm
remm2002/07/23 05:49:55 Modified:catalina/src/share/org/apache/catalina/session StandardSession.java Log: - Set manager to null before recycling. - Patch submitted by Arvind Srinivasan arvind.srinivasan at sun.com Revision ChangesPath 1.2