cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2005-09-29 Thread costin
costin 2005/09/29 07:36:25 Modified:catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: Busted by the tab police, fixed the settings. Revision ChangesPath 1.10 +4 -4 jakarta-tomcat-catalina/catalina/src/share/org

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2004-07-23 Thread remm
remm2004/07/23 15:42:16 Modified:catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: - enum -> enumeration (JDK 1.5 update). Revision ChangesPath 1.7 +4 -4 jakarta-tomcat-catalina/catalina/src/share/org/apach

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2004-05-18 Thread jfarcand
jfarcand2004/05/18 09:33:24 Modified:catalina/src/conf catalina.properties catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: Make catalina.properties file configurable from catalina.base as well as catalina.home. Somet

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-11-13 Thread remm
remm2003/11/13 08:37:06 Modified:catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: - Convinience feature: set as system property everything in that file. - This could work well along with the property replacement to be added in

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Remy Maucherat
Jan Luehe wrote: Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the hardcoded list that you put in TldConfig. I don't thi

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extensio

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extensio

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Remy Maucherat
Jan Luehe wrote: Remy Maucherat wrote: As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of the patch back in, without the CatalinaProperties.setProperty, which I'll keep as a private extension for now. I meant the h

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy Maucherat wrote: OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Thanks :) As for a solution, I believe your hardcoded list was acceptable, if not completely optimal. OK, in this case, I'll add that part of t

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Remy Maucherat
Jan Luehe wrote: Remy, I leave the judgement up to the community. I'll have to reiterate my -1. OK, I'll revert my patch (and leave it as a private extension), until we have found a better solution that everybody agrees on. Thanks :) As for a solution, I believe your hardcoded list was acceptab

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Jan Luehe
Remy, As I mentioned in my private email to you, it may not always be practical to rely on the list of "noTldJars" configured in catalina.properties if you bundle Tomcat with your own product. That's why I added the setProperty method on CatalinaProperties, in order to be able to override the valu

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Remy Maucherat
Craig R. McClanahan wrote: Remy Maucherat wrote: Jan Luehe wrote: good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I honestly don't understand why we're searching paren

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-26 Thread Remy Maucherat
Jan Luehe wrote: Remy, sorry, but I don't see which part of our email exchange you found "very frustrating". As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. I've done some measurements on my Ultra 60. TldConfig already calculates the tldScanTime

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Remy Maucherat
Hans Bergsten wrote: Jan Luehe wrote: I think it depends on whether you anticipate (or support) LiteWebServer being bundled (as one or more libraries) into other products that use a different directory layout, with different locations for shared libs. If that's the case, limiting the location

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Hans Bergsten
Jan Luehe wrote: Hans, good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I don't give them that option (with regards to this) in LiteWebServer. The only place I look fo

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
Hans, good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I don't give them that option (with regards to this) in LiteWebServer. The only place I look for shared librarie

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Hans Bergsten
Jan Luehe wrote: Hans, thanks for stepping in. sorry, but I don't see which part of our email exchange you found "very frustrating". As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. [...] Sorry for not jumping in earlier in this discussion. Whe

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Craig R. McClanahan
Remy Maucherat wrote: Jan Luehe wrote: good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I honestly don't understand why we're searching parent classloaders for TLDs.

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Remy Maucherat
Jan Luehe wrote: good point. What about environments that embed Tomcat without following Tomcat's directory layout, and in which the classloader hierachy/depth is different from that in Tomcat? I honestly don't understand why we're searching parent classloaders for TLDs. Remy

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
Hans, thanks for stepping in. sorry, but I don't see which part of our email exchange you found "very frustrating". As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. [...] Sorry for not jumping in earlier in this discussion. When I implemented t

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Hans Bergsten
Jan Luehe wrote: Remy, sorry, but I don't see which part of our email exchange you found "very frustrating". As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. [...] Sorry for not jumping in earlier in this discussion. When I implemented the "shared

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Jan Luehe
Remy, sorry, but I don't see which part of our email exchange you found "very frustrating". As I said, I'm open to suggestions, and if my patch is deemed useless, I'll revert it. No problem. I've done some measurements on my Ultra 60. TldConfig already calculates the tldScanTime for each context,

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2003/09/24 12:09:29 Modified:catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: Added setProperty method. For example, this will allow the value for the "noTldJars" property to be determined and

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup CatalinaProperties.java

2003-09-24 Thread luehe
luehe 2003/09/24 12:09:29 Modified:catalina/src/share/org/apache/catalina/startup CatalinaProperties.java Log: Added setProperty method. For example, this will allow the value for the "noTldJars" property to be determined and set dynamically. Rev