pero2005/01/29 11:30:44
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
recreate server Socket after stop!
Revision ChangesPath
1.43 +1 -0
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
remm2004/10/14 01:07:48
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Remove bad shutdown logic for ms strategy.
Revision ChangesPath
1.42 +3 -7
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
remm2004/10/05 15:16:20
Modified:util/java/org/apache/tomcat/util/net/res
LocalStrings.properties
util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Improve i18n (help is needed to do this kind of work everywhere :) ).
-
remm2004/10/03 04:48:59
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Oops, made a mistake with what the default should be. Probably I set that to the
wrong value during early testing.
Revision ChangesPath
1.40 +1 -1
yoavs 2004/05/27 09:12:46
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Added support for threadPriority attribute
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=28914).
Revision ChangesPath
1.37 +9 -3
[EMAIL PROTECTED] wrote:
luehe 2004/02/02 15:08:29
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Expose handshake failure as error, so it gets logged unconditionally
-1. Unlike what occurs for normal sockets, errors at this point are
rather common,
luehe 2004/02/03 12:28:56
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Reverted change that was done in revision 1.34
Revision ChangesPath
1.35 +4 -4
luehe 2004/02/02 15:08:29
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Expose handshake failure as error, so it gets logged unconditionally
Revision ChangesPath
1.34 +4 -4
remm2004/01/26 10:19:48
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Implement clean shutdown of the connectors (my third proposal).
- Add pause and resume methods on the TCP endpoint.
- The method I've choosen is to stop accepting to inform
remm2004/01/26 11:49:18
Modified:util/java/org/apache/tomcat/util/threads Reaper.java
ThreadPool.java
util/java/org/apache/tomcat/util/buf MessageBytes.java
UDecoder.java
remm2004/01/13 01:56:24
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Fix build.
- Also group evertything in a big try catch, with a small flag for the logging.
That way, this critical code will be less error prone. Logging will be, but it's
if( usePool ) {
con=(TcpConnection)connectionCache.get();
if( con == null )
I would like to remove this pool thing. It is dead code (there's a
static final flag to enable it at compile time), so I think it should go.
Rémy
remm2004/01/13 02:16:39
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- So I'm removing the pool thing. Feel free to let me know if this was actually
useful.
Revision ChangesPath
1.31 +10 -33
billbarker2004/01/12 20:58:35
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Move the call to setSocketOptions to prevent a potential DoS condition when using
SSL.
Reported By: Alex Chan [EMAIL PROTECTED]
Revision ChangesPath
1.29 +4
[EMAIL PROTECTED] wrote:
amyroh 2003/11/24 15:01:22
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed.
[EMAIL PROTECTED] wrote:
amyroh 2003/11/24 15:01:22
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed.
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Tuesday, November 25, 2003 12:27 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
[EMAIL PROTECTED] wrote
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Tuesday, November 25, 2003 12:27 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
[EMAIL PROTECTED] wrote
amyroh 2003/11/24 15:01:22
Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed.
Revision Changes
luehe 2003/11/03 13:13:01
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Reverted support for maxThreads=1
Revision ChangesPath
1.27 +9 -24
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
Bill Barker wrote:
Jan Luehe [EMAIL PROTECTED] wrote in message
Remy,
I think we should make any maxThreads setting work, as my patch
attempts to do, and update the documentation to make users aware of
the limitations they will run into when picking a low maxThreads.
I think that would be the
Could a simple compromise be
- Die (with error message) if 2
- Warn if less than 10 (or ??). Letting the user be stupid, but warn them
about it.
-Tim
Bill Barker wrote:
Jan Luehe [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Remy,
I agree we should help users come up with
Tim Funk wrote:
Could a simple compromise be
- Die (with error message) if 2
- Warn if less than 10 (or ??). Letting the user be stupid, but warn
them about it.
I don't agree with that behavior. Why should we fail or (worse) allow
bad values ? Good defaults and being tolerant is a quality of
+1 on that.
I'd rather that TC defaulted to safe values over my idotically low or even
absent settings.
-- Sriram
--- Remy Maucherat [EMAIL PROTECTED] wrote:
Tim Funk wrote:
Could a simple compromise be
- Die (with error message) if 2
- Warn if less than 10 (or ??). Letting the user be
Jan Luehe wrote:
Remy Maucherat wrote:
I guess I don't understand what makes 1 bad but 2 OK. Where do we
draw the line of what is a stupid config?
Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable
minimal value for maxThreads; let's say 10 - 20.
Remy
Remy Maucherat wrote:
Jan Luehe wrote:
Remy Maucherat wrote:
I guess I don't understand what makes 1 bad but 2 OK. Where do we
draw the line of what is a stupid config?
Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable
minimal value for maxThreads; let's say 10 - 20.
Remy,
I
Jan Luehe wrote:
I agree we should help users come up with reasonable config values,
but I'm just afraid rejecting any maxThreads 10 or 20 will send the
wrong message, as if there was a bug in the way we dispatch incoming
requests that requires at least 10 threads.
Nope, I disagree. If
Remy,
I agree we should help users come up with reasonable config values,
but I'm just afraid rejecting any maxThreads 10 or 20 will send the
wrong message, as if there was a bug in the way we dispatch incoming
requests that requires at least 10 threads.
Nope, I disagree. If maxThreads (say)
Jan Luehe [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Remy,
I agree we should help users come up with reasonable config values,
but I'm just afraid rejecting any maxThreads 10 or 20 will send the
wrong message, as if there was a bug in the way we dispatch incoming
luehe 2003/10/30 13:01:39
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Fixed problem where if maxThreads is set to 1,
ThreadPool.findControlRunnable() will log this error on the first
request:
SEVERE: All threads (1) are currently busy,
[EMAIL PROTECTED] wrote:
luehe 2003/10/30 13:01:39
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Fixed problem where if maxThreads is set to 1,
ThreadPool.findControlRunnable() will log this error on the first
request:
SEVERE: All threads (1)
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Thursday, October 30, 2003 1:45 PM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
[EMAIL PROTECTED] wrote
Bill Barker wrote:
[EMAIL PROTECTED] wrote:
luehe 2003/10/30 13:01:39
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Fixed problem where if maxThreads is set to 1,
ThreadPool.findControlRunnable() will log this error on the first
request:
SEVERE: All
Remy Maucherat wrote:
Bill Barker wrote:
[EMAIL PROTECTED] wrote:
luehe 2003/10/30 13:01:39
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Fixed problem where if maxThreads is set to 1,
ThreadPool.findControlRunnable() will log this error on the first
glenn 2003/10/22 06:46:28
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
SocketExceptions can occur in a networked app.
No need to log a stack trace, just log the remote host
name/ip and the exception message. Then there is less
cruft in the logs.
[EMAIL PROTECTED] wrote:
glenn 2003/10/22 06:46:28
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
SocketExceptions can occur in a networked app.
No need to log a stack trace, just log the remote host
name/ip and the exception message. Then there is
Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:
glenn 2003/10/22 06:46:28
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
SocketExceptions can occur in a networked app.
No need to log a stack trace, just log the remote host
name/ip and the exception
billbarker2003/10/12 14:08:22
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Don't pretend that we are going to do something if the SSL handshake fails.
Revision ChangesPath
1.23 +4 -3
billbarker2003/10/12 14:15:53
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Don't pretend that the tab-police won't come after you.
Revision ChangesPath
1.24 +4 -4
remm2003/10/04 11:05:29
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- No bug fix !
- Use the appropriate exception for killing the thread,
- Improve ifs.
- Replace while + break with a simpler (IMO) if.
- Please let me know ASAP if there's a
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Saturday, October 04, 2003 11:05 AM
Subject: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
remm2003/10/04 11:05:29
Modified:util/java/org/apache
- Original Message -
From: Bill Barker [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Saturday, October 04, 2003 3:10 PM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
- Original Message
remm2003/10/03 03:48:45
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Change the way to kill the thread after a server socket restart.
Revision ChangesPath
1.20 +10 -8
remm2003/09/22 23:37:08
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Fix logging of errors which occur in setSocketOptions.
- This will also cause the connection to not be processed (which is a good
thing, obviously).
Revision Changes
remm2003/09/23 00:09:55
Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10
PoolTcpEndpoint.java
Log:
- Port patch.
- Don't catch SocketException when setting the socket options, so that when
it happens the socket is discarded right away.
hgomez 2003/09/18 09:09:16
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Clean Import, the first one
Revision ChangesPath
1.18 +15 -10
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
Index:
On 12 Sep 2003, [EMAIL PROTECTED] wrote:
+++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16
@@ -389,12 +389,12 @@
if (accepted != null) {
try {
accepted.close();
-accepted = null;
- Original Message -
From: Stefan Bodewig [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Friday, September 12, 2003 12:58 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net
PoolTcpEndpoint.java
On 12 Sep 2003, [EMAIL PROTECTED] wrote
Bill Barker wrote:
On 12 Sep 2003, [EMAIL PROTECTED] wrote:
+++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16
@@ -389,12 +389,12 @@
if (accepted != null) {
try {
accepted.close();
-accepted = null;
}
On Fri, 12 Sep 2003, Bill Barker [EMAIL PROTECTED] wrote:
From: Stefan Bodewig [EMAIL PROTECTED]
wouldn't it be better to put the accepted = null into a finally
block
Wouldn't do anything. The 'accepted' variable is local to the
stack-frame, so it goes away if I throw clear of the method.
billbarker2003/09/12 20:59:57
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Catch all throwables when trying to close the socket.
Revision ChangesPath
1.17 +4 -4
billbarker2003/09/12 21:01:24
Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10
PoolTcpEndpoint.java
Log:
Port patch.
Revision ChangesPath
No revision
No revision
1.12.2.2 +4 -4
billbarker2003/09/11 20:51:36
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Make certain that we don't return a bad Socket.
Fix for Bug #21763
Reported By: Rex Young [EMAIL PROTECTED]
Reported By: wendy69 [EMAIL PROTECTED]
Revision Changes
billbarker2003/09/11 20:53:03
Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10
PoolTcpEndpoint.java
Log:
Make certain that we don't return a bad Socket.
Fix for Bug #21763
Reported By: Rex Young [EMAIL PROTECTED]
Reported By: wendy69
remm2003/07/26 08:04:35
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Close socket inside a finally block.
Revision ChangesPath
1.15 +12 -5
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
costin 2003/03/26 20:08:20
Modified:util/java tomcat-util.manifest
util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Fix bug that prevented clean shutdown.
Remove ClassPath from manifest, added spec version and the other entries
so it may be
costin 2003/03/04 10:20:36
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Reduce verbosity and add more info to the message
Revision ChangesPath
1.13 +7 -5
remm2003/01/01 05:55:22
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Don't check for null on the connection (it should never be null, and should be
caught by the throwable and logged if it happens).
- Fix a problem when using SSL: when an
costin 2002/12/18 21:31:47
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Use commons-loggign directly.
This way any logger can be used ( and the same logger config ).
Revision ChangesPath
1.9 +42 -25
remm2002/11/28 03:24:29
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Experiment with not using the pool.
Revision ChangesPath
1.7 +4 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
remm2002/11/28 07:16:32
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Small reorganization of the code so that the next accept is called sooner
when not using the connection cache.
Revision ChangesPath
1.8 +9 -12
remm2002/10/19 02:30:37
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
- Attempts to address bug 13736.
- Add code for recovery if the serverSocket dies. Needs testing (I tested with
an exception thrown according to a random value after the socket
remm02/05/16 11:57:39
Modified:coyote/src/java/org/apache/coyote ProtocolHandler.java
coyote/src/java/org/apache/coyote/tomcat4
CoyoteConnector.java LocalStrings.properties
http11/src/java/org/apache/coyote/http11
keith 02/05/15 11:53:46
Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
Log:
Wrap acceptSocket in a try to be more robust
Revision ChangesPath
1.3 +9 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
64 matches
Mail list logo
