On 12 Sep 2003, <[EMAIL PROTECTED]> wrote: > +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 -0000 1.16 > @@ -389,12 +389,12 @@ > if (accepted != null) { > try { > accepted.close(); > - accepted = null; > } catch(Exception ex) { > msg = sm.getString("endpoint.err.nonfatal", > accepted, ex); > log.warn(msg, ex); > } > + accepted = null; > } > > if( ! running ) return null;
wouldn't it be better to put the "accepted = null" into a finally block so you clean up even in the (unlikely but possible) case where close throws an Error (or Throwable) instead of an Exception? Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]