Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-03-17 Thread Remy Maucherat
Costin Manolache wrote: I don't know if the official build for 4.1.22/23 is done - but it would be nice if we could include this fix for jspc. I don't know any other way to compile an app using struts. Remy - were you able to precompile /admin for 4.1.23 ? Do you plan to include it precompiled,

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-03-17 Thread Remy Maucherat
Remy Maucherat wrote: Costin Manolache wrote: I don't know if the official build for 4.1.22/23 is done - but it would be nice if we could include this fix for jspc. I don't know any other way to compile an app using struts. Remy - were you able to precompile /admin for 4.1.23 ? Do you plan to

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-03-17 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: costin 2003/03/17 12:53:40 Modified:jasper2/src/share/org/apache/jasper Tag: tomcat_4_branch JspC.java Log: I don't know if this can make it into the release - but I can't get jspc to work as an ant task without this. The problem

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
[EMAIL PROTECTED] wrote: remm2003/01/22 03:40:00 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: - Fix package name generation. - Default to org.apache.jsp package name. Why do you need a default package name? Doesn't this make it harder to to use, since the

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Remy Maucherat
Hans Bergsten wrote: [EMAIL PROTECTED] wrote: remm2003/01/22 03:40:00 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: - Fix package name generation. - Default to org.apache.jsp package name. Why do you need a default package name? Doesn't this make it harder

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Remy Maucherat
Costin Manolache wrote: Remy Maucherat wrote: Then why not default to the context path ? Can you give examples ? It's very hard to determine the context path from JSPC IMO. I think the naming conventions for the generated servlets should be settled down, documented - and treated as APIs (

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Then why not default to the context path ? Can you give examples ? It's very hard to determine the context path from JSPC IMO. I agree. I think the naming conventions for the generated servlets should be settled down,

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Remy Maucherat
Hans Bergsten wrote: Remy Maucherat wrote: See my previous mail; you do _not_ need to have a package statement for the generated servlet class. Adding it just complicates life. Ooops, sorry, I'm trying to do plenty of things at once, and misunderstood your reply. I'll remove the org.apache.jsp

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Jeanfrancois Arcand
The only problem I see by removing the package org.apache.jsp is that when Tomcat run under the security manager, it is no longer possible to protect an application from package insertion/access (dangerous). It is still possible to protect the application by manually adding the new package

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Glenn Nielsen
Kin-Man Chung wrote: See below. Date: Wed, 22 Jan 2003 19:03:08 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java To: Tomcat Developers List [EMAIL PROTECTED] Costin Manolache wrote: Remy Maucherat

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Glenn Nielsen
One note, my comments below only apply to the package name for generated classes for those JSP pages compiled at runtime. What package name is used for precompiled JSP pages using JspC.java is not an issue. Glenn Glenn Nielsen wrote: Kin-Man Chung wrote: See below. Date: Wed, 22 Jan

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
Remy Maucherat wrote: Jeanfrancois Arcand wrote: The only problem I see by removing the package org.apache.jsp is that when Tomcat run under the security manager, it is no longer possible to protect an application from package insertion/access (dangerous). It is still possible to protect

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Jeanfrancois Arcand
Hans Bergsten wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: The only problem I see by removing the package org.apache.jsp is that when Tomcat run under the security manager, it is no longer possible to protect an application from package insertion/access (dangerous). It is

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Craig R. McClanahan
On Wed, 22 Jan 2003, Hans Bergsten wrote: See my previous mail; you do _not_ need to have a package statement for the generated servlet class. Adding it just complicates life. There is a situation when *not* having the package statement can cause big problems for users. The JSP spec

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
Craig R. McClanahan wrote: On Wed, 22 Jan 2003, Hans Bergsten wrote: See my previous mail; you do _not_ need to have a package statement for the generated servlet class. Adding it just complicates life. There is a situation when *not* having the package statement can cause big problems

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
Jeanfrancois Arcand wrote: [...] We can support runtime package name addition (when the servlet is generated, ask the security manager to protect the package). So it can be optional, i.e. being able to tell jasper to generate servlet using org.apache.jsp (something configurable via JMX ;-) ),

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Jeanfrancois Arcand
Hans Bergsten wrote: Jeanfrancois Arcand wrote: [...] We can support runtime package name addition (when the servlet is generated, ask the security manager to protect the package). So it can be optional, i.e. being able to tell jasper to generate servlet using org.apache.jsp (something

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Hans Bergsten
Jeanfrancois Arcand wrote: Hans Bergsten wrote: Jeanfrancois Arcand wrote: [...] We can support runtime package name addition (when the servlet is generated, ask the security manager to protect the package). So it can be optional, i.e. being able to tell jasper to generate servlet using

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Craig R. McClanahan
On Wed, 22 Jan 2003, Hans Bergsten wrote: Again, I'm only talking about JSPC here; I'm not arguing for removing the package name that JspServlet adds. From a usability perspective, having JSPC work differently (in this regard) from runtime compilation doesn't seem like a good idea. A page

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-22 Thread Jeanfrancois Arcand
Hans Bergsten wrote: Jeanfrancois Arcand wrote: Hans Bergsten wrote: Jeanfrancois Arcand wrote: [...] We can support runtime package name addition (when the servlet is generated, ask the security manager to protect the package). So it can be optional, i.e. being able to tell jasper

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-21 Thread Hans Bergsten
[EMAIL PROTECTED] wrote: costin 2003/01/21 11:44:42 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Support for packages in precompiled servlets - otherwise all go to the same package and we get conflicts. Thanks for finally fixing this, but please use the patch I

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-21 Thread Hans Bergsten
Costin Manolache wrote: Sorry, I didn't see the patch - I was precompiling the admin and hit the problem. BTW - why don't you fix it yourself - you are committer AFAIK :-) ? There's a simple reason: it's been so long since I was actively involved in the development that I (a) want to lurk a

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2003-01-21 Thread Hans Bergsten
[EMAIL PROTECTED] wrote: costin 2003/01/21 15:24:51 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Use the patch submited by Hans ( at least the part related to package ). I modified it so that if a package is specified, it is used as prefix. The second patch -

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasperJspC.java

2002-06-14 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: costin 2002/06/14 14:23:15 Modified:jasper2/src/share/org/apache/jasper JspC.java Log: Add the --compile CLI and 'compile=' ant attribute. If set we'll also compile. I have some doubts about this - it would be ugly to change jspc to