Observations on catalina logging

2001-05-27 Thread Ceki Gülcü
Hello, In case catalina decides to use log4j as its logging API, here is a series of observations. 1) Thanks to the separation of loaders, it is possible to keep catalina logging separate from user (servlet) logging even of both catalina and user servlets use log4j. 2) Logging code in

synchronize keyword may produce deadlocks.

2001-05-27 Thread yhs1634
Hi, The synchronize call may deadlock due to thread starvation. This is present in all versions of java on all platforms i could test (jdk 1.1 thru 1.4b on win/sol/lin) Example code for interlock.java is as follows : import java.io.*; import java.lang.*; public class interlock{ public static

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Jon Stevens
on 5/26/01 10:18 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: +// Called from MessageBytes.setTime +/** + */ +public static String format1123( Date d ) { +return rfc1123Format.format( d ); +} + + +// Called from ServerCookie +/** + */ +

Re: Taglibs Article

2001-05-27 Thread Jon Stevens
on 5/25/01 11:56 AM, Christopher Cain [EMAIL PROTECTED] wrote: Jakarta Taglibs was one of the featured articles in the JDC Newsletter this morning. Here is the address for those of you not subscribed to it: http://developer.java.sun.com/developer/technicalArticles/javaserverpages/Jaka

Re: jsp compacter to be released

2001-05-27 Thread Jon Stevens
A better way to write this would be as a Servlet API 2.3 filter (assuming they can work on an output stream...i forget...). -jon on 5/25/01 9:25 PM, Carlos Gaston Alvarez [EMAIL PROTECTED] wrote: Hi there, I have the jsp compacter running and now I am doing the documentation. It is a

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets HTMLManagerServlet.java ManagerServlet.java

2001-05-27 Thread bip
bip 01/05/27 14:09:11 Modified:catalina/src/share/org/apache/catalina/servlets ManagerServlet.java Added: catalina/src/share/org/apache/catalina/servlets HTMLManagerServlet.java Log: Changed ManagerServlet to allow for

cvs commit: jakarta-tomcat-4.0/webapps/manager/WEB-INF web.xml

2001-05-27 Thread bip
bip 01/05/27 14:13:40 Modified:webapps/manager/WEB-INF web.xml Log: Added a comment about HTMLManagerServlet Revision ChangesPath 1.2 +6 -1 jakarta-tomcat-4.0/webapps/manager/WEB-INF/web.xml Index: web.xml

form-based authentication tomcat-apache

2001-05-27 Thread Michael Jennings
Hi! I've made a modification to the ApacheConfig module to enable the mod_jk.conf-auto to include directives to enable form-based authentication. Can someone with commit privilege commit this change? Here's the cvs diff: Index:

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/bufDateTool.java

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Jon Stevens wrote: on 5/26/01 10:18 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: +{ +return oldCookieFormat.format( d ); } I thought we weren't using tab's in the files anymore... We are using tabs AFAIK ( or at least I am using tabs and I don't

cvs commit: jakarta-tomcat-jasper/jasper34/liaison - New directory

2001-05-27 Thread costin
costin 01/05/27 16:06:00 jakarta-tomcat-jasper/jasper34/liaison - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/generator - New directory

2001-05-27 Thread costin
costin 01/05/27 16:06:04 jakarta-tomcat-jasper/jasper34/generator - New directory

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/config ApacheConfig.java

2001-05-27 Thread costin
costin 01/05/27 16:11:08 Modified:src/share/org/apache/tomcat/modules/config ApacheConfig.java Log: Fix from Michael Jennings for form-based login in apache The new connector will probably provide a better solution in ajp14, but this is a good fix we can do now. Submitted

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/mappers DecodeInterceptor.java

2001-05-27 Thread costin
costin 01/05/27 16:14:24 Modified:src/share/org/apache/tomcat/modules/mappers DecodeInterceptor.java Log: Added 2 very common charset detection schemes. The most important is the per session charset - all browsers will use the same encoding for the

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/http Parameters.java

2001-05-27 Thread costin
costin 01/05/27 16:16:20 Modified:src/share/org/apache/tomcat/util/buf ByteChunk.java src/share/org/apache/tomcat/util/http Parameters.java Log: Removed the debug from Parameters. Added the indexOf() method in ByteChunk - it'll save the other 5-6 strings we

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org - New directory

2001-05-27 Thread costin
costin 01/05/27 16:16:35 jakarta-tomcat-jasper/jasper34/generator/org - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34 - New directory

2001-05-27 Thread costin
costin 01/05/27 16:16:41 jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34 - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/core - New directory

2001-05-27 Thread costin
costin 01/05/27 16:16:51 jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/core - New directory

cvs commit: jakarta-tomcat-jasper/lib - New directory

2001-05-27 Thread costin
costin 01/05/27 16:23:30 jakarta-tomcat-jasper/lib - New directory

cvs commit: jakarta-tomcat-jasper/lib servlet.jar tomcat_core.jar tomcat_util.jar

2001-05-27 Thread costin
costin 01/05/27 16:27:35 Added: lib servlet.jar tomcat_core.jar tomcat_util.jar Log: For easy compilation - added the binaries jasper34 depends on. The tomcat_util.jar is also used ( in part ) by the connector. In time we'll migrate it to commons ( or keep it in

cvs commit: jakarta-tomcat-jasper/jasper34 build.xml

2001-05-27 Thread costin
costin 01/05/27 16:29:36 Added: jasper34 build.xml Log: Initial build file. It'll generate 3 jars: jasper_runtime.jar will be visible in the webapp classloader and included in WEB-INF/lib for jspc processed apps. jasper.jar is the code generator ( it'll be an

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org - New directory

2001-05-27 Thread costin
costin 01/05/27 16:29:51 jakarta-tomcat-jasper/jasper34/liaison/org - New directory

Re: form-based authentication tomcat-apache

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Michael Jennings wrote: Hi! I've made a modification to the ApacheConfig module to enable the mod_jk.conf-auto to include directives to enable form-based authentication. Can someone with commit privilege commit this change? Done, thanks. Costin Here's the cvs

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/bufDateTool.java

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Jon Stevens wrote: on 5/27/01 4:01 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: We are using tabs AFAIK ( or at least I am using tabs and I don't remember any vote or official rule that says this is not allowed ). Costin

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Jon Stevens
on 5/27/01 5:04 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: http://jakarta.apache.org/site/source.html Costin Costin, you are being stupid (again). However, some projects may decide to override these defaults and use their own defined conventions. -jon

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/bufDateTool.java

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Jon Stevens wrote: on 5/27/01 5:04 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: http://jakarta.apache.org/site/source.html Costin Costin, you are being stupid (again). However, some projects may decide to override these defaults and use their own

Re: Vacation

2001-05-27 Thread kevin seguin
Regarding the connector - sorry I didn't had more time to spend on it, but I'll be able to help more after I'll be back. I plan to do a re-implementation of the java side of Ajp13/14, and also to do some optimizations on the JNI side, and I'll try to help with the config stuff ( if Henri

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Jon Stevens
on 5/27/01 5:25 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Jon, try to write more code and less mail. Once again, you completely miss the point Costin. Your code isn't any good if people can't read the diff's that go into CVS because they don't format correctly in email clients because of

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/bufDateTool.java

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Jon Stevens wrote: on 5/27/01 5:25 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Jon, try to write more code and less mail. Once again, you completely miss the point Costin. I guess you completely miss the point - calling people stupid and behaving the way you

Re: Vacation

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, kevin seguin wrote: Regarding the connector - sorry I didn't had more time to spend on it, but I'll be able to help more after I'll be back. I plan to do a re-implementation of the java side of Ajp13/14, and also to do some optimizations on the JNI side, and I'll

Re: Issues with Tomcat 3.2.1, JSPs and I18N ( Implicit charactertran slation ??? )

2001-05-27 Thread cmanolache
Hi Chris, Can you reproduce this in normal JSP ( without oracle ) ? Can you send me a small webapp where I can reproduce it ? Does it happens in 3.3 too ? I am trying to solve (most) I18N bugs and problems for 3.3, it's very tricky but can be done :-) Costin On Fri, 25 May 2001, Chris

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Jon Stevens
on 5/27/01 5:54 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: It's a matter of principle here - the fact that some mail clients or editors chose to ignore standards and common practices doesn't mean the standard itself is bad and shouldn't be used. Costin Making developers jump through

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/bufDateTool.java

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, Jon Stevens wrote: on 5/27/01 5:54 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: It's a matter of principle here - the fact that some mail clients or editors chose to ignore standards and common practices doesn't mean the standard itself is bad and shouldn't be

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Jon Stevens
on 5/27/01 6:45 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: It has all to do with standards. Tabs have been used for indentation for at least the last 15 years ( that's when I started playing with computers- and the tab was there ). Great! I have you beat. I started creating software when

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/qlog FastDateFormat.java

2001-05-27 Thread costin
costin 01/05/27 19:09:55 Modified:src/share/org/apache/tomcat/util/qlog FastDateFormat.java Log: Roll back the previous change - problems if you compile with 1.4 and run with 1.3 Revision ChangesPath 1.3 +5 -1

cvs commit: jakarta-tomcat-jasper/lib tomcat_core.jar

2001-05-27 Thread costin
costin 01/05/27 19:16:14 Removed: lib tomcat_core.jar Log: Removed tomcat_core.jar, that's stupid. We can just point to a valid tomcat installation ( and detect if it's there ). ( I'll keep servlet.jar and tomcat_utils.jar - those are needed for runtime and

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache - New directory

2001-05-27 Thread costin
costin 01/05/27 19:16:43 jakarta-tomcat-jasper/jasper34/liaison/org/apache - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34 - New directory

2001-05-27 Thread costin
costin 01/05/27 19:16:46 jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34 - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/servlet - New directory

2001-05-27 Thread costin
costin 01/05/27 19:16:54 jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/servlet - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/tomcat33 - New directory

2001-05-27 Thread costin
costin 01/05/27 19:16:58 jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/tomcat33 - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/cli - New directory

2001-05-27 Thread costin
costin 01/05/27 19:17:01 jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/cli - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/servlet EmbededServletOptions.java JasperLoader.java JasperLoader12.java JspEngineContext.java JspLoader.java JspServlet.java ServletEngine.java TomcatServletEngine.java

2001-05-27 Thread costin
costin 01/05/27 19:17:58 Added: jasper34/liaison/org/apache/jasper34/servlet EmbededServletOptions.java JasperLoader.java JasperLoader12.java JspEngineContext.java JspLoader.java JspServlet.java

cvs commit: jakarta-tomcat-jasper/jasper34/liaison/org/apache/jasper34/tomcat33 JasperEngineContext.java JasperOptionsImpl.java JspInterceptor.java

2001-05-27 Thread costin
costin 01/05/27 19:18:59 Added: jasper34/liaison/org/apache/jasper34/tomcat33 JasperEngineContext.java JasperOptionsImpl.java JspInterceptor.java Log: Added tomcat33 specific interface ( will be compiled only if 33 is detected).

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/generator JspParseEventListener.java

2001-05-27 Thread costin
costin 01/05/27 19:19:31 Modified:jasper34/generator/org/apache/jasper34/core Constants.java jasper34/generator/org/apache/jasper34/generator JspParseEventListener.java Log: Fix to generate code for the right runtime. Revision Changes

cvs commit: jakarta-tomcat-jasper/jasper34 build.xml

2001-05-27 Thread costin
costin 01/05/27 19:20:42 Modified:jasper34 build.xml Log: Fix to take tomcat from the right directory. Added code to install ( replace ) the current jasper from tc. Revision ChangesPath 1.2 +28 -7 jakarta-tomcat-jasper/jasper34/build.xml Index:

Re: Vacation

2001-05-27 Thread kevin seguin
The buffers do belong to jakarta-tomcat-connectors/util, and in a perfect world we wouldn't have them duplicated - 3.3 should only use what's in connectors. I wouldn't mind making tomcat-connectors/util the master source for the buffer stuff, but it needs some changes in the build

Jasper34

2001-05-27 Thread cmanolache
Hi, I finished the initial commit, and ( a bit surprising ) it worked from the first attempt... Not bad. To try it out: - get jakarta-tomcat - build it - get jakarta-tomcat-jasper - build it with ant install That will copy the jasper jars and fix the tomcat config ( replacing the module class

Re: Vacation

2001-05-27 Thread cmanolache
On Sun, 27 May 2001, kevin seguin wrote: The buffers do belong to jakarta-tomcat-connectors/util, and in a perfect world we wouldn't have them duplicated - 3.3 should only use what's in connectors. I wouldn't mind making tomcat-connectors/util the master source for the buffer stuff,

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/javacompiler - New directory

2001-05-27 Thread costin
costin 01/05/27 19:58:22 jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/javacompiler - New directory

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/generator Compiler.java ClassName.java JasperMangler.java JavaCompiler.java JikesJavaCompiler.java JspCompiler.java SunJavaCompiler.java

2001-05-27 Thread costin
costin 01/05/27 20:00:18 Modified:jasper34/generator/org/apache/jasper34/generator Compiler.java Removed: jasper34/generator/org/apache/jasper34/generator ClassName.java JasperMangler.java JavaCompiler.java

cvs commit: jakarta-tomcat-jasper/jasper34/generator/org/apache/jasper34/javacompiler JavaCompiler.java JikesJavaCompiler.java SunJavaCompiler.java

2001-05-27 Thread costin
costin 01/05/27 20:01:20 Added: jasper34/generator/org/apache/jasper34/javacompiler JavaCompiler.java JikesJavaCompiler.java SunJavaCompiler.java Log: The javac part. Revision ChangesPath 1.1

Re: cvs commit:jakarta-tomcat/src/share/org/apache/tomcat/util/buf DateTool.java

2001-05-27 Thread Remy Maucherat
[EMAIL PROTECTED] at [EMAIL PROTECTED] wrote: It has all to do with standards. Tabs have been used for indentation for at least the last 15 years ( that's when I started playing with computers- and the tab was there ). But the point is that we're using SPACES... Since _EVER_...

cvs commit: jakarta-tomcat-jasper/jasper34/runtime/org/apache/jasper34/runtime JspRuntimeLibrary.java

2001-05-27 Thread costin
costin 01/05/27 22:07:37 Modified:jasper34/runtime/org/apache/jasper34/runtime JspRuntimeLibrary.java Log: Quick optimization for jsp:get/setProperty. Method lookup result is cached, as it is the most expensive part of method invocation. This can be