DO NOT REPLY [Bug 31328] - DeltaRequest unable to handle two concurrent requests per session
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31328. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31328 DeltaRequest unable to handle two concurrent requests per session --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 06:50 --- For me this patch looks good. We are going to use it. Recommended for TC 5.0.30. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31304] - NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31304. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31304 NoClassDefFoundError: org/apache/commons/collections/CursorableLinkedList [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 10:26 --- After numerous fresh installs on my laptop with no success I attempted an install on another machine. It worked. But for the life of me still can't see why it doesn't on my laptop ... Thanks for your help Yoav, sorry for troubling you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
tomcat component releases
Hi, bit of background... I maintain the maven-tomcat-plugin. This plugin uses: catalina-ant jasper-compiler jasper-runtime In the interest of keeping the plugin up to date, I should probably cut a new version of the plugin whenever any of these components are modified. Do these components have their own release cycle? or are they just released whenever there is a new tomcat build? I'm guessing there are some tomcat releases where none of these components are modified. cheers Nathan -- Nathan Coast Managing Director codeczar ltd mobile: (852) 9049 5581 email: mailto:[EMAIL PROTECTED] web:http://www.codeczar.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: tomcat component releases
The components are released during a tomcat upgrade. yes, it can be possible for one of the components to not change during a release cycle. -Tim Nathan Coast wrote: Hi, bit of background... I maintain the maven-tomcat-plugin. This plugin uses: catalina-ant jasper-compiler jasper-runtime In the interest of keeping the plugin up to date, I should probably cut a new version of the plugin whenever any of these components are modified. Do these components have their own release cycle? or are they just released whenever there is a new tomcat build? I'm guessing there are some tomcat releases where none of these components are modified. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31892] New: - Given Context-Path in Context-Descriptor ignored
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31892.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31892
Given Context-Path in Context-Descriptor ignored
Summary: Given Context-Path in Context-Descriptor ignored
Product: Tomcat 5
Version: 5.5.3
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
If a context XML descriptor is placed like this:
$CATALINA_HOME/conf/[enginename]/[hostname]/abcxyz.xml
the application is deployed with context-Path /abcxyz
The filename of the context XML descriptor defines the URL-context implicit,
under which the application is accessible. An optional path=/xxx Attribute
in the context XML descriptor is ignored.
This is not the case, when the context XML Fragment is directly placed in the
host-Section of server.xml.
DETAILS:
The method
HostConfig.deployDescriptor(String contextPath, File contextXml, String file)
is called when deploying an application with a context XML descriptor. Within
this method, the XML is parsed and a StandartContext Object is generated.
The parameter contextPath is never overridden by an optional given
path-Attribute in the context XML descriptor, which is accessible after XML
parsing under context.getName().
The following code-fragment in the mentioned method
HostConfig.deployDescriptor() shows a possible solution:
starting from line 572, HostConfig.java, Revision 1.48
--
[...]
context.setConfigFile(contextXml.getAbsolutePath());
if(context.getName()!=null)
{
context.setPath( context.getName() ); // use Context in descriptor, when given
}
else
{
context.setPath(contextPath);
}
[...]
---
Oliver Henning
aloba ag, Switzerland
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31892] - Given Context-Path in Context-Descriptor ignored
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31892.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31892
Given Context-Path in Context-Descriptor ignored
--- Additional Comments From [EMAIL PROTECTED] 2004-10-26 12:13 ---
More debugging in Tomcat showed up, that the follwing path would be 'better'
instead of the one i descriped first. Sorry for that:
starting from line 572, HostConfig.java, Revision 1.48
--
[...]// existing code
context.setConfigFile(contextXml.getAbsolutePath()); // existing code
if(context.getName()!=null) //NEW
{ //NEW
contextPath=context.getName(); //NEW use Context in descriptor, when given
} //NEW
context.setPath(contextPath);// existing code
[...]// existing code
---
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31892] - Given Context-Path in Context-Descriptor ignored
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31892. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31892 Given Context-Path in Context-Descriptor ignored [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 12:24 --- This is done on purpose, so this will not be addressed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: tomcat component releases
thanks Tim, the maven repo for tomcat components seems fairly out of date or inconsistent, some components have been 'released' to the maven repo and others haven't. most components seem to be at 5.0.18, with no mention of 5.5.X http://www.ibiblio.org/maven/tomcat/jars/ I can however see why the maven repo isn't kept up to date if each release of tomcat leads to 10 or so different components having to be released. My life would be made a lot easier if components were released independently :) Tim Funk wrote: The components are released during a tomcat upgrade. yes, it can be possible for one of the components to not change during a release cycle. -Tim Nathan Coast wrote: Hi, bit of background... I maintain the maven-tomcat-plugin. This plugin uses: catalina-ant jasper-compiler jasper-runtime In the interest of keeping the plugin up to date, I should probably cut a new version of the plugin whenever any of these components are modified. Do these components have their own release cycle? or are they just released whenever there is a new tomcat build? I'm guessing there are some tomcat releases where none of these components are modified. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Nathan Coast Managing Director codeczar ltd mobile: (852) 9049 5581 email: mailto:[EMAIL PROTECTED] web:http://www.codeczar.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs/config context.xml
remm2004/10/26 05:33:22 Modified:webapps/docs/config context.xml Log: - Clarify wording. Revision ChangesPath 1.18 +3 -2 jakarta-tomcat-catalina/webapps/docs/config/context.xml Index: context.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/context.xml,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- context.xml 5 Oct 2004 17:12:52 - 1.17 +++ context.xml 26 Oct 2004 12:33:22 - 1.18 @@ -168,8 +168,9 @@ If you specify a context path of an empty string (), you are defining the emdefault/em web application for this Host, which will process all requests not assigned to other Contexts. The value of -this field must not be set most of the time, as it will be infered from -the filenames used for either the .xml context file of the docBase./p +this field must not be set except when statically defining a Context in +server.xml, as it will be infered from the filenames used for either the +.xml context file or the docBase./p /attribute attribute name=reloadable required=false - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: 5.5.4 ?
Hi, Looks like a RESOLVED-WONTFIX ;) Yoav Shapira http://www.yoavshapira.com -Original Message- From: Ben Souther [mailto:[EMAIL PROTECTED] Sent: Monday, October 25, 2004 5:06 PM To: Tomcat Developers List Subject: Re: 5.5.4 ? Yes, I had tested it a little earlier, and it doesn't work. The path would apparently have to be encoded in the same way as the URL. OK, let me know if I can help. Quite frankly, I'm not sure we're going to do this, since the encoding on the client side is quite unpredictable. Other than helping out and trying to learn the code, I have no interest in seeing this one resolved. IMHO: it's a little absurd to have to support spaces in a context path since a browser will never send a URL with a space in it. -Ben - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31090] - The session disappears when the context name contains the space character
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31090. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31090 The session disappears when the context name contains the space character [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 12:49 --- After discussion on the tomcat-dev list, I'm closing this as WONTFIX because it's a contrived use-case: the browser will never send a request with a space character in it (it'd be encoded as %20, which is handled fine by Tomcat). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: 5.5.4 ?
One way to make things more consistent without affecting performance would be for the deployer not to deploy apps with spaces in the context path. This would be a lot easier to debug than the current behavior and may prevent this bug from being reported again. On Tue, 2004-10-26 at 08:45, Shapira, Yoav wrote: Hi, Looks like a RESOLVED-WONTFIX ;) Yoav Shapira http://www.yoavshapira.com -Original Message- From: Ben Souther [mailto:[EMAIL PROTECTED] Sent: Monday, October 25, 2004 5:06 PM To: Tomcat Developers List Subject: Re: 5.5.4 ? Yes, I had tested it a little earlier, and it doesn't work. The path would apparently have to be encoded in the same way as the URL. OK, let me know if I can help. Quite frankly, I'm not sure we're going to do this, since the encoding on the client side is quite unpredictable. Other than helping out and trying to learn the code, I have no interest in seeing this one resolved. IMHO: it's a little absurd to have to support spaces in a context path since a browser will never send a URL with a space in it. -Ben - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31090] - The session disappears when the context name contains the space character
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31090. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31090 The session disappears when the context name contains the space character --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 13:05 --- Yes, but the problem is that TC will set a cookie based on the unencoded path, and the browser doesn't make the association between that and the URL (somehow). In theory, we would need to URL encode the context path using straight conversion. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster ClusterDeployer.java MessageListener.java
fhanik 2004/10/26 07:29:02
Modified:modules/cluster/src/share/org/apache/catalina/cluster
ClusterDeployer.java MessageListener.java
Log:
setCluster/getCluster should be done on a lower level
Revision ChangesPath
1.3 +1 -13
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterDeployer.java
Index: ClusterDeployer.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterDeployer.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClusterDeployer.java 28 Jul 2004 18:02:15 - 1.2
+++ ClusterDeployer.java 26 Oct 2004 14:29:02 - 1.3
@@ -29,18 +29,6 @@
public interface ClusterDeployer extends MessageListener {
/**
- * Returns the cluster the cluster deployer is associated with
- * @return CatalinaCluster
- */
-public CatalinaCluster getCluster();
-
-/**
- * Associates the cluster deployer with a cluster
- * @param cluster CatalinaCluster
- */
-public void setCluster(CatalinaCluster cluster);
-
-/**
* Descriptive information about this component implementation.
*/
public String info = ClusterDeployer/1.0;
1.2 +13 -0
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/MessageListener.java
Index: MessageListener.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/MessageListener.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- MessageListener.java 29 May 2004 02:36:12 - 1.1
+++ MessageListener.java 26 Oct 2004 14:29:02 - 1.2
@@ -24,5 +24,18 @@
public boolean equals(Object listener);
public int hashCode();
+
+/**
+ * Returns the cluster the cluster deployer is associated with
+ * @return CatalinaCluster
+ */
+public CatalinaCluster getCluster();
+
+/**
+ * Associates the cluster deployer with a cluster
+ * @param cluster CatalinaCluster
+ */
+public void setCluster(CatalinaCluster cluster);
+
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaRequest.java
fhanik 2004/10/26 07:52:17
Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaRequest.java
Log:
Sort of fix for bug 31328 which is not valid
Revision ChangesPath
1.10 +10 -4
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java
Index: DeltaRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaRequest.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- DeltaRequest.java 29 Sep 2004 16:43:44 - 1.9
+++ DeltaRequest.java 26 Oct 2004 14:52:17 - 1.10
@@ -104,7 +104,13 @@
}
//if we have already done something to this attribute, make sure
//we don't send multiple actions across the wire
-if ( !recordAllActions) actions.remove(info);
+if ( !recordAllActions) {
+try {
+actions.remove(info);
+} catch (java.util.NoSuchElementException x) {
+//do nothing, we wanted to remove it anyway
+}
+}
//add the action
actions.addLast(info);
}
@@ -177,7 +183,7 @@
actionPool.clear();
}
-public void readExternal(java.io.ObjectInput in) throws java.io.IOException,
+public synchronized void readExternal(java.io.ObjectInput in) throws
java.io.IOException,
java.lang.ClassNotFoundException {
//sessionId - String
//recordAll - boolean
@@ -206,7 +212,7 @@
-public void writeExternal(java.io.ObjectOutput out ) throws java.io.IOException
{
+public synchronized void writeExternal(java.io.ObjectOutput out ) throws
java.io.IOException {
//sessionId - String
//recordAll - boolean
//size - int
@@ -220,7 +226,7 @@
}
}
-public static class AttributeInfo implements java.io.Externalizable {
+private static class AttributeInfo implements java.io.Externalizable {
private String name = null;
private Object value = null;
private int action;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31328] - DeltaRequest unable to handle two concurrent requests per session
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31328. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31328 DeltaRequest unable to handle two concurrent requests per session [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 14:57 --- As mentioned a long long long time ago :) If you have two threads per session, consider the following scenario: Thread A goes to server S1 and Thread B goes to server S2, your session replication will now be faulty since there is no distributed locking. Adding in synchronization here, would mean that we are letting the user think that concurrent access is ok, which it isn't. What I do agree with is that the readExternal/writeExternal methods could be synchronized, to avoid corrupted methods. You must still realize, that you have two concurrent requests, there is nothing that guarantees the order of them. Hence synchronizing the entire class does not resolve anything really. Your fundamental problem is still that you have more than one thread modifying the session. I am marking the bug invalid, cause we are not supporting distributed locking hence could never put in a complete fix. A synchronized workaround Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31677] - Cannot undeploy and deploy war file with on the same context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31677. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31677 Cannot undeploy and deploy war file with on the same context [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 14:58 --- Sorry I was talking about the temp directory (java.io.tmpdir I think). Could the same be done for the temp directory which is separate from the work directory but is required for the antiJARLocking and antiResourceLocking flags. It would be good if they both worked the same way. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31677] - Cannot undeploy and deploy war file with on the same context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31677. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31677 Cannot undeploy and deploy war file with on the same context [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:02 --- No. Java.io.tmpdir is up to server administration control, not Tomcat's. It's assumed to be configured properly and cannot typically be created due to permissions on the server. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31677] - Cannot undeploy and deploy war file with on the same context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31677. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31677 Cannot undeploy and deploy war file with on the same context --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:03 --- Further, if you want to try and come up with a patch that does it, please do so and post it to the tomcat-dev mailing list please so that we can discuss the issue, rather than reopening this Bugzilla issue a third time. It has to work under a SecurityManager as well. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31677] - Cannot undeploy and deploy war file with on the same context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31677. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31677 Cannot undeploy and deploy war file with on the same context --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:06 --- I've added a warning message for the tempdir thing, and that's all that will be done. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31720] - JNDI NamingContext is not thread safe
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31720. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31720 JNDI NamingContext is not thread safe [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Component|Catalina:Modules|Servlet Product|Tomcat 5|Watchdog Resolution||WONTFIX Version|5.0.0 |4 (Servlet 2.3 / JSP 1.2) --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:07 --- I see Phil's already reproduced this issue in the JIRA repository for the naming project, so I'm closing this one, as it won't be addressed in Tomcat. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Request.java
remm2004/10/26 08:42:06
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
catalina/src/share/org/apache/catalina Context.java
catalina/src/share/org/apache/catalina/connector
Request.java
Log:
- Add the encoded path to the Context interface.
- Use that to set a URL encoded path for the session cookie.
- Fixes bug 31090.
Revision ChangesPath
1.155 +34 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.154
retrieving revision 1.155
diff -u -r1.154 -r1.155
--- StandardContext.java 25 Oct 2004 19:09:06 - 1.154
+++ StandardContext.java 26 Oct 2004 15:42:02 - 1.155
@@ -86,6 +86,7 @@
import org.apache.catalina.util.CharsetMapper;
import org.apache.catalina.util.ExtensionValidator;
import org.apache.catalina.util.RequestUtil;
+import org.apache.catalina.util.URLEncoder;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.commons.modeler.Registry;
@@ -145,6 +146,25 @@
private static final JdkCompat jdkCompat = JdkCompat.getJdkCompat();
+/**
+ * Array containing the safe characters set.
+ */
+protected static URLEncoder urlEncoder;
+
+
+/**
+ * GMT timezone - all HTTP dates are on GMT
+ */
+static {
+urlEncoder = new URLEncoder();
+urlEncoder.addSafeCharacter('-');
+urlEncoder.addSafeCharacter('_');
+urlEncoder.addSafeCharacter('.');
+urlEncoder.addSafeCharacter('*');
+urlEncoder.addSafeCharacter('/');
+}
+
+
// - Instance Variables
@@ -265,6 +285,12 @@
*/
private boolean crossContext = false;
+
+/**
+ * Encoded path.
+ */
+private String encodedPath = null;
+
/**
* The follow standard delegation model flag that will be used to
@@ -628,8 +654,15 @@
// - Context Properties
+
+public String getEncodedPath() {
+return encodedPath;
+}
+
+
public void setName( String name ) {
super.setName( name );
+encodedPath = urlEncoder.encode(name);
}
1.18 +7 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Context.java
Index: Context.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/Context.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- Context.java 28 Jul 2004 18:02:15 - 1.17
+++ Context.java 26 Oct 2004 15:42:05 - 1.18
@@ -253,6 +253,12 @@
/**
+ * Return the URL encoded context path, using UTF-8.
+ */
+public String getEncodedPath();
+
+
+/**
* Return the login configuration descriptor for this web application.
*/
public LoginConfig getLoginConfig();
1.16 +2 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java
Index: Request.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- Request.java 12 Oct 2004 22:53:16 - 1.15
+++ Request.java 26 Oct 2004 15:42:05 - 1.16
@@ -2220,7 +2220,7 @@
cookie.setMaxAge(-1);
String contextPath = null;
if (!connector.getEmptySessionPath() (getContext() != null)) {
-contextPath = getContext().getPath();
+contextPath = getContext().getEncodedPath();
}
if ((contextPath != null) (contextPath.length() 0)) {
cookie.setPath(contextPath);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31090] - The session disappears when the context name contains the space character
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31090. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31090 The session disappears when the context name contains the space character [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:45 --- . - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31090] - The session disappears when the context name contains the space character
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31090. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31090 The session disappears when the context name contains the space character [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:47 --- It is fixed now, but the fix assumes UTF-8 encoding for URLs. I guess even if it doesn't work always, it's better than it it never works. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31090] - The session disappears when the context name contains the space character
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31090. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31090 The session disappears when the context name contains the space character [EMAIL PROTECTED] changed: What|Removed |Added Version|5.0.28 |5.5.3 --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 15:49 --- Forgot to mention: for really tricky situations (i18n ...), you can also choose to set the cookie path to / by using emptySessionPath=true on the Connector. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
remm2004/10/26 08:53:04 Modified:webapps/docs changelog.xml Log: - Changelog update. Revision ChangesPath 1.154 +4 -1 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.153 retrieving revision 1.154 diff -u -r1.153 -r1.154 --- changelog.xml 25 Oct 2004 19:12:53 - 1.153 +++ changelog.xml 26 Oct 2004 15:53:04 - 1.154 @@ -104,7 +104,7 @@ Remove bad shutdown logic for ms pool strategy. (remm) /fix fix -bug31090/bug: Sync with Cookie, by adding ' ' as a special char. If a special char is present, +Sync with Cookie, by adding ' ' as a special char. If a special char is present, the string will be quoted. If the client doesn't support it, the String will no be quoted anyway and no IAE will be thrown. (remm) /fix @@ -116,6 +116,9 @@ update String caching is enabled by default for ByteChunk. (remm) /update + fix +bug31090/bug: Use a URL encoded path when setting session cookies. (remm) + /fix /changelog /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31677] - Cannot undeploy and deploy war file with on the same context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31677. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31677 Cannot undeploy and deploy war file with on the same context --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 16:09 --- I wasn't too sure about creating of the temp dir, I thought it might not be possible or a good idea. I think a warning message is fine. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31328] - DeltaRequest unable to handle two concurrent requests per session
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31328. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31328 DeltaRequest unable to handle two concurrent requests per session --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 18:54 --- Filip, I agree that distributed locking is out of reach. But please consider the following: carefully designed clusters will use sticky session routing via mod_jk. So as long as the primary node ist available there will be no parallel usage of sessions via different nodes. But even then and even without frames etc. we see every now and then unintentional parallel usage by people e.g. using Return and afterwards the mouse button to send a form to the server. This will result in double sending of the form and this should not technically corrupt the session objects. Of course there is no guarantee, that all session data still makes sense for the application. So at least we should not corrupt the LinkedLists in the DeltaRequest. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31903] New: - WebappClassLoader fails to load class form local repository
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31903.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31903
WebappClassLoader fails to load class form local repository
Summary: WebappClassLoader fails to load class form local
repository
Product: Tomcat 5
Version: 5.0.28
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
WebappClassLoader may fail to load class from local repository when multiple
threads are trying to load same class concurrently.
Need to change method findClassInternal (line 1577 ),
if ((entry == null) || (entry.binaryContent == null))
throw new ClassNotFoundException(name);
to
if ((entry == null) || (entry.binaryContent == null
entry.loadedClass==null))
throw new ClassNotFoundException(name);
since after one thread calls defineClass() on the entry, the entry's
binaryContent is set to null, but in this case, the class is already loaded, so
the code should not throw ClassNotFoundException.
Also in method findClassInternal, following code still use double checked
locking, which is proven broken -
if (entry.loadedClass == null) {
synchronized (this) {
if (entry.loadedClass == null) {
clazz = defineClass(name, entry.binaryContent, 0,
entry.binaryContent.length,
codeSource);
entry.loadedClass = clazz;
entry.binaryContent = null;
entry.source = null;
entry.codeBase = null;
entry.manifest = null;
entry.certificates = null;
} else {
clazz = entry.loadedClass;
}
}
} else {
clazz = entry.loadedClass;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[5.0] preRegister npe
StandardContext.start throws a (caught) npe for every web application
unless preRegister has been called on the context (line 4151). This is
pretty annoying in Eclipse because it automatically stops on all npes.
For me, preRegister is always called AFTER start, so this stanza always
npes. Anyone help on what needs to be done to reverse the order of
these calls? If not any opposition to something like--
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.130.2.1
diff -u -r1.130.2.1 StandardContext.java
--- StandardContext.java 28 Aug 2004 12:49:54 - 1.130.2.1
+++ StandardContext.java 26 Oct 2004 21:21:44 -
@@ -4143,7 +4143,7 @@
// Look for a realm - that may have been configured earlier.
// If the realm is added after context - it'll set itself.
-if( realm == null ) {
+if( realm == null mserver != null ) {
ObjectName realmName=null;
try {
realmName=new ObjectName( getEngineName() +
:type=Host,host= +
I have to think I'm doing something wrong but I'm not sure what.
This patch sure does seem to help things.
Thanks for any input,
Keith
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapper.java mbeans-descriptors.xml
luehe 2004/10/26 14:55:43
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java mbeans-descriptors.xml
Log:
Removed ServiceTime property that I had added previously.
JSR 77 defines ServiceTime to be of type TimeStatistic, which is a
combination of requestCount, processingTime, minTime, and maxTime, all
of which are already exposed.
Revision ChangesPath
1.53 +1 -14
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
Index: StandardWrapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapper.java,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -r1.52 -r1.53
--- StandardWrapper.java 21 Oct 2004 19:03:46 - 1.52
+++ StandardWrapper.java 26 Oct 2004 21:55:43 - 1.53
@@ -1360,19 +1360,6 @@
swValve.setProcessingTime(processingTime);
}
-/**
- * Returns the execution time of the servlet's service method.
- *
- * This method is identical in functionality to getProcessingTime(),
- * except that it exposes the execution time of the servlet's service
- * method under the JSR 77 compliant property name.
- *
- * @return Execution time of the servlet's service method
- */
-public long getServiceTime() {
-return swValve.getProcessingTime();
-}
-
public long getMaxTime() {
return swValve.getMaxTime();
}
1.39 +1 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml
Index: mbeans-descriptors.xml
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/mbeans-descriptors.xml,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- mbeans-descriptors.xml21 Oct 2004 19:03:46 - 1.38
+++ mbeans-descriptors.xml26 Oct 2004 21:55:43 - 1.39
@@ -581,12 +581,7 @@
type=boolean/
attribute name=processingTime
- description=Execution time of the servlet's service method
- type=long
- writeable=false /
-
-attribute name=serviceTime
- description=Execution time of the servlet's service method
+ description=Total execution time of the servlet's service method
type=long
writeable=false /
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Bernhard Kluschat/EZW/EN01 ist außer Haus.
Ich werde ab 18.10.2004 nicht im Büro sein. Ich kehre zurück am 02.11.2004. Ich werde Ihre Nachricht nach meiner Rückkehr beantworten. In dringenden Fällen wenden Sie sich bitte an meine Kollegen Rolf-Dieter Gross: Tel.: 02056 / 12-5440 und Alexander Martin Tel.: 02056 / 12-5565 oder erreichen mich unter Mobil: 0172 745 81 45 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Hi
-- Virus Warning Message (on uusnwa0p) Found virus WORM_NETSKY.Z in file Details.txt .exe (in Details.zip) The file is deleted. - Important details! -- Virus Warning Message (on uusnwa0p) Details.zip is removed from here because it contains a virus. - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31903] - WebappClassLoader fails to load class form local repository
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31903. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31903 WebappClassLoader fails to load class form local repository [EMAIL PROTECTED] changed: What|Removed |Added Summary|WebappClassLoader fails to |WebappClassLoader fails to |load class form local |load class form local |repository |repository --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 23:37 --- Are you reporting an actual problem, or is it just reading of the source code ? The first part could make sense: I added entry.binaryContent = null after the rest, so the condition might be wrong. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
remm2004/10/26 16:43:44
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
- Apply Keith's patch.
Revision ChangesPath
1.156 +2 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.155
retrieving revision 1.156
diff -u -r1.155 -r1.156
--- StandardContext.java 26 Oct 2004 15:42:02 - 1.155
+++ StandardContext.java 26 Oct 2004 23:43:44 - 1.156
@@ -3890,7 +3890,7 @@
// Look for a realm - that may have been configured earlier.
// If the realm is added after context - it'll set itself.
-if( realm == null ) {
+if( realm == null mserver != null ) {
ObjectName realmName=null;
try {
realmName=new ObjectName( getEngineName() + :type=Realm,host= +
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29823] - 'admin' app saves non-latin descriptions as garbage
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29823. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29823 'admin' app saves non-latin descriptions as garbage [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 23:56 --- *** This bug has been marked as a duplicate of 29091 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29091] - Non-ascii characters are not handled correctly...
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29091 Non-ascii characters are not handled correctly... [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 23:56 --- *** Bug 29823 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java
remm2004/10/26 17:07:45
Modified:catalina/src/share/org/apache/catalina/loader
WebappClassLoader.java
Log:
- Fix condition which seems to not have been properly updated after adding
entry.binaryContent = null a little below.
- Remove useless sync trick.
- Submitted by Joe Zhou as bug 31903.
Revision ChangesPath
1.45 +17 -20
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java
Index: WebappClassLoader.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -r1.44 -r1.45
--- WebappClassLoader.java5 Oct 2004 16:46:15 - 1.44
+++ WebappClassLoader.java27 Oct 2004 00:07:45 - 1.45
@@ -1566,7 +1566,8 @@
entry = findResourceInternal(name, classPath);
-if ((entry == null) || (entry.binaryContent == null))
+if ((entry == null) || (entry.binaryContent == null
+ entry.loadedClass == null))
throw new ClassNotFoundException(name);
Class clazz = entry.loadedClass;
@@ -1620,26 +1621,22 @@
}
-if (entry.loadedClass == null) {
-synchronized (this) {
-if (entry.loadedClass == null) {
-clazz = defineClass(name, entry.binaryContent, 0,
-entry.binaryContent.length,
-codeSource);
-entry.loadedClass = clazz;
-entry.binaryContent = null;
-entry.source = null;
-entry.codeBase = null;
-entry.manifest = null;
-entry.certificates = null;
-} else {
-clazz = entry.loadedClass;
-}
+synchronized (this) {
+if (entry.loadedClass == null) {
+clazz = defineClass(name, entry.binaryContent, 0,
+entry.binaryContent.length,
+codeSource);
+entry.loadedClass = clazz;
+entry.binaryContent = null;
+entry.source = null;
+entry.codeBase = null;
+entry.manifest = null;
+entry.certificates = null;
+} else {
+clazz = entry.loadedClass;
}
-} else {
-clazz = entry.loadedClass;
}
-
+
return clazz;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31912] New: - Add ,css and .png to ReplicationValve filter in server.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31912. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31912 Add ,css and .png to ReplicationValve filter in server.xml Summary: Add ,css and .png to ReplicationValve filter in server.xml Product: Tomcat 5 Version: 5.5.3 Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Catalina:Cluster AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] May I suggest adding the .css and .png file types to the default filter list? Original: Valve className=org.apache.catalina.cluster.tcp.ReplicationValve filter=.*\.gif;.*\.js;.*\.jpg;.*\.htm;.*\.html;.*\.txt;/ Suggested: Valve className=org.apache.catalina.cluster.tcp.ReplicationValve filter=.*\.gif;.*\.js;.*\.jpg;.*\.png;.*\.htm;.*\.html;.*\.css;.*\.txt;/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31912] - Add .css and .png to ReplicationValve filter in server.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31912. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31912 Add .css and .png to ReplicationValve filter in server.xml [EMAIL PROTECTED] changed: What|Removed |Added Summary|Add ,css and .png to|Add .css and .png to |ReplicationValve filter in |ReplicationValve filter in |server.xml |server.xml - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29091] - Non-ascii characters are not handled correctly...
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29091 Non-ascii characters are not handled correctly... --- Additional Comments From [EMAIL PROTECTED] 2004-10-27 05:29 --- Isn't uncommenting the 'Set Character Encoding' filter and its mapping in 'web.xml' for 'admin' app the right approach? Or is it just a shallow fix that does not address some deeper problem? In any case it works for me... Maybe change the default to uncommented filter state in the next release anyway? At least some of new users will not trod on this issue... - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
