DO NOT REPLY [Bug 33106] - SSI Processing Enhancements (patch provided)

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33106





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 22:25 ---
I'll look at this now, so it should be in place for 5.5.10. I won't back port
this to 4.1.x of 5.0.x

David, you might want to consider providing some documentation patches otherwise
people won't be aware of these enhancements.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34192] New: - jsvc compilation failure: x86_64 not supported

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34192

   Summary: jsvc compilation failure: x86_64 not supported
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: critical
  Priority: P4
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I have a Dual Xeon EM64T, when i try to run the "configure" script for the jsvc
it fails saying the cpu architecture is not supported.
I have inserted a line in the configure file to add support for x86_64, i don't
know if i did it well but at least it compiles and seems to work fine...

in the case block (around 2630 line) insert the following code
  x86_64)
CFLAGS="$CFLAGS -DCPU=\\\"i686\\\"" ;;


please add support for the architecture listed above.
thank you guys.
ciao paolo

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 4138] - Processor threads have inconsistent ClassLoader state

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=4138





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 20:46 ---
(In reply to comment #9)
> Thanks Mark, but I noticed that it's not in a finally block in case
> context.invoke() throws an exception.

As per Remy's commit in the commit above, an exception here is a critical error.
I view any such exception as a bug.
 
> Plus, it probably doesn't address the issue I mentioned earlier where it may
> make more sense to move this ContextClassLoader logic to 
> StandardWrapperValve. 
> Thoughts?
Serveral:
- I don't see any code paths that lead to the service() method being called
without switching the ClassLoader.
- Provide a test case that demonstrates this is a problem and I'll try and fix
it. Otherwise, "If it ain't broke don't fix it" applies. Fixing theoretical bugs
is not worth the very real risk of introducing regressions.

Finally, if you do have a test case that demonstrates a problem and there is a
chance that it may have security implications please note that security issues
should be directed to [EMAIL PROTECTED] rather than discussed publically in
bugzilla.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33262] - Service Manager autostart should check for administrative rights

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33262


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 OS/Version|Windows XP  |Mac System 8.5




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34143] - mod_jk-1.2.9. Drops entries from `worker.list' configuration directive

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34143





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 16:59 ---
Sure, I should be able to try the separator char changes early next week. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_status.c

2005-03-26 Thread pero
pero2005/03/26 06:20:48

  Modified:jk/native/common jk_status.c
  Log:
  Fix a typo , Thanks Mladen :-)
  
  Revision  ChangesPath
  1.35  +2 -2  jakarta-tomcat-connectors/jk/native/common/jk_status.c
  
  Index: jk_status.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_status.c,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- jk_status.c   26 Mar 2005 13:48:17 -  1.34
  +++ jk_status.c   26 Mar 2005 14:20:48 -  1.35
  @@ -622,7 +622,7 @@
   /* Skip non lb workers */
   continue;
   }
  -jk_printf(s, "  \n", 
  +jk_printf(s, "  \n", 
i,
lb->s->name,
status_worker_type(w->type), 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml

2005-03-26 Thread Mladen Turk
Peter,
pero2005/03/26 05:48:17
  +jk_printf(s, "  \n", 
Think that sticky=\"$s\" should be sticky=\"%s\"
because I'm getting 'sticky="$s"' in output.
Regards,
Mladen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-connectors/jk/tools jkrelease.sh

2005-03-26 Thread mturk
mturk   2005/03/26 05:49:23

  Modified:jk/tools jkrelease.sh
  Log:
  Add .zip and .zip.asc to release
  
  Revision  ChangesPath
  1.2   +4 -3  jakarta-tomcat-connectors/jk/tools/jkrelease.sh
  
  Index: jkrelease.sh
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/tools/jkrelease.sh,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- jkrelease.sh  26 Mar 2005 12:24:01 -  1.1
  +++ jkrelease.sh  26 Mar 2005 13:49:23 -  1.2
  @@ -2,9 +2,9 @@
   
   # You can change JKTAG and JKVER to desired CVS tag.
   JKTAG="HEAD"
  -JKVER="-current-src"
  +JKEXT="1.2.9"
  +JKVER="-${JKEXT}-src"
   export CVSROOT=:pserver:[EMAIL PROTECTED]:/home/cvspublic
  -cvs login
   cvs export -r ${JKTAG} -d jakarta-tomcat-connectors${JKVER} 
jakarta-tomcat-connectors
   # Remove all files that are not part of jk release
   rm -rf jakarta-tomcat-connectors${JKVER}/ajp
  @@ -29,6 +29,7 @@
   cd ../../../
   tar cvf jakarta-tomcat-connectors${JKVER}.tar 
jakarta-tomcat-connectors${JKVER}
   gzip jakarta-tomcat-connectors${JKVER}.tar
  -
  +zip -9 -r jakarta-tomcat-connectors${JKVER}.zip 
jakarta-tomcat-connectors${JKVER}
   # Create detatched signature
   gpg -ba jakarta-tomcat-connectors${JKVER}.tar.gz
  +gpg -ba jakarta-tomcat-connectors${JKVER}.zip
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml

2005-03-26 Thread pero
pero2005/03/26 05:48:17

  Modified:jk/native/common jk_status.c
   jk/xdocs changelog.xml
  Log:
  change jk:status to xml attribute syntax
  
  Revision  ChangesPath
  1.34  +39 -50jakarta-tomcat-connectors/jk/native/common/jk_status.c
  
  Index: jk_status.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_status.c,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- jk_status.c   15 Mar 2005 06:24:22 -  1.33
  +++ jk_status.c   26 Mar 2005 13:48:17 -  1.34
  @@ -375,22 +375,16 @@
   if (strcmp(uwr->worker_name, worker)) {
   continue;
   }
  -jk_puts(s, "\n");
  -jk_putv(s, "  ",
  -status_val_match(uwr->match_type),
  -"\n", NULL);
  -jk_putv(s, "  ",
  -uwr->uri,
  -"\n", NULL);
  -jk_putv(s, "  ",
  -uwr->context,
  -"\n", NULL);
  -
  +jk_printf(s, "match_type),
  +  uwr->uri,
  +  uwr->context) ;
  +
   if (uwr->suffix)
  -jk_putv(s, "  ",
  +jk_putv(s, " suffix=\"",
   uwr->suffix,
  -"\n", NULL);
  -jk_puts(s, "\n");
  +"\"", NULL);
  +jk_puts(s, " />\n");
   }
   }
   
  @@ -628,47 +622,42 @@
   /* Skip non lb workers */
   continue;
   }
  -jk_printf(s, "  \n%d\n", i);
  -jk_putv(s, "", lb->s->name, "\n", NULL);
  -jk_putv(s, "", status_worker_type(w->type), 
"\n", NULL);
  -jk_putv(s, "", status_val_bool(lb->s->sticky_session),
  -   "\n", NULL);
  -jk_putv(s, "", 
status_val_bool(lb->s->sticky_session_force),
  -   "\n", NULL);
  -jk_printf(s, "%d\n", lb->s->retries);
  -jk_printf(s, "%d\n", 
lb->s->recover_wait_time);
  +jk_printf(s, "  \n", 
  + i,
  + lb->s->name,
  + status_worker_type(w->type), 
  + status_val_bool(lb->s->sticky_session),
  + status_val_bool(lb->s->sticky_session_force),
  + lb->s->retries,
  + lb->s->recover_wait_time);
   for (j = 0; j < lb->num_of_workers; j++) {
   worker_record_t *wr = &(lb->lb_workers[j]);
   ajp_worker_t *a = (ajp_worker_t *)wr->w->worker_private;
  -jk_puts(s, "\n");
  -jk_printf(s, "  %d\n", j);
  -jk_putv(s, "  ", wr->s->name, "\n", NULL);
  -jk_putv(s, "  ", status_worker_type(wr->w->type),
  -   "\n", NULL);
  -
  -jk_putv(s, "  ", a->host, "\n", NULL);
  -jk_printf(s, "  %d\n", a->port);
  -jk_putv(s, "  ", 
jk_dump_hinfo(&a->worker_inet_addr, buf),
  -   "\n", NULL);
   /* TODO: descriptive status */
  -jk_putv(s, "  ",
  -status_val_status(wr->s->is_disabled,
  -  wr->s->in_error_state,
  -  wr->s->in_recovering,
  -  wr->s->is_busy),
  -"\n", NULL);
  -jk_printf(s, "  %d\n", 
wr->s->lb_factor);
  -jk_printf(s, "  %d\n", 
wr->s->lb_value);
  -jk_printf(s, "  %u\n", 
wr->s->elected);
  -jk_printf(s, "  %u\n", wr->s->readed);
  -jk_printf(s, "  %u\n", 
wr->s->transferred);
  -jk_printf(s, "  %u\n", wr->s->errors);
  -jk_printf(s, "  %u\n", wr->s->busy);
  +jk_printf(s, "  s->name,
  +status_worker_type(wr->w->type),
  +a->host,
  +a->port,
  +jk_dump_hinfo(&a->worker_inet_addr, buf),
  +status_val_status(wr->s->is_disabled,
  +  wr->s->in_error_state,
  +  wr->s->in_recovering,
  +  wr->s->is_busy) );
  +  
  +jk_printf(s, " lbfactor=\"%d\"", wr->s->lb_factor);
  +jk_printf(s, " lbvalue=\"%d\"", wr->s->lb_value);
  +jk_printf(s, " elected=\"%u\"", wr->s->elected);
  +jk_printf(s, " readed=\"%u\"", wr->s->readed);
  +jk_printf(s, " transferred=\"%u\"", wr->s->transferred);
  +jk_printf(s, " errors=\"%u\"", wr->s->errors);
  +jk_printf(s, " busy=\"%u\"", wr->s->busy);
   if (wr->s->redirect && *wr->s->redirect)
  -jk_putv(s, "  ", wr->s->redirect, 
"\n", NULL);
  +   

DO NOT REPLY [Bug 34189] - header encoding issue

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34189


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 14:47 ---
Content type applies to the entity body exclusively (ie, not the headers).
There's *no* standard for header encoding (ie, even less than for URL encoding),
and as a result, it always uses the HTTP defaults.
If you need encoding there, you should URL encode/decode your headers using the
appropriate encoding.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/xdocs/howto apache.xml

2005-03-26 Thread mturk
mturk   2005/03/26 05:35:43

  Modified:jk/xdocs/howto apache.xml
  Log:
  Yoav ... xml is not plain text :)
  
  Revision  ChangesPath
  1.6   +4 -4  jakarta-tomcat-connectors/jk/xdocs/howto/apache.xml
  
  Index: apache.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/howto/apache.xml,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- apache.xml23 Mar 2005 18:55:04 -  1.5
  +++ apache.xml26 Mar 2005 13:35:43 -  1.6
  @@ -250,9 +250,9 @@
   
   
 ...
  -  
  -
  -  
  +  
  +
  +  
 ...
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34189] New: - header encoding issue

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34189

   Summary: header encoding issue
   Product: Tomcat 5
   Version: 5.5.7
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Hi,

I've seen lots of encoding related problems with requests, but not a single one
on response headers. So i decided to file this report.

My problem follows:

I've written a CSV export functionality to my program. My servlet inserts a
"Content-Disposition" header into the response, in order to set the filename of
the result csv file. This works fine till I want to insert chars not included in
iso8859-1 encoding, like the accented o char õÕ or u ûÛ. They are converted to a
Qq Pp in the output. (I've checked with ethereal, it is not a client problem)

The character 'õ' has a hibyte. (its unicode value is higher than 256) and if
that hibyte removed it will turn into a 'Q'. 
This transformation therefore indicates a lack of char -> byte conversion for
headers, just a plain cast.

The code follows: 

res.setContentType("text/comma-separated-values");
res.setCharacterEncoding("ISO8859-2");
res.setHeader("Content-Disposition", "attachment; filename=\"" + report + 
".csv\"");

eg. 
report="vevõ" would yield vevQ.csv in the browser.

I was not able to pinpoint the code segment responsible for converting header
strings to a byte stream. 

I hope i was informative enough to resolve the issue. 

Best regards,

Tamas

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JK 1.2.9 Release

2005-03-26 Thread Peter Rossbach
OK,
I look inside the code and made the changes.
peter
Mladen Turk schrieb:
Peter Rossbach wrote:
Hello Mladen,
Can we change the xml status format to attribute semantic?
Feel free to commit the changes :)
This is also syntactic sugar, so if it's valid xml
se no reason why not.
Regards,
Mladen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: JK 1.2.9 Release

2005-03-26 Thread Mladen Turk
Peter Rossbach wrote:
Hello Mladen,
Can we change the xml status format to attribute semantic?
Feel free to commit the changes :)
This is also syntactic sugar, so if it's valid xml
se no reason why not.
Regards,
Mladen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: JK 1.2.9 Release

2005-03-26 Thread Peter Rossbach
Hello Mladen,
Sounds good, some of my customers wait for a new stable release :-)
Can we change the xml status format to attribute semantic?
http://jakarta.apache.org";>
   
   
  
   
   
 
   


currently the format is:
-
   

-
   
-
   
0
lb
lb
True
False
3
60
-
   
0
node1
ajp13
localhost
9012
127.0.0.1:9012
.

The attribute format is much eaisier to parse with diegster! I want 
implement a Jk Proxy Mbean
for easy report the status with mc4j.

Regards
Peter
Mladen Turk schrieb:
Hi,
There has been some commits since 1.2.9 was released as beta.
Since they are non-critical, because they do not change
the operation, but rather the return error messages, I would
still like to tag the release as 1.2.9.
I'll give couple of days and propose a vote for official
announcement. If passed, then we'll just declare it as stable.
If some critical errors gets discovered, I'll just drop the
release and go for 1.2.10.
How that sounds?
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-connectors/jk/tools jkrelease.sh

2005-03-26 Thread mturk
mturk   2005/03/26 04:24:01

  Added:   jk/tools jkrelease.sh
  Log:
  Add shell script for making jk releases.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/jk/tools/jkrelease.sh
  
  Index: jkrelease.sh
  ===
  #/bin/sh
  
  # You can change JKTAG and JKVER to desired CVS tag.
  JKTAG="HEAD"
  JKVER="-current-src"
  export CVSROOT=:pserver:[EMAIL PROTECTED]:/home/cvspublic
  cvs login
  cvs export -r ${JKTAG} -d jakarta-tomcat-connectors${JKVER} 
jakarta-tomcat-connectors
  # Remove all files that are not part of jk release
  rm -rf jakarta-tomcat-connectors${JKVER}/ajp
  rm -rf jakarta-tomcat-connectors${JKVER}/coyote
  rm -rf jakarta-tomcat-connectors${JKVER}/http11
  rm -rf jakarta-tomcat-connectors${JKVER}/jk/java
  rm -rf jakarta-tomcat-connectors${JKVER}/jk/jkant
  rm -rf jakarta-tomcat-connectors${JKVER}/jk/native2
  rm -rf jakarta-tomcat-connectors${JKVER}/jk/test
  rm -rf jakarta-tomcat-connectors${JKVER}/jni
  rm -rf jakarta-tomcat-connectors${JKVER}/juli
  rm -rf jakarta-tomcat-connectors${JKVER}/naming
  rm -rf jakarta-tomcat-connectors${JKVER}/procrun
  rm -rf jakarta-tomcat-connectors${JKVER}/util
  rm -rf jakarta-tomcat-connectors${JKVER}/webapp
  
  # Build documentation.
  cd jakarta-tomcat-connectors${JKVER}/jk/xdocs
  ant
  cd ../native
  ./buildconf.sh
  cd ../../../
  tar cvf jakarta-tomcat-connectors${JKVER}.tar 
jakarta-tomcat-connectors${JKVER}
  gzip jakarta-tomcat-connectors${JKVER}.tar
  
  # Create detatched signature
  gpg -ba jakarta-tomcat-connectors${JKVER}.tar.gz
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_version.h

2005-03-26 Thread mturk
mturk   2005/03/26 04:12:06

  Modified:jk/native/common jk_version.h
  Log:
  Mark version as 1.2.9 release for tagging as JK_1_2_9
  
  Revision  ChangesPath
  1.35  +3 -3  jakarta-tomcat-connectors/jk/native/common/jk_version.h
  
  Index: jk_version.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_version.h,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- jk_version.h  17 Mar 2005 11:31:22 -  1.34
  +++ jk_version.h  26 Mar 2005 12:12:06 -  1.35
  @@ -29,8 +29,8 @@
   #define JK_VERSTRING"1.2.9"
   
   /* Beta number */
  -#define JK_VERBETA  1
  -#define JK_BETASTRING   "1"
  +#define JK_VERBETA  0
  +#define JK_BETASTRING   "0"
   /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */
   #define JK_VERISRELEASE 1
   #define JK_VERRC0
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



JK 1.2.9 Release

2005-03-26 Thread Mladen Turk
Hi,
There has been some commits since 1.2.9 was released as beta.
Since they are non-critical, because they do not change
the operation, but rather the return error messages, I would
still like to tag the release as 1.2.9.
I'll give couple of days and propose a vote for official
announcement. If passed, then we'll just declare it as stable.
If some critical errors gets discovered, I'll just drop the
release and go for 1.2.10.
How that sounds?
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 34186] - issues in about datasource realm

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34186


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 10:44 ---
Please post to tomcat-user instead.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34186] - issues in about datasource realm

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34186





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 10:37 ---
the issue raised by me were
1. cookies must be enabled for datasource realm(configured with MySQL4.1.8) to
work since the session id is saved in a cookie. it menas that if i am using
datasource realm for authentication and authorization and if cookies are
disabled then one cannot log in the application. 
3. Also another thing observed is that the field type of role in the user_role
table musht be varchar and it cannot be integer. I personally had kept it
integer and i was not getting authenticated even if the username and password
were correct.

i would be highly appreciate if anyone could fix it or tell me when they are 
fixed.
thanks in advance!



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 mod_jk.c

2005-03-26 Thread mturk
mturk   2005/03/26 01:37:24

  Modified:jk/native/apache-1.3 mod_jk.c
  Log:
  Do not abort the connection if request is invalid, so that client receives
  apache http error code, instead just dropping connection.
  
  Revision  ChangesPath
  1.76  +4 -3  jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
  retrieving revision 1.75
  retrieving revision 1.76
  diff -u -r1.75 -r1.76
  --- mod_jk.c  18 Mar 2005 08:13:54 -  1.75
  +++ mod_jk.c  26 Mar 2005 09:37:24 -  1.76
  @@ -1793,12 +1793,13 @@
   return OK;  /* NOT r->status, even if it has changed. */
   }
   else if (rc == JK_CLIENT_ERROR) {
  -r->connection->aborted = 1;
  +if (is_error != HTTP_REQUEST_ENTITY_TOO_LARGE)
  +r->connection->aborted = 1;
   jk_log(l, JK_LOG_INFO, "Aborting connection"
  " for worker=%s",
  worker_name);
   JK_TRACE_EXIT(l);
  -return OK;
  +return is_error;
   }
   else {
   jk_log(l, JK_LOG_INFO, "Service error=%d"
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-03-26 Thread mturk
mturk   2005/03/26 01:37:10

  Modified:jk/native/apache-2.0 mod_jk.c
  Log:
  Do not abort the connection if request is invalid, so that client receives
  apache http error code, instead just dropping connection.
  
  Revision  ChangesPath
  1.134 +4 -4  jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
  retrieving revision 1.133
  retrieving revision 1.134
  diff -u -r1.133 -r1.134
  --- mod_jk.c  24 Mar 2005 10:19:19 -  1.133
  +++ mod_jk.c  26 Mar 2005 09:37:10 -  1.134
  @@ -38,7 +38,6 @@
   #include "http_main.h"
   #include "http_log.h"
   #include "util_script.h"
  -
   #include "ap_mpm.h"
   
   #ifdef AS400
  @@ -1964,12 +1963,13 @@
   return OK;  /* NOT r->status, even if it has changed. */
   }
   else if (rc == JK_CLIENT_ERROR) {
  -r->connection->aborted = 1;
  +if (is_error != HTTP_REQUEST_ENTITY_TOO_LARGE)
  +r->connection->aborted = 1;
   jk_log(xconf->log, JK_LOG_INFO, "Aborting connection"
  " for worker=%s",
  worker_name);
   JK_TRACE_EXIT(xconf->log);
  -return OK;
  +return is_error;
   }
   else {
   jk_log(xconf->log, JK_LOG_INFO, "Service error=%d"
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34186] New: - issues in about datasource realm

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34186

   Summary: issues in about datasource realm
   Product: Tomcat 5
   Version: 5.5.7
  Platform: HP
OS/Version: other
Status: NEW
  Keywords: NeedsReleaseNote
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


1. cookies must be enabled for datasource realm(configured with MySQL4.1.8) to
work since the session id is saved in a cookie. it menas that if i am using
datasource realm for authentication and authorization and if cookies are
disabled then one cannot log in the application. 
3. Also another thing observed is that the field type of role in the user_role
table musht be varchar and it cannot be integer. I personally had kept it
integer and i was not getting authenticated even if the username and password
were correct.

since i am new to this forum and to this bugzilla, kidly ignore if i am doing
something that is not required. However opinions would be highly appreciated.
thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_global.h jk_lb_worker.c

2005-03-26 Thread mturk
mturk   2005/03/26 01:28:56

  Modified:jk/native/common jk_ajp_common.c jk_global.h jk_lb_worker.c
  Log:
  Use HTTP_REQUEST_ENTITY_TOO_LARGE when marshaling fails.
  
  Revision  ChangesPath
  1.95  +2 -2  
jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
  
  Index: jk_ajp_common.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
  retrieving revision 1.94
  retrieving revision 1.95
  diff -u -r1.94 -r1.95
  --- jk_ajp_common.c   26 Mar 2005 08:42:14 -  1.94
  +++ jk_ajp_common.c   26 Mar 2005 09:28:56 -  1.95
  @@ -1634,7 +1634,7 @@
* We get here initial request (in reqmsg)
*/
   if (!ajp_marshal_into_msgb(op->request, s, l, p)) {
  -*is_error = JK_HTTP_BAD_REQUEST;
  +*is_error = JK_REQUEST_TOO_LARGE;
   jk_log(l, JK_LOG_INFO,
   "Creating AJP message failed, "
   "without recovery");
  
  
  
  1.46  +2 -1  jakarta-tomcat-connectors/jk/native/common/jk_global.h
  
  Index: jk_global.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_global.h,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -r1.45 -r1.46
  --- jk_global.h   26 Mar 2005 08:41:04 -  1.45
  +++ jk_global.h   26 Mar 2005 09:28:56 -  1.46
  @@ -176,6 +176,7 @@
   
   #define JK_HTTP_OK  200
   #define JK_HTTP_BAD_REQUEST 400
  +#define JK_REQUEST_TOO_LARGE413
   #define JK_HTTP_SERVER_ERROR500
   #define JK_HTTP_SERVER_BUSY 503
   
  
  
  
  1.74  +1 -2  jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c
  
  Index: jk_lb_worker.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- jk_lb_worker.c26 Mar 2005 08:44:11 -  1.73
  +++ jk_lb_worker.c26 Mar 2005 09:28:56 -  1.74
  @@ -633,7 +633,6 @@
   * Clent error !!!
   * Since this is bad request do not fail over.
   */
  -is_service_error = JK_HTTP_BAD_REQUEST;
   rec->s->errors++;
   rec->s->in_error_state = JK_FALSE;
   rec->s->in_recovering = JK_FALSE;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Dagmar Kaluza/CEDROS/DE is out of the office.

2005-03-26 Thread Dagmar . Kaluza
I will be out of the office starting  24.03.2005 and will not return until
04.04.2005.

I will respond to your message when I return. In urgent cases send a mail
to [EMAIL PROTECTED]

Diese E-Mail kann vertrauliche und/oder rechtlich geschuetzte Informationen
enthalten und ist nur fuer die Person bestimmt, an die adressiert wurde.
Sollten Sie diese Nachricht irrtuemlich erhalten haben, untersagen wir,
diese zu verteilen, zu veroeffentlichen, auszudrucken oder zu speichern.
Bitte benachrichtigen Sie den Absender ueber den irrtuemlichen Erhalt und
loeschen Sie diese E-Mail von jedem Computer.

This e-mail may contain confidential and/or legally protected information
and is only intended for the person it is addressed to. If you have
received this message in error, it is prohibited to copy, disclose,
publish, print or save it. You should notify the sender and delete this
message from all computers.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c

2005-03-26 Thread mturk
mturk   2005/03/26 00:44:11

  Modified:jk/native/common jk_lb_worker.c
  Log:
  In case ajp13 worker returns client error do not mark the worker
  in error state. This operation is not recoverable, so return BAD_REQUEST
  to web server.
  
  Revision  ChangesPath
  1.73  +50 -24jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c
  
  Index: jk_lb_worker.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v
  retrieving revision 1.72
  retrieving revision 1.73
  diff -u -r1.72 -r1.73
  --- jk_lb_worker.c26 Feb 2005 07:16:54 -  1.72
  +++ jk_lb_worker.c26 Mar 2005 08:44:11 -  1.73
  @@ -28,15 +28,16 @@
   #include "jk_util.h"
   #include "jk_worker.h"
   #include "jk_lb_worker.h"
  +#include "jk_ajp13.h"
   #include "jk_mt.h"
   #include "jk_shm.h"
   
   /*
  - * The load balancing code in this 
  + * The load balancing code in this
*/
   
   
  -/* 
  +/*
* Time to wait before retry...
*/
   #define JK_WORKER_IN_ERROR(w) ((w)->in_error_state && !(w)->is_disabled && 
!(w)->is_busy)
  @@ -66,9 +67,9 @@
   if (strlen(id_start)) {
   char *id_end;
   id_start = jk_pool_strdup(s->pool, id_start);
  -/* 
  +/*
* The query string is not part of req_uri, however
  - * to be on the safe side lets remove the trailing query 
  + * to be on the safe side lets remove the trailing query
* string if appended...
*/
   if ((id_end = strchr(id_start, '?')) != NULL) {
  @@ -186,14 +187,14 @@
   JK_TRACE_EXIT(l);
   }
   
  -static worker_record_t *find_by_session(lb_worker_t *p, 
  +static worker_record_t *find_by_session(lb_worker_t *p,
   const char *name,
   jk_logger_t *l)
   {
   
   worker_record_t *rc = NULL;
   unsigned int i;
  -
  +
   for (i = 0; i < p->num_of_workers; i++) {
   if (strcmp(p->lb_workers[i].s->name, name) == 0) {
   rc = &p->lb_workers[i];
  @@ -214,7 +215,7 @@
   size_t curmin = 0;
   
   worker_record_t *candidate = NULL;
  -
  +
   /* First try to see if we have available candidate */
   for (i = 0; i < p->num_of_workers; i++) {
   /* Skip all workers that are not member of domain */
  @@ -258,7 +259,7 @@
   unsigned int i;
   int total_factor = 0;
   worker_record_t *candidate = NULL;
  -
  +
   /* First try to see if we have available candidate */
   for (i = 0; i < p->num_of_workers; i++) {
   /* If the worker is in error state run
  @@ -286,14 +287,14 @@
   return candidate;
   }
   
  -static worker_record_t *find_best_bytraffic(lb_worker_t *p, 
  +static worker_record_t *find_best_bytraffic(lb_worker_t *p,
jk_logger_t *l)
   {
   unsigned int i;
   size_t mytraffic = 0;
   size_t curmin = 0;
   worker_record_t *candidate = NULL;
  -
  +
   /* First try to see if we have available candidate */
   for (i = 0; i < p->num_of_workers; i++) {
   /* If the worker is in error state run
  @@ -316,11 +317,11 @@
   curmin = mytraffic;
   }
   }
  -}
  +}
   return candidate;
   }
   
  -static worker_record_t *find_bysession_route(lb_worker_t *p, 
  +static worker_record_t *find_bysession_route(lb_worker_t *p,
const char *name,
jk_logger_t *l)
   {
  @@ -379,7 +380,7 @@
   {
   worker_record_t *rc = NULL;
   unsigned int i;
  -const char *redirect = NULL;
  +const char *redirect = NULL;
   
   for (i = 0; i < p->num_of_workers; i++) {
   if (strlen(p->lb_workers[i].s->redirect)) {
  @@ -522,6 +523,7 @@
   lb_endpoint_t *p = e->endpoint_private;
   int attempt = 0;
   int num_of_workers = p->worker->num_of_workers;
  +worker_record_t *prec = NULL;
   /* Set returned error to OK */
   *is_error = JK_HTTP_OK;
   
  @@ -539,12 +541,14 @@
   worker_record_t *rec =
   get_most_suitable_worker(p->worker, s, attempt++, l);
   int rc;
  -
  -if (rec) {
  +/* Do not reuse previous worker, because
  + * that worker already failed.
  + */
  +if (rec && rec != prec) {
   int is_service_error = JK_HTTP_OK;
  -int service_ok = JK_FALSE;
  +int service_stat = JK_FALSE;
   jk_endpoint_t *end = NULL;
  -
  +
   s->jvm_route = rec->r;
   rc = rec->w->get_endpoint(rec->w, &end, l);
  

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c

2005-03-26 Thread mturk
mturk   2005/03/26 00:42:14

  Modified:jk/native/common jk_ajp_common.c
  Log:
  In case there is an error in marshaling initial data return that as client
  error not as server error.
  
  Revision  ChangesPath
  1.94  +38 -19
jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
  
  Index: jk_ajp_common.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
  retrieving revision 1.93
  retrieving revision 1.94
  diff -u -r1.93 -r1.94
  --- jk_ajp_common.c   22 Feb 2005 10:27:37 -  1.93
  +++ jk_ajp_common.c   26 Mar 2005 08:42:14 -  1.94
  @@ -906,7 +906,7 @@
   jk_log(l, JK_LOG_ERROR,
  "unknown protocol %d, supported are AJP13/AJP14", ae->proto);
   JK_TRACE_EXIT(l);
  -return JK_FALSE;
  +return JK_FATAL_ERROR;
   }
   
   if ((rc = jk_tcp_socket_sendfull(ae->sd, jk_b_get_buff(msg),
  @@ -1103,7 +1103,7 @@
   
   if ((len = ajp_read_fully_from_server(r, l, read_buf, len)) < 0) {
   jk_log(l, JK_LOG_INFO,
  -   "ERROR: receiving data from client failed. "
  +   "Error receiving data from client failed. "
  "Connection aborted or network problems");
   JK_TRACE_EXIT(l);
   return JK_CLIENT_ERROR;
  @@ -1148,7 +1148,7 @@
   ajp_endpoint_t * ae, ajp_operation_t * op)
   {
   int err = 0;
  -int postlen;
  +int postlen, rc = 0;
   
   JK_TRACE_ENTER(l);
   /* Up to now, we can recover */
  @@ -1182,10 +1182,16 @@
* connection and try again.  If we are succesful, break out of this
* loop. */
   if (err ||
  -(ajp_connection_tcp_send_message(ae, op->request, l) == 
JK_FALSE)) {
  +((rc = ajp_connection_tcp_send_message(ae, op->request, l)) != 
JK_TRUE)) {
   jk_log(l, JK_LOG_INFO,
  "Error sending request. Will try another pooled 
connection");
  -ajp_next_connection(ae, l);
  +if (rc != JK_FATAL_ERROR)
  +ajp_next_connection(ae, l);
  +else {
  +op->recoverable = JK_FALSE;
  +JK_TRACE_EXIT(l);
  +return JK_FALSE;
  +}
   }
   else
   break;
  @@ -1210,7 +1216,7 @@
* After we are connected, each error that we are going to
* have is probably unrecoverable
*/
  -if (ajp_connection_tcp_send_message(ae, op->request, l) == 
JK_FALSE) {
  +if (ajp_connection_tcp_send_message(ae, op->request, l) != 
JK_TRUE) {
   jk_log(l, JK_LOG_INFO,
  "Error sending request on a fresh connection");
   JK_TRACE_EXIT(l);
  @@ -1246,7 +1252,7 @@
   
   postlen = jk_b_get_len(op->post);
   if (postlen > AJP_HEADER_LEN) {
  -if (ajp_connection_tcp_send_message(ae, op->post, l) == JK_FALSE) {
  +if (ajp_connection_tcp_send_message(ae, op->post, l) != JK_TRUE) {
   jk_log(l, JK_LOG_ERROR, "Error resending request body (%d)",
  postlen);
   JK_TRACE_EXIT(l);
  @@ -1263,7 +1269,7 @@
   postlen = jk_b_get_len(s->reco_buf);
   
   if (postlen > AJP_HEADER_LEN) {
  -if (ajp_connection_tcp_send_message(ae, s->reco_buf, l) == 
JK_FALSE) {
  +if (ajp_connection_tcp_send_message(ae, s->reco_buf, l) != 
JK_TRUE) {
   jk_log(l, JK_LOG_ERROR,
  "Error resending request body (lb mode) (%d)",
  postlen);
  @@ -1300,7 +1306,7 @@
   /* the browser stop sending data, no need to recover */
   op->recoverable = JK_FALSE;
   JK_TRACE_EXIT(l);
  -return JK_CLIENT_ERROR;
  +return len;
   }
   
   /* If a RECOVERY buffer is available in LB mode, fill it */
  @@ -1310,7 +1316,7 @@
   }
   
   s->content_read = len;
  -if (ajp_connection_tcp_send_message(ae, op->post, l) == 
JK_FALSE) {
  +if (ajp_connection_tcp_send_message(ae, op->post, l) != JK_TRUE) 
{
   jk_log(l, JK_LOG_ERROR, "Error sending request body");
   JK_TRACE_EXIT(l);
   return JK_FALSE;
  @@ -1621,7 +1627,6 @@
   
   p->left_bytes_to_send = s->content_length;
   p->reuse = JK_FALSE;
  -*is_error = 0;
   
   s->secret = p->worker->secret;
   
  @@ -1629,9 +1634,12 @@
* We get here initial request (in reqmsg)
*/
   if (!ajp_marshal_into_msgb(op->request, s, l, p)) {
  -*is_error = JK_HTTP_SERVER_ERROR;
  +*is_error = JK_HTTP_BAD_REQUEST;
  +jk_log(l, JK_LOG_INFO,
  +  

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_global.h

2005-03-26 Thread mturk
mturk   2005/03/26 00:41:04

  Modified:jk/native/common jk_global.h
  Log:
  Add BAD_REQUEST http status code define
  
  Revision  ChangesPath
  1.45  +3 -2  jakarta-tomcat-connectors/jk/native/common/jk_global.h
  
  Index: jk_global.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_global.h,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- jk_global.h   16 Feb 2005 15:09:21 -  1.44
  +++ jk_global.h   26 Mar 2005 08:41:04 -  1.45
  @@ -174,9 +174,10 @@
   /* HTTP Error codes
*/
   
  +#define JK_HTTP_OK  200
  +#define JK_HTTP_BAD_REQUEST 400
   #define JK_HTTP_SERVER_ERROR500
   #define JK_HTTP_SERVER_BUSY 503
  -#define JK_HTTP_OK  200
   
   
   /*
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Behaviour of mod_jk AJP 1.3 load balanced workers

2005-03-26 Thread Mladen Turk
Mathias Herberts wrote:
Now that I think more of that, you can use the Apache's
'LimitRequestLine' directive (default 8190), so this won't get to
the mod_jk at first.
this will indeed fix some cases, but the AJP13 packet can still be 
filled up by adding junk headers to the request, Apache does not take 
headers into account to compute the size of the RequestLine (only the 
URI is).

Yes, this is the limitation of the AJP13 protocol.
AJP14 will have unlimited initial header size, consisting of
multiple packets in case of overflow.
The DOS condition is then still there.
I have a patch for 1.2.9, so you will need to upgrade the jk.
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33810] - Stream closed errors from JSP tags under load

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33810





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 09:28 ---
remm2005/03/24 03:41:29

  Modified:jasper2/src/share/org/apache/jasper/runtime
BodyContentImpl.java
  Log:
  - Close shouldn't null the char buffer.
  
  Revision  ChangesPath
  1.15  +0 -1 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
  
  Index: BodyContentImpl.java
  ===
  RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- BodyContentImpl.java  4 Mar 2005 18:00:41 -   1.14
  +++ BodyContentImpl.java  24 Mar 2005 11:41:29 -  1.15
  @@ -496,7 +496,6 @@
if (writer != null) {
writer.close();
} else {
  - cb = null;  
closed = true;
}
   }


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34183] - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 09:27 ---
As you said, in the end, it is up to me.

The obvious benefit of open source is that, if you do not agree, you can
experiment in any way you would like.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]