cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2002-10-04 Thread keith
keith 2002/10/04 16:07:23 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Don't dup the work if it has already been done Revision ChangesPath 1.39 +2 -1 jakarta-tomcat-connectors/http11/src/java/org/a

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/loggers AccessLogInterceptor.java

2002-10-04 Thread keith
keith 2002/10/04 11:33:11 Modified:src/share/org/apache/tomcat/modules/loggers AccessLogInterceptor.java Log: Use CRLF on Win32 for access log Revision ChangesPath 1.8 +2 -1 jakarta-tomcat/src/share/org/apache/tomcat/modules/loggers

cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler CharDataGenerator.java MappedCharDataGenerator.java

2002-08-17 Thread keith
keith 2002/08/17 18:53:38 Modified:src/share/org/apache/jasper/compiler CharDataGenerator.java MappedCharDataGenerator.java Log: Jasper fix for high byte chars (xlate to unicode) Submitted by: Thibault Frey Revision ChangesPath 1.6 +17

RE: [PROPOSAL] Split the repo's

2002-07-18 Thread Keith Wannamaker
| | [X] I don't want the API's split into separate repo's | [ ] I don't care | [ ] I want the API's split into separate repo's. | TC 4 has too many external module dependencies as it is. Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For

RE: Tomcat 4.x auth issue

2002-07-03 Thread Keith Wannamaker
= "/"; +return(false); if ((pattern == null) || (pattern.length() == 0)) pattern = "/"; I'll apply this fix if someone more versed in 4.x approves it. Keith | -Original Message- | From: Keith Wannamaker [mailto:[EMAIL PROTECTED]] | Sent: Wednesday, J

Tomcat 4.x auth issue

2002-07-03 Thread Keith Wannamaker
uth valve. Any better ideas are welcome as I begin hacking.. Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant Tomcat3Precompiler.java

2002-06-11 Thread keith
keith 2002/06/11 15:50:03 Modified:src/share/org/apache/tomcat/ant Tomcat3Precompiler.java Log: Minor fixes that came up with cygwin Revision ChangesPath 1.3 +6 -3 jakarta-tomcat/src/share/org/apache/tomcat/ant/Tomcat3Precompiler.java Index

cvs commit: jakarta-tomcat/src/doc tomcat-ssl-howto.html

2002-06-06 Thread keith
keith 2002/06/06 12:37:07 Modified:src/doc tomcat-ssl-howto.html Log: Clear up some clientauth confusion. Revision ChangesPath 1.13 +4 -0 jakarta-tomcat/src/doc/tomcat-ssl-howto.html Index: tomcat-ssl-howto.html

cvs commit: jakarta-tomcat/src/doc tomcat-ssl-howto.html

2002-06-06 Thread keith
keith 2002/06/06 11:39:19 Modified:src/doc tomcat-ssl-howto.html Log: Wrong closing tag. Revision ChangesPath 1.12 +1 -1 jakarta-tomcat/src/doc/tomcat-ssl-howto.html Index: tomcat-ssl-howto.html

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant Tomcat3Precompiler.java

2002-06-06 Thread keith
keith 2002/06/06 11:37:19 Modified:src/share/org/apache/tomcat/ant Tomcat3Precompiler.java Log: The bleeding edge: Work with Ant > 1.5 B2. Revision ChangesPath 1.2 +6 -6 jakarta-tomcat/src/share/org/apache/tomcat/ant/Tomcat3Precompiler.java In

[3.3.2-dev] CoyoteConnector2 invalid headers

2002-06-03 Thread Keith Wannamaker
ideas while I dig through the code? Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

RE: ant tasks for 3.3

2002-05-22 Thread Keith Wannamaker
Hmm, you might try taking xerces out the CLASSPATH property if there is already one in {ant.home}/lib I would guess there are two copies of an XML provider in your classpath.. are you using JDK1.4? I did a google on this error and apparently it comes up a lot. Keith | -Original Message

RE: [VOTE] New committer: Denis Benoit

2002-05-21 Thread Keith Wannamaker
+1 Keith | -Original Message- | From: Remy Maucherat [mailto:[EMAIL PROTECTED]] | Sent: Tuesday, May 21, 2002 9:33 PM | To: [EMAIL PROTECTED] | Subject: [VOTE] New committer: Denis Benoit | | | I'd like to propose Denis Benoit as a committer on | the Tomcat project.

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant/META-INF ant.properties

2002-05-21 Thread keith
keith 02/05/21 11:24:45 Added: src/share/org/apache/tomcat/ant/META-INF ant.properties Removed: src/share/org/apache/tomcat/ant ant.properties Log: Move ant.properties Revision ChangesPath 1.1 jakarta-tomcat/src/share/org/apache/tomcat/ant

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant/META-INF - New directory

2002-05-21 Thread keith
keith 02/05/21 11:15:23 jakarta-tomcat/src/share/org/apache/tomcat/ant/META-INF - New directory -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant Tomcat3JSPVersionFile.java

2002-05-21 Thread keith
keith 02/05/21 11:15:02 Modified:.build.xml src/share/org/apache/tomcat/ant Tomcat3JSPVersionFile.java Log: tomcat-ant changes: - move ant.properties to META-INF - add regexpclasspath attribute to version task Revision ChangesPath 1.180

jakarta-tomcat-jasper Jasper2

2002-05-20 Thread Keith Wannamaker
sper.JspC.parseFiles(Unknown Source) at org.apache.jasper.JspC.main(Unknown Source) Any ideas? Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

RE: tomcat-dev compile failure

2002-05-18 Thread Keith Wannamaker
Ah, I thought the JspC task had been around longer. I agree. The build should now ignore that task unless an appropriate version of Ant is installed. Keith | -Original Message- | From: Ignacio J. Ortega [mailto:[EMAIL PROTECTED]] | Sent: Saturday, May 18, 2002 12:03 PM | To: '

cvs commit: jakarta-tomcat build.xml

2002-05-18 Thread keith
keith 02/05/18 10:17:13 Modified:.build.xml Log: Tomcat-ant task depends on JspC task in Ant, which isn't in latest release build, 1.4.1. To build this task use the 1.5 beta or head. Revision ChangesPath 1.179 +4 -2 jakarta-tomcat/buil

RE: ant tools for 3.3 and dtomcat3/rc script

2002-05-17 Thread Keith Wannamaker
You've got it. I thought you were talking post-install, but, again, if Ant's available you can use the task whenever you wanted to. Keith | -Original Message- | From: Jason Corley [mailto:[EMAIL PROTECTED]] | Sent: Friday, May 17, 2002 9:50 AM | To: Tomcat Developers List

RE: ant tools for 3.3 and dtomcat3/rc script

2002-05-17 Thread Keith Wannamaker
I agree that's why I wrote the task :-) Maybe I misuderstood Jason,.. thought he wanted to use the ant tool post-installation-- tomcat recompile would be a better option in that case, IMO. But, of course, the ant tool can be used, if ant is available. Keith | -Original Me

RE: ant tools for 3.3 and dtomcat3/rc script

2002-05-17 Thread Keith Wannamaker
No, for a Tomcat which has already been installed, you should use the JspC tomcat option to precompile JSPs. What I did is to create an Ant task with the same functionality as the already-present JspC option, for use in build environments. Keith | -Original Message- | From: Jason

RE: cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt

2002-05-17 Thread Keith Wannamaker
It's already checked in to Tomcat, so the jar is created when you do a build. Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Friday, May 17, 2002 8:26 AM | To: Tomcat Developers List | Subject: RE: cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.

RE: cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt

2002-05-17 Thread Keith Wannamaker
for every class file of the form name_number.class Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Friday, May 17, 2002 8:06 AM | To: Tomcat Developers List | Subject: RE: cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt | | | > (Re-) Open the

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt

2002-05-17 Thread keith
keith 02/05/17 06:03:46 Modified:.RELEASE-NOTES-3.3.2.txt Log: Make a note of the new Ant code Revision ChangesPath 1.8 +6 -1 jakarta-tomcat/RELEASE-NOTES-3.3.2.txt Index: RELEASE-NOTES-3.3.2.txt

RE: ant tools for 3.3

2002-05-15 Thread Keith Wannamaker
adapter in j-t for now, rather than j-t-j. It can always be moved later, especially since I know nothing about the mangler j-t-j. Yes, optimally, mangling support would be more flexible and it should go over there, but it's ok for now in j-t. Keith | -Original Message- | From: [EMAI

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant Tomcat3JSPVersionFile.java Tomcat3Precompiler.java ant.properties

2002-05-15 Thread keith
keith 02/05/15 20:15:13 Modified:.build.xml Added: src/share/org/apache/tomcat/ant Tomcat3JSPVersionFile.java Tomcat3Precompiler.java ant.properties Log: Add Tomcat related Ant tasks for precompiling JSPs. Revision ChangesPath

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/ant - New directory

2002-05-15 Thread keith
keith 02/05/15 20:12:14 jakarta-tomcat/src/share/org/apache/tomcat/ant - New directory -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

ant tools for 3.3

2002-05-15 Thread Keith Wannamaker
I've written some ant tools that allow builds to populate the Tomcat work directories with precompiled JSPs. I'm trying to decide a home for them, if any, and was thinking of a new package org.apache.tomcat.ant .. any other preference? code is @ http://apache.org/~keith/ Ke

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-05-15 Thread keith
keith 02/05/15 11:53:46 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Wrap acceptSocket in a try to be more robust Revision ChangesPath 1.3 +9 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

RE: found 3.3-head thread problem

2002-05-15 Thread Keith Wannamaker
. I'll add it right now.. Keith | Great finding. | | I would also add another round of try/catch for Throwable | to catch any other NPE in the catch(). | | Not sure about the logic - it is supposed to detect and start | new threads... If you can take a look... | | Costin | | | --

found 3.3-head thread problem

2002-05-15 Thread Keith Wannamaker
see if our accepting thread count dwindles or vanishes, and start more up? Is this logic non-existant or broken? Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res LocalStrings.properties

2002-05-15 Thread keith
keith 02/05/15 10:38:37 Modified:util/java/org/apache/tomcat/util/net/res LocalStrings.properties Log: Add PoolTcpEndpoint messages Revision ChangesPath 1.2 +4 -0 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res

Thread issues

2002-05-10 Thread Keith Wannamaker
significant change I see is Bill's change to the expirer, but I'm not sure if that is related at all. The purpose of this note is to solicit ideas on debugging and to see if anyone else has run into this behavior. Thanks, Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat build.xml

2002-04-24 Thread keith
keith 02/04/24 05:26:23 Modified:.build.xml Log: Fix build with the http11 connector Revision ChangesPath 1.177 +1 -1 jakarta-tomcat/build.xml Index: build.xml === RCS file

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf ByteChunk.java

2002-04-23 Thread keith
keith 02/04/23 13:07:57 Modified:util/java/org/apache/tomcat/util/buf ByteChunk.java Log: Better check Revision ChangesPath 1.11 +1 -1 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/ByteChunk.java Index: ByteChunk.java

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/mappers DecodeInterceptor.java

2002-04-23 Thread Keith Wannamaker
Costin, et al, if you folks know of a faster way to check for this, by all means -Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] | Sent: Tuesday, April 23, 2002 2:50 PM | To: [EMAIL PROTECTED] | Subject: cvs commit: | jakarta-tomcat/src/share/org

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/mappers DecodeInterceptor.java

2002-04-23 Thread keith
keith 02/04/23 12:49:40 Modified:src/share/org/apache/tomcat/modules/mappers DecodeInterceptor.java Log: Our security measure is too agressive; incorrectly mangles proxy-style urls. Check for http/https exceptions when removing double slashes

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf ByteChunk.java

2002-04-23 Thread keith
keith 02/04/23 12:44:14 Modified:util/java/org/apache/tomcat/util/buf ByteChunk.java Log: Add startsWith(byte[]) for use by DecoderInterceptor Revision ChangesPath 1.10 +18 -0 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/ByteChunk.java

RE: cvs commit: jakarta-tomcat/src/tests/webpages/WEB-INF test-tomcat.xml

2002-04-18 Thread Keith Wannamaker
I haven't heard from any 4.0 folks -- any interest in me doing something similar for that tree? Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] | Sent: Thursday, April 18, 2002 8:58 AM | To: [EMAIL PROTECTED] | Subject: cvs commit: jakarta-tomca

cvs commit: jakarta-tomcat/src/tests/webpages/WEB-INF test-tomcat.xml

2002-04-18 Thread keith
keith 02/04/18 06:58:01 Modified:.README RELEASE-NOTES-3.3.2.txt build.xml src/admin index.html src/build/nightly start_tomcat.sh stop_tomcat.sh src/build/pkg prototype tomcat.spec src/doc readme serverxml.html

RE: FW: Unsubscribing

2002-04-03 Thread Hawkins, Keith (Keith)
mail that currently appears at the bottom of each tomcat list message doesn't send out unsubscribe instructions.) I haven't tried unsubscribing from the list. -Keith -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Tuesday, April 02, 2002 7:44 PM To:

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/res LocalStrings.properties

2002-03-05 Thread keith
keith 02/03/05 06:24:09 Modified:util/java/org/apache/tomcat/util/http/res LocalStrings.properties Log: Add 423 Locked status message Revision ChangesPath 1.2 +1 -0 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/res

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/http/res LocalStrings.properties

2002-03-05 Thread keith
keith 02/03/05 06:18:15 Modified:src/share/org/apache/tomcat/util/http/res LocalStrings.properties Log: Add 423 Locked to message bundle. Revision ChangesPath 1.2 +1 -0 jakarta-tomcat/src/share/org/apache/tomcat/util/http/res

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf ByteChunk.java CharChunk.java

2002-02-06 Thread keith
keith 02/02/06 21:37:35 Modified:util/java/org/apache/tomcat/util/buf ByteChunk.java CharChunk.java Log: indexOf should return an index relative to the internal starting point of the string rather than the beginning of the array. Ported over from main

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/buf ByteChunk.java CharChunk.java

2002-02-05 Thread keith
keith 02/02/05 14:06:18 Modified:src/share/org/apache/tomcat/util/buf ByteChunk.java CharChunk.java Log: indexOf should return an index relative to the internal starting point of the string rather than the beginning of the array. ByteChunk.indexOf is

Bug in safe url parsing

2002-02-05 Thread Keith Wannamaker
+ int ret = indexOf( buff, start+starting, end, c); + return (ret >= start) ? ret - start : -1; } public static int indexOf( byte bytes[], int off, int end, char qq ) I will commit this later today if I hear no objection. Regards, Keith -- To unsubscribe, e-mail: &l

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core Context.java

2001-12-22 Thread keith
keith 01/12/22 10:58:30 Modified:src/share/org/apache/tomcat/core Context.java Log: Cut-paste error. Revision ChangesPath 1.150 +0 -1 jakarta-tomcat/src/share/org/apache/tomcat/core/Context.java Index: Context.java

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.1.txt

2001-12-21 Thread keith
keith 01/12/21 11:14:25 Modified:.RELEASE-NOTES-3.3.1.txt Log: Document ErrorHandler change. Revision ChangesPath 1.17 +5 -2 jakarta-tomcat/RELEASE-NOTES-3.3.1.txt Index: RELEASE-NOTES-3.3.1.txt

FW: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/generators ErrorHandler.java

2001-12-20 Thread Keith Wannamaker
A 4.x person might want to take a look to make sure this doesn't happen there, too. The performance and stability of Netscape is like night and day with this... Keith -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Thursday, December 20, 2001 2:57

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/generators ErrorHandler.java

2001-12-20 Thread keith
keith 01/12/20 11:59:30 Modified:src/share/org/apache/tomcat/modules/generators ErrorHandler.java Log: spaces -> tabs Revision ChangesPath 1.22 +4 -4 jakarta-tomcat/src/share/org/apache/tomcat/modules/generators/ErrorHandler.j

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/generators ErrorHandler.java

2001-12-20 Thread keith
keith 01/12/20 11:56:44 Modified:src/share/org/apache/tomcat/modules/generators ErrorHandler.java Log: The statusHandler is returning a body for 304 responses, which is forbidden by both HTTP/1.1 and HTTP/1.0. IE is forgiving, but Netscape Navs <

Ever increasing heap size with Tomcat 3.2.3 !!!

2001-12-18 Thread Hawkins, Keith (Keith)
solution. That just delays the inevitable. Any insight as to how to keep the Tomcat process from grabbing more and more memory would be appreciated. Thanks, Keith

RE: ajpv12 socket closure

2001-12-12 Thread Keith Wannamaker
rstand why this solves the problem, but at least the fix is now documented for posterity. Keith | -Original Message- | From: Keith Wannamaker [mailto:[EMAIL PROTECTED]] | Sent: Wednesday, December 12, 2001 2:59 PM | To: [EMAIL PROTECTED] | Subject: ajpv12 socket closure | | | I've bee

ajpv12 socket closure

2001-12-12 Thread Keith Wannamaker
of so_linger was to specify the amount of time to try to send the queue bits onto the wire prior to closing the socket. Wouldn't this indicate that the present value (100) is too small? The relevant t-d thread is http://w6.metronet.com/~wjm/tomcat/2000/Sep/msg00151.html Thanks f

RE: 3.3 classloading & resources

2001-11-28 Thread Keith Wannamaker
Hi Costin, Yes, I verified that this does indeed do the trick. Wonder if Sun is going to fix ResourceBundle to handle this? Hope so! At any rate, thanks for the tip. Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] | Sent: Monday, November 26, 2001 6:49

3.3 classloading & resources

2001-11-26 Thread Keith Wannamaker
t binds the code to the Tomcat container. My next step is to rebuild the jdk with debugging info to see which loader is actually being used in ResourceBundle.getBundle, but I appreciate any insight in the interim. Keith -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

RE: [PATCH][3.3] tomcat.sh cleanup

2001-10-21 Thread Keith Wannamaker
It would be nice also to display the command that is used to initialize the jk web config files, jkconf or whatever. Keith | -Original Message- | From: Jeff Turner [mailto:[EMAIL PROTECTED]] | Sent: Sunday, October 21, 2001 2:44 AM | To: [EMAIL PROTECTED] | Subject: [PATCH][3.3

RE: cvs commit: jakarta-tomcat/src/native/mod_jk/common jk_global.h

2001-10-01 Thread Keith Wannamaker
I thought what we decided to do was use s->uri = r->uri (a URI decoded already in Apache) and in the facade, re-encode it. So JK_OPT_FWDURICOMPAT should be the default. | -Original Message- | + * We use JkOptions to determine which method to be used | + * | + * ap_

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_ajp_common.h

2001-10-01 Thread keith
keith 01/10/01 13:50:39 Modified:jk/doc AJPv13.html jk/java/org/apache/ajp Ajp13.java RequestHandler.java jk/native/common jk_ajp_common.c jk_ajp_common.h Log: DeltaV is now an IESG Proposed Standard. Add the four new versioning methods

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
I thought you were talking about the mod_jk in the TC3.3 branch. If you're talking j-t-c only, then I don't mind an Option, as long as it defaults to the 3.3 behavior. Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 200

cvs commit: jakarta-tomcat/src/native/mod_jk/common jk_ajp13.c

2001-10-01 Thread keith
keith 01/10/01 13:08:14 Modified:src/doc AJPv13.html src/native/mod_jk/common jk_ajp13.c Log: Toss the CRs Revision ChangesPath 1.5 +5 -5 jakarta-tomcat/src/doc/AJPv13.html Index: AJPv13.html

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/server Ajp13.java

2001-10-01 Thread keith
keith 01/10/01 12:58:08 Modified:src/doc AJPv13.html src/native/mod_jk/common jk_ajp13.c src/share/org/apache/tomcat/modules/server Ajp13.java Log: DeltaV is now an IESG Proposed Standard. Add the four new versioning methods. Revision

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
orts. I'd hesitate to add it. Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 10:35 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | >What whould happen in 3.3 if ForwardEsc

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
What whould happen in 3.3 if ForwardEscapedURI was chosen? Wouldn't the facade escape it again? Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 10:10 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: T

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
n Option? Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 5:18 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | | >- Revert jk/apache to use uri, remove the encode call ( again, j-t

RE: [PATCH] Potential buffer overflow attach in mod_jk

2001-09-26 Thread Keith Wannamaker
I was afraid of that... guess os memory allocation it is, then. Keith | It looked to me like | uw_map->p wasn't suitable for per-request allocations (i.e. it would just | eat memory until the server was re-started), and since this is in common, I | couldn't use ap_strdup since th

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
I'm +1 for this. It is the best solution. Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] | | 3. Revert to the use of uri ( i.e. the decoded uri ), and | change the getRequestURI ( the facade ) to generated a | 'canonical' encoding. | Problems:

RE: [PATCH] Potential buffer overflow attach in mod_jk

2001-09-26 Thread Keith Wannamaker
lease do some testing. Thanks, Keith | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED]] | Sent: Wednesday, September 26, 2001 2:37 PM | To: [EMAIL PROTECTED] | Subject: Fw: [PATCH] Potential buffer overflow attach in mod_jk | | | Urm, let's try that again with a patch

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
Are you using mod_jk? | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED]] | Sent: Wednesday, September 26, 2001 1:17 PM | To: [EMAIL PROTECTED] | Subject: Re: TC 3.3: getRequestURI() | | | I don't get this with RC1. From tomcat-log with debugging enabled for

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
rather fix SessionID with this patch. However, are there other places where TC is manipulating the URL and assuming it is unencoded? Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On | Behalf Of jean-frederic clere | Sent: Wednesday, September 26, 2001 1

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
I'm not sure I understand why the session id was not also showing up with r->unparsed_uri. I'm doing some experimenting now.. Keith |/login/login.vm%3bjsessionid=q95pbsuof1 | Probably not. It's a side of effect of the last change which was | to use "s->req_uri = ap_

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_global.h

2001-09-17 Thread keith
keith 01/09/17 18:31:18 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c jk/native/common jk_global.h Log: Enable mod_rewrite by passing Apache's r->uri to Tomcat, but encode it for spec compliance. Revision

cvs commit: jakarta-tomcat/src/native/apache1.3 mod_jk.c

2001-09-17 Thread keith
keith 01/09/17 16:53:21 Modified:src/native/apache1.3 Tag: tomcat_32 mod_jk.c Log: Enable mod_rewrite by passing Apache's r->uri to Tomcat, but encode it for spec compliance. Revision ChangesPath No revision No

cvs commit: jakarta-tomcat/src/native/mod_jk/common jk_global.h

2001-09-17 Thread keith
keith 01/09/17 16:43:59 Modified:src/native/mod_jk/apache1.3 mod_jk.c src/native/mod_jk/common jk_global.h Log: Enable mod_rewrite and maintain spec compliance by passing Apache's r->uri to Tomcat, but re-encoding it first. Revision ChangesPat

RE: [J-T-C] Apache 2.0 code review required

2001-09-17 Thread Keith Wannamaker
ur changes would have any effect on them. Keith Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat/src/native/mod_jk/apache1.3/mod_jk.c,v retrieving revision 1.16 diff -u -b -r1.16 mod_jk.c --- mod_jk.c2001/09/14 17:47:5

RE: Ajp13 change in recent TC 3.3

2001-09-17 Thread Keith Wannamaker
atch would break that. Definitely the changes require upgrading jk when Tomcat is upgraded to 3.3.. there's no way around that. Keith

RE: [J-T-C] Apache 2.0 code review required

2001-09-16 Thread Keith Wannamaker
e-encode). The spec issue is simply to have (at least) the appropriate charaters escaped in the uri available to the servlet. This change would both enable mod_rewrite and also be compliant with the spec. Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent

RE: Remaining Tomcat 3.3 Issues

2001-09-12 Thread Keith Wannamaker
Then we need to be sure to encode r->uri in the main branch and to change r->unparsed_uri to encode(r->uri) in the 3.2 branch. I am swamped now and will put it on a long todo list.. if anyone beats me to it..... Keith | -Original Message- | From: [EMAIL PROTECTED] [mail

RE: Remaining Tomcat 3.3 Issues

2001-09-12 Thread Keith Wannamaker
Oops, yep, that fix only went into the _32 branch. 3.3 still uses r->uri. IIRC the thread never reached a consensus, except that a proxy is free to decode and encode requests, so encode(r->uri) might be permissible, but r->unparsed_uri is the only way to preserve the encodin

RE: Remaining Tomcat 3.3 Issues

2001-09-12 Thread Keith Wannamaker
mod_jk uses (used?) r->unparsed_uri to preserve encoding. Therefore, any mod_rewrite munging of r->uri is invisible to mod_jk. This is the issue to which Larry is referring, not Apache module ordering. Keith | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED]]

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_ajp_common.h

2001-09-10 Thread keith
keith 01/09/10 14:51:57 Modified:jk/native/common jk_ajp_common.c jk_ajp_common.h Log: Corner case for chunked encoding: if the chunk sizes and buffers fell such that the buffer was nearly full and the chunk size digits were too numerous to fit in the remaining space, the

cvs commit: jakarta-tomcat/src/native/mod_jk/common jk_ajp13_worker.c

2001-09-10 Thread keith
keith 01/09/10 14:43:36 Modified:src/native/mod_jk/common jk_ajp13_worker.c Log: Corner case for chunked encoding: if the chunk sizes and buffers fell such that the buffer was nearly full and the chunk size digits were too numerous to fit in the remaining space, the

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_service.h jk_util.c

2001-09-10 Thread keith
keith 01/09/10 11:32:36 Modified:jk/java/org/apache/ajp Ajp13.java jk/native/apache-1.3 mod_jk.c jk/native/common jk_ajp_common.c jk_service.h jk_util.c Log: Port chunked encoding input support from jakarta-tomcat ajp13. Revision Changes

RE: [VOTE] Removal of mod_jk for Apache 2.0 from jakarta-tomcat f or T omcat 3.3

2001-09-10 Thread Keith Wannamaker
I just finished merging all the chunked encoding support for ajp13 into j-t-c and was about to checkin. I'll hold off until we decide about this: | Henri - could we undo the ajp13.c changes, for example by copying the | current ajp13 from j-t and re-doing the autoconf changes ? Having Keith

cvs commit: jakarta-tomcat/src/native/mod_jk/apache1.3 mod_jk.c

2001-09-10 Thread keith
keith 01/09/10 08:07:13 Modified:src/native/mod_jk/apache1.3 mod_jk.c Log: General case of chunked input was traversing an unintended code path. Reported by: David Schreibman <[EMAIL PROTECTED]> Revision ChangesPath 1.15 +3 -2 jakarta-tomcat/src/

RE: [VOTE] Removal of mod_jk for Apache 2.0 from jakarta-tomcat for Tomcat 3.3

2001-09-07 Thread Keith Wannamaker
+1 Keith | -Original Message- | VOTE: | | [ ] +1 REMOVE: Apache 2.0 mod_jk should be removed from |jakarta-tomcat for Tomcat 3.3 | [ ] -1 KEEP: Apache 2.0 mod_jk should be kept in |jakarta-tomcat for Tomcat 3.3

RE: cvs commit: jakarta-tomcat/src/webpages index.html

2001-09-02 Thread Keith Wannamaker
I don't know, the 99 just looked pretty stale. Feel free to change it... Keith | -Original Message- | From: Christopher Cain [mailto:[EMAIL PROTECTED]] | Sent: Sunday, September 02, 2001 2:19 PM | To: [EMAIL PROTECTED] | Subject: Re: cvs commit: jakarta-tomcat/src/webpages index

cvs commit: jakarta-tomcat/src/webpages index.html

2001-09-02 Thread keith
keith 01/09/02 07:14:00 Modified:src/webpages index.html Log: front page © date Revision ChangesPath 1.16 +1 -1 jakarta-tomcat/src/webpages/index.html Index: index.html === RCS file

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/server Ajp13.java

2001-08-31 Thread keith
keith 01/08/31 18:53:25 Modified:src/native/mod_jk/apache1.3 mod_jk.c src/native/mod_jk/common jk_ajp13_worker.c jk_service.h jk_util.c src/share/org/apache/tomcat/modules/server Ajp13.java Log: Upgrade mod_jk to support

TC 3.3 Mod_jk chunked input encoding

2001-08-29 Thread Keith Wannamaker
This patch enables chunked input through mod_jk: http://www.apache.org/~keith/jk/ I think they are rather minor changes. Please review, discuss, and throw everything you have at it. If Larry approves I will commit this (or an approved version) to tc 3.3. In addition, I would port it to the

RE: embedded tc

2001-08-29 Thread Keith Wannamaker
When I run a debugger (which is now running the embedded tomcat), I point straight to the build/tomcat/classes tree rather than have a lib directory. This way I don't have to rebuild the jars every time I make a change. I would have thought this would be a common procedure?

embedded tc

2001-08-28 Thread Keith Wannamaker
Could this ever happen or am I doing something silly? Keith Index: src/share/org/apache/tomcat/startup/EmbededTomcat.java === RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/EmbededTomcat.java, v retrieving

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/t estHeader.java HttpRequest.java

2001-08-28 Thread Keith Wannamaker
dded in knowing this explicitly. | | I don't *think* the Java side needs to be changed at all, Yeah, I've got chunked input working ok with just some changes to the c side of jk. I'll clean it up and post tomorrow for dissection. Keith

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/t estHeader.java HttpRequest.java

2001-08-28 Thread Keith Wannamaker
ral, it seems like a good idea to leverage as much as possible from | > the transport. Um, let's get chunked encoding in first... Keith

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/testHeader.java HttpRequest.java

2001-08-28 Thread Keith Wannamaker
Heh, you beat me to it. I'd like to compare notes. Can you resend the diff with -u -b? Keith | -Original Message- | From: Schreibman, David [mailto:[EMAIL PROTECTED]] | Sent: Tuesday, August 28, 2001 11:17 AM | To: '[EMAIL PROTECTED]' | Subject: RE: cvs commit: | jak

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/testHeader.java HttpRequest.java

2001-08-28 Thread Keith Wannamaker
| This has nothing to do with tomcat accepting Chunked encoding on the | request - we did few fixes but this hasn't been tested yet, I believe | there are few changes in mod_jk we still have to do. | Almost done... Keith

RE: [PATCH TC4] added jndi.jar to classpath in javac task

2001-08-27 Thread Keith Wannamaker
Hi John, I did not need to do this to build tc4 out of the box. What was the build error? Is your build.properties pointing to jndi OK? If you do an ant -verbose, does ${jndi.home} get set correctly? TC4 will automatically include ${jndi.home}/lib/jndi.jar (see catalina/build.xml:28) Keith

cvs commit: jakarta-tomcat-connectors/util .cvsignore

2001-08-27 Thread keith
keith 01/08/27 08:36:47 Added: jk .cvsignore util .cvsignore Log: .cvsignore goodness Revision ChangesPath 1.1 jakarta-tomcat-connectors/jk/.cvsignore Index: .cvsignore

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c jk_ajp_common.h

2001-08-27 Thread keith
keith 01/08/27 08:33:04 Modified:jk/doc AJPv13.html jk/java/org/apache/ajp Ajp13.java RequestHandler.java jk/native/common jk_ajp_common.c jk_ajp_common.h Log: Add REPORT method to Ajp13 (necessary for Webdav ACL and Delta-V). This has also been

<    1   2   3   >