Re: [PATCH] Bug 22666

2003-09-27 Thread Remy Maucherat
Mark Thomas wrote: The usefulness of porting the big patches from TC 5 to a new 4.2 branch depends on the release schedule for TC5. Are we still expecting the final version of JSR152 this month? I don't know. We'll know in a few days :-D If this is the case then I agree that the core of 4.1 shou

RE: [PATCH] Bug 22666

2003-09-27 Thread Mark Thomas
The usefulness of porting the big patches from TC 5 to a new 4.2 branch depends on the release schedule for TC5. Are we still expecting the final version of JSR152 this month? If this is the case then I agree that the core of 4.1 should be frozen for non-critical fixes. However, if a stable rele

Re: [PATCH] Bug 22666

2003-09-27 Thread Remy Maucherat
Mark Thomas wrote: The original bug was reported against TC4 so I have ported the patch in order to close the bug report. TC4 does not include the uRLEncoding parameter on the connector so I have implemented the queryStringEncoding parameter as Remy previously suggested. To make TC5 consistent

RE: [PATCH] Bug 22666

2003-09-27 Thread Mark Thomas
The original bug was reported against TC4 so I have ported the patch in order to close the bug report. TC4 does not include the uRLEncoding parameter on the connector so I have implemented the queryStringEncoding parameter as Remy previously suggested. To make TC5 consistent with TC4, I have add

RE: [PATCH] Bug 22666

2003-09-09 Thread Mark Thomas
This works a treat. Do you want me to port the changes back to TC4? I need to do this so I can close the bug. Mark On Sunday, September 07, 2003 3:40 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: > > The idea is that it would work if the type of the MB is chars (see > processParameters(MB))

Re: [PATCH] Bug 22666

2003-09-07 Thread Remy Maucherat
Mark Thomas wrote: On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Remy Maucherat wrote: I've just committed a very simple implementation of this (without the extra queryStringEncoding field, although this is not hard to add). Comments ? Remy Thanks for your

RE: [PATCH] Bug 22666

2003-09-07 Thread Mark Thomas
On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: > Remy Maucherat wrote: > > I've just committed a very simple implementation of this (without the > extra queryStringEncoding field, although this is not hard to add). > Comments ? > > Remy Thanks for your help w

Re: [PATCH] Bug 22666

2003-09-07 Thread Remy Maucherat
Remy Maucherat wrote: I'll vote almost 2 ;-) No client I know of is always cosistently using UTF8 to encode the URL, but however, I'm not sure clients are using the encoding of the entity body to encode the URL. Proper character decoding of the decoded (it means %xx decoded here) URL is already

Re: [PATCH] Bug 22666

2003-09-06 Thread Remy Maucherat
Mark Thomas wrote: This is obviously a bigger mess than I first thought. As I see it, the following options exist for resolving bug 22666. 1. WONTFIX - On the basis that there is too much uncertainty to do anything sensible and that any changes made might break interoperability as per Remy's p

Re: [PATCH] Bug 22666

2003-09-06 Thread Bill Barker
orce this. The POST parameters will generally be in the encoding of the referrer (which usually isn't UTF-8). - Original Message - From: "Mark Thomas" <[EMAIL PROTECTED]> To: "'Tomcat Developers List'" <[EMAIL PROTECTED]> Sent: Saturday, Se

RE: [PATCH] Bug 22666

2003-09-06 Thread Mark Thomas
This is obviously a bigger mess than I first thought. As I see it, the following options exist for resolving bug 22666. 1. WONTFIX - On the basis that there is too much uncertainty to do anything sensible and that any changes made might break interoperability as per Remy's point 3 below. 2. FI

Re: [PATCH] Bug 22666

2003-09-05 Thread Remy Maucherat
Mark Thomas wrote: I was working from http://www.w3.org/International/O-URL-code.html Applying the patch fixed the problem as reported in bug 22666. I am happy to have another look at this. Can you point me in the direction of a better reference? Well, -1 because: 1) Everyone ignores this stand

RE: [PATCH] Bug 22666

2003-09-05 Thread Mark Thomas
I was working from http://www.w3.org/International/O-URL-code.html Applying the patch fixed the problem as reported in bug 22666. I am happy to have another look at this. Can you point me in the direction of a better reference? Mark On Friday, September 05, 2003 7:46 PM, Remy Maucherat [SMTP:

Re: [PATCH] Bug 22666

2003-09-05 Thread Remy Maucherat
Mark Thomas wrote: URIs are always UTF-8 encoded. Therefore the parameter encoding should be set to UTF-8 and not to the request encoding (if set). Patches for TC5 and TC4 are below. ? This is incorrect, strong -1 for this patch. Remy --

[PATCH] Bug 22666

2003-09-05 Thread Mark Thomas
URIs are always UTF-8 encoded. Therefore the parameter encoding should be set to UTF-8 and not to the request encoding (if set). Patches for TC5 and TC4 are below. Mark Index: catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java ==