Re: [PATCH] CatalinaBlock.java

2001-02-12 Thread Sam Ruby
Remy Maucherat wrote: For these reasons, I'd like to see an official Avalon wrapper introduced in Tomcat 4.1, but not in Tomcat 4.0. I also propose to remove the current Avalon wrapper from the Tomcat 4.0 repository, to avoid the maintenance related issues. +1 - Sam Ruby

Re: [PATCH] CatalinaBlock.java

2001-02-12 Thread Aaron Mulder
It's always going to be the case that the Avalon and Tomcat releases don't sync up perfectly. How would you feel about making any Tomcat changes necessary to support the Avalon patch, but maintaining the Avalon block itself outside of the main Tomcat 4.0 module? That way the Avalon

Re: [PATCH] CatalinaBlock.java

2001-02-12 Thread Craig R. McClanahan
Aaron Mulder wrote: It's always going to be the case that the Avalon and Tomcat releases don't sync up perfectly. How would you feel about making any Tomcat changes necessary to support the Avalon patch, but maintaining the Avalon block itself outside of the main Tomcat 4.0 module?

Re: [PATCH] CatalinaBlock.java

2001-02-12 Thread Sam Ruby
Aaron Mulder wrote: It's always going to be the case that the Avalon and Tomcat releases don't sync up perfectly. How would you feel about making any Tomcat changes necessary to support the Avalon patch, but maintaining the Avalon block itself outside of the main Tomcat 4.0 module? That

Re: [PATCH] CatalinaBlock.java

2001-02-12 Thread Thom May
* Sam Ruby ([EMAIL PROTECTED]) wrote on Mon Feb 12, 2001 at 01:39:07PM -0500: Aaron Mulder wrote: It's always going to be the case that the Avalon and Tomcat releases don't sync up perfectly. How would you feel about making any Tomcat changes necessary to support the Avalon patch, but

Modules subproject ( was: Re: [PATCH] CatalinaBlock.java )

2001-02-12 Thread cmanolache
Actually, I was thinking starting a modules subprojects for things like that in 4.1. It would be really great to have a module subproject !!! ( as long as it will host 3.3 modules too :-) This will keep the release more focused on the core functionality, and simplify the testing and

Re: [PATCH] CatalinaBlock.java

2001-02-11 Thread Jason Brittain
Sam Ruby wrote: Jason van Zyl wrote: While playing with Sam Ruby's gump I noticed that the CatalinaBlock is out of sync with Avalon. Not sure if staying right up-to-date is critical but here's the patch anyway. Until Avalon ships, tracking to the current APIs is the only way

Re: [PATCH] CatalinaBlock.java

2001-02-11 Thread Remy Maucherat
If you like that patch, you'll probably also like the ones I sent in on Friday -- messages with the title "[PATCH] TC4: TomcatBlock on Avalon 3.1a1".. I'm -1 on applying the Avalon patch in the 4.0 tree. The rationale is : - Avalon isn't ready yet. It's still in alpha stage, and I fear there

[PATCH] CatalinaBlock.java

2001-02-10 Thread Jason van Zyl
Hi, While playing with Sam Ruby's gump I noticed that the CatalinaBlock is out of sync with Avalon. Not sure if staying right up-to-date is critical but here's the patch anyway. jvz. Index: CatalinaBlock.java === RCS file:

Re: [PATCH] CatalinaBlock.java

2001-02-10 Thread Sam Ruby
Jason van Zyl wrote: While playing with Sam Ruby's gump I noticed that the CatalinaBlock is out of sync with Avalon. Not sure if staying right up-to-date is critical but here's the patch anyway. Until Avalon ships, tracking to the current APIs is the only way to go. I've committed the