Re: [PATCH] use ap_ prefixed PCRE functions - take 2

2004-02-26 Thread Guenter Knauf
Hi Kurt, I've reviewed your patch and have some comments included inline below. regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp needs an apr_pool to be passed to it and it returns the regex_t. I think (apr_pool_t *)uriEnv-pool-_private is correct here (Henri?,

Re: [PATCH] use ap_ prefixed PCRE functions - take 2

2004-02-26 Thread Kurt Miller
Hi Guenter, I've reviewed your patch and have some comments included inline below. From: Guenter Knauf [EMAIL PROTECTED] Hi all, the previous patch seems to break non-Apache connectors, so here's another patch which shouldnt break anything unless you set the HAVE_AP_PCRE. I would like to get

[PATCH] use ap_ prefixed PCRE functions - take 2

2004-02-25 Thread Guenter Knauf
Hi all, the previous patch seems to break non-Apache connectors, so here's another patch which shouldnt break anything unless you set the HAVE_AP_PCRE. I would like to get this patch into CVS in order to use PCRE on NetWare where only the ap_ prefixed pcre functions are exported. I have tested