AW: AW: AW: [5.0] JSP performance ...

2003-09-10 Thread Torsten Fohrer
next try -Ursprüngliche Nachricht- Von: Torsten Fohrer [mailto:[EMAIL PROTECTED] Gesendet: Dienstag, 9. September 2003 13:55 An: 'Tomcat Developers List' Betreff: AW: AW: AW: [5.0] JSP performance ... patched a snapshot to merge template text nodes. I implement following using

Re: AW: AW: AW: [5.0] JSP performance ...

2003-09-10 Thread Remy Maucherat
Torsten Fohrer wrote: next try Yes, the code is better (IMO) and performs a little better also. However, looking more at my profiler, I think the problem with that benchmark is all the not optimized int - String conversions. Since that's not too useful in the real world (but in that benchmark,

Re: AW: AW: AW: [5.0] JSP performance ...

2003-09-10 Thread Kin-Man Chung
Date: Wed, 10 Sep 2003 18:34:40 +0200 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: AW: AW: AW: [5.0] JSP performance ... To: Tomcat Developers List [EMAIL PROTECTED] Torsten Fohrer wrote: next try Yes, the code is better (IMO) and performs a little better also. However

Re: AW: [5.0] JSP performance ...

2003-09-09 Thread Remy Maucherat
Kin-Man Chung wrote: I have implemented generating text strings as char arrays, with a compiler option to turn it on and off, and did some timings on the benchmark. Just as I suspected, the benchmark did not show much performance difference, when the option was turned on and then off. Now I am

AW: AW: [5.0] JSP performance ...

2003-09-09 Thread Torsten Fohrer
] Gesendet: Dienstag, 9. September 2003 09:00 An: Tomcat Developers List Betreff: Re: AW: [5.0] JSP performance ... Kin-Man Chung wrote: I have implemented generating text strings as char arrays, with a compiler option to turn it on and off, and did some timings on the benchmark. Just as I suspected

Re: AW: AW: [5.0] JSP performance ...

2003-09-09 Thread Remy Maucherat
Torsten Fohrer wrote: what's about char[] array/string reusing? Create only a char array for each unique templatetext node. - 10 x char[] jspx_text_1 = something\n; 1 x char[] jspx_text_1 = something\n; Won't the VM do that internally ? Since apparently you have examined that issue in

AW: AW: AW: [5.0] JSP performance ...

2003-09-09 Thread Torsten Fohrer
Betreff: Re: AW: AW: [5.0] JSP performance ... Torsten Fohrer wrote: what's about char[] array/string reusing? Create only a char array for each unique templatetext node. - 10 x char[] jspx_text_1 = something\n; 1 x char[] jspx_text_1 = something\n; Won't the VM do that internally

Re: AW: AW: AW: [5.0] JSP performance ...

2003-09-09 Thread Jeff Tulley
Developers List Betreff: Re: AW: AW: [5.0] JSP performance ... Torsten Fohrer wrote: what's about char[] array/string reusing? Create only a char array for each unique templatetext node. - 10 x char[] jspx_text_1 = something\n; 1 x char[] jspx_text_1 = something\n; Won't the VM do

Re: AW: [5.0] JSP performance ...

2003-09-09 Thread Kin-Man Chung
Date: Tue, 09 Sep 2003 08:59:51 +0200 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: AW: [5.0] JSP performance ... To: Tomcat Developers List [EMAIL PROTECTED] Kin-Man Chung wrote: I have implemented generating text strings as char arrays, with a compiler option to turn

AW: [5.0] JSP performance ...

2003-09-08 Thread Torsten Fohrer
i have patched jasper to use char arrays instead of strings, and it gaves a good performance improvment. It's not perfect, but is works. cu Torsten -Ursprüngliche Nachricht- Von: Remy Maucherat [mailto:[EMAIL PROTECTED] Gesendet: Sonntag, 7. September 2003 15:49 An: Tomcat Developers

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Remy Maucherat
Torsten Fohrer wrote: i have patched jasper to use char arrays instead of strings, and it gaves a good performance improvment. It's not perfect, but is works. Resin is also concatenating the strings, to reduce the amount of write calls. In this particular test, it is useful; IRL, probably a bit

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
This seems easy enough to implement, so I'll look into it. Concatenating texts is also on my list, and it should help a little in this case. - Kin-man Date: Mon, 08 Sep 2003 08:46:32 +0200 From: Torsten Fohrer [EMAIL PROTECTED] Subject: AW: [5.0] JSP performance ... To: 'Tomcat Developers

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Remy Maucherat
Kin-Man Chung wrote: This seems easy enough to implement, so I'll look into it. Concatenating texts is also on my list, and it should help a little in this case. That would be awesome. The test had a *lot* of writes, so this would save hundreds of write invocations (as well as making them faster

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
PROTECTED] Subject: Re: AW: [5.0] JSP performance ... To: Tomcat Developers List [EMAIL PROTECTED] Kin-Man Chung wrote: This seems easy enough to implement, so I'll look into it. Concatenating texts is also on my list, and it should help a little in this case. That would be awesome

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Kin-Man Chung
if there is any value in committing my change. :( -Kin-man Date: Mon, 08 Sep 2003 15:18:34 -0700 (PDT) From: Kin-Man Chung [EMAIL PROTECTED] Subject: Re: AW: [5.0] JSP performance ... To: [EMAIL PROTECTED] Content-MD5: +Y/z1F8l8EXxpI9LL3yPSA== I took a look at o.a.j.runtime.JspWriterImpl

Re: AW: [5.0] JSP performance ...

2003-09-08 Thread Paul Speed
two methods should be on par in terms of performance. That is, I don't see any extra unnecessary copies. Perhasp the culprit is those extra writes? -Kin-man Date: Mon, 08 Sep 2003 23:03:19 +0200 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: AW: [5.0] JSP performance