Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

> > I think the stage has to be maintained in the Request object. > > > > No, definitely not. Here's how MinTC (MinimalTomcat) does > it (this is alpha code, and I've deleted some of the methods > to keep the size down): I think I would have implemented it that way also. The thing is that the cu

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

remm02/04/04 07:02:13 Modified:catalina/src/share/org/apache/catalina/core StandardPipeline.java Log: - Refactor the pipeline valve context using comments from Christopher St John. Revision ChangesPath 1.6 +67 -62 jakarta-tomcat-4.0/

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

Christopher St. John wrote: > > No, definitely not. Here's how MinTC (MinimalTomcat) does > it (this is alpha code, and I've deleted some of the methods > to keep the size down): > Thanks..I like MinTC's solution. Arvind -- To unsubscribe, e-mail: For addition

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

Arvind Srinivasan wrote: > > Christopher St. John wrote: > > > > The obvious implementation is to have have ValveContext hold > > the index. > > But isn't a ValveContext (Pipeline) shared across requests ? > It's shouldn't be, but it is now. StandardPipeline implements VavleContext, but there

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

Christopher St. John wrote: > > The obvious implementation is to have have ValveContext hold > the index. > > That's how I assumed it worked the first time I > saw the Pipeline, Valve and ValveContext classes. I was suprised > to see a ThreadLocal. Using ValveContext has the appropriate > thread

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

Arvind Srinivasan wrote: > > I think the performance related change that you made to StandardPipeline can > be improved upon in that it can avoid using a HashMap to store/retrieve the > pipeline stage and instead simply store/retrieve it from an integer variable > in the RequestBase class. Since

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

Hi Remy, I think the performance related change that you made to StandardPipeline can be improved upon in that it can avoid using a HashMap to store/retrieve the pipeline stage and instead simply store/retrieve it from an integer variable in the RequestBase class. Since this codepath (StandardPip

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

remm02/03/31 20:19:55 Modified:catalina/src/share/org/apache/catalina/core StandardPipeline.java Log: - Use a note in the request instead of a ThreadLocal to keep track of the pipeline stage. Note: This could cause problems with a valve that would

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java

craigmcc02/01/02 17:52:14 Modified:catalina/src/share/org/apache/catalina/core StandardPipeline.java Log: Correct typo in the Javadocs ("values" --> "valves"). Submitted by: Christopher K. St. John <[EMAIL PROTECTED]> Revision ChangesPath 1.4

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardPipeline.java ContainerBase.java LocalStrings.properties StandardContext.java StandardContextValve.java StandardEngine.java StandardEngineValve.java StandardHost.java StandardHostValve.java StandardWrapper.java StandardWrapperValve.java

craigmcc01/01/22 18:51:17 Modified:catalina/src/share/org/apache/catalina/core ContainerBase.java LocalStrings.properties StandardContext.java StandardContextValve.java StandardEngine.java StandardEngineValve.java