DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15693.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Costin Manolache wrote:
You're probably right that addThread() doesn't need to be public - but
I don't think it hurts too much either.
It does when you're trying to refactor a class. It forces you to ask
whether the interface really is used, or can you rearrange like you want
to. Usually I
Umm...that last patch won't compile, I forgot to remove a line. Knew I
was forgetting to do something. :-[
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Michael wrote:
Costin Manolache wrote:
You're probably right that addThread() doesn't need to be public - but
I don't think it hurts too much either.
It does when you're trying to refactor a class. It forces you to ask
whether the interface really is used, or can you rearrange like you
jfclere 2002/12/28 01:08:58
Modified:webapps/tomcat-docs/appdev build.xml.txt
Log:
typo ;-)
Revision ChangesPath
1.7 +2 -2 jakarta-tomcat-4.0/webapps/tomcat-docs/appdev/build.xml.txt
Index: build.xml.txt
Michael wrote:
Umm...that last patch won't compile, I forgot to remove a line. Knew I
was forgetting to do something. :-[
Although refactoring the monitor timer code is relatively safe, the
thread pool as a whole is a critical piece of code in Tomcat 4.1.x (=
you should test things
Remy Maucherat wrote:
Also: MonitorRunnable, now that it has a start() method (for JMX, I
presume) has no restriction on running more than one thread. This
undercuts the meaning of interval, and makes stop() poorly defined.
I would like it if this was fixing any issue
the above (which
Remy Maucherat wrote:
Although refactoring the monitor timer code is relatively safe, the
thread pool as a whole is a critical piece of code in Tomcat 4.1.x (=
you should test things extensively after making a change).
Since your patch doesn't build, I'll have to assume you didn't try to
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Saturday, December 28, 2002 12:40 AM
Subject: Re: [PATCH] Re: ThreadPool
Michael wrote:
Costin Manolache wrote:
You're probably right that addThread() doesn't need to
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14164.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14164.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13861.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13861.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13861.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15693.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
16 matches
Mail list logo