Re: Migration to Subversion

2005-07-30 Thread Mark Thomas

Bill Barker wrote:

That is fine as long as you build and run on a 1.4+ JDK but when checking
for 1.3 compatibility the Coyote/HTTP connector fails. The root cause is
the use of the 1.4 regexp API in o.a.coyote.http11.Http11Processor
(http://marc.theaimsgroup.com/?l=tomcat-dev&m=109403344007532&w=2).


This is true.  However in TC 3.3 the Coyote connectors have always been
optional.  That's why I've kept it using j-t-c HEAD even with the 1.4
dependancy.  Of course, it's pretty mote until it's time to do a 3.3.3
release ;-).


Ah. Didn't know that. That explains a few things.


Unless anyone has a better idea, I'll crack on with 3 over the weekend.


I've thought that it should be possible to do this with an Ant filter (so
that you don't have to maintain a separate copy of the file).  I've always
been too lazy to actually sit down and write it however. :).


Very cunning. I'll take a look at doing it this way.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Migration to Subversion

2005-07-30 Thread Henri Gomez
As one of the few, still having TC 3.3.x in production (hard to make
net admins move), I could see that I have no problem with JTC and JDK
1.4.x dependencies.

And as you say, JTC is optional in TC 3.3.x :)



2005/7/30, Bill Barker <[EMAIL PROTECTED]>:
> 
> - Original Message -
> From: "Mark Thomas" <[EMAIL PROTECTED]>
> To: "Tomcat Developers List" 
> Sent: Friday, July 29, 2005 3:30 PM
> Subject: Re: Migration to Subversion
> 
> 
> > Yoav Shapira wrote:
> > >
> > >>Any and all comments appreciated. In particular:
> > >>a. Should more 3.x.x versions should be included in 4 & 5 above?
> > >>b. I have assumed that all releases before 5.5.x will use the 5.0 branch
> > >>of the connectors. Is this assumption valid?
> > >
> > > I don't think so.  Some Tomcat 3.x versions, for example, already use
> the
> > > latest connectors that are also used by Tomcat 5.5.
> >
> > That is fine as long as you build and run on a 1.4+ JDK but when checking
> for
> > 1.3 compatibility the Coyote/HTTP connector fails. The root cause is the
> use
> > of the 1.4 regexp API in o.a.coyote.http11.Http11Processor
> > (http://marc.theaimsgroup.com/?l=tomcat-dev&m=109403344007532&w=2).
> >
> 
> This is true.  However in TC 3.3 the Coyote connectors have always been
> optional.  That's why I've kept it using j-t-c HEAD even with the 1.4
> dependancy.  Of course, it's pretty mote until it's time to do a 3.3.3
> release ;-).
> 
> > Possible solutions:
> > 1. Use the 5.0 branch
> > 2. Revert the patch and go back to using jakarta-regexp
> > 3. Introduce an o.a.coyote.http11.tomcat4 package and place a copy of
> > Http11Processor in it that uses jakarta-regexp.
> >
> > Pros/Cons
> > 1. Would mean an awful lot of porting.
> > 2. Quick but adds an unnecessary library to TC5 and leaves TC5 using two
> > different regexp libs
> > 3. Relatively quick but would need some build.xml tweaking for TC5
> >
> > Unless anyone has a better idea, I'll crack on with 3 over the weekend.
> >
> 
> I've thought that it should be possible to do this with an Ant filter (so
> that you don't have to maintain a separate copy of the file).  I've always
> been too lazy to actually sit down and write it however. :).
> 
> > On the Subversion front, I have TC4 building with
> jakarta-tomcat-connectors
> > HEAD and will commit it once I have finished testing the various connector
> and
> > JVM combinations (I don't plan to provide APR support in TC4). Once I have
> got
> > this out of the way, I'll work with Henri on the test Watchdog migration.
> >
> > Mark
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> 
> 
> 
> This message is intended only for the use of the person(s) listed above as 
> the intended recipient(s), and may contain information that is PRIVILEGED and 
> CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, 
> or distribute this message or any attachment. If you received this 
> communication in error, please notify us immediately by e-mail and then 
> delete all copies of this message and any attachments.
> 
> In addition you should be aware that ordinary (unencrypted) e-mail sent 
> through the Internet is not secure. Do not send confidential or sensitive 
> information, such as social security numbers, account numbers, personal 
> identification numbers and passwords, to us via ordinary (unencrypted) e-mail.
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Migration to Subversion

2005-07-29 Thread Bill Barker

- Original Message -
From: "Mark Thomas" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" 
Sent: Friday, July 29, 2005 3:30 PM
Subject: Re: Migration to Subversion


> Yoav Shapira wrote:
> >
> >>Any and all comments appreciated. In particular:
> >>a. Should more 3.x.x versions should be included in 4 & 5 above?
> >>b. I have assumed that all releases before 5.5.x will use the 5.0 branch
> >>of the connectors. Is this assumption valid?
> >
> > I don't think so.  Some Tomcat 3.x versions, for example, already use
the
> > latest connectors that are also used by Tomcat 5.5.
>
> That is fine as long as you build and run on a 1.4+ JDK but when checking
for
> 1.3 compatibility the Coyote/HTTP connector fails. The root cause is the
use
> of the 1.4 regexp API in o.a.coyote.http11.Http11Processor
> (http://marc.theaimsgroup.com/?l=tomcat-dev&m=109403344007532&w=2).
>

This is true.  However in TC 3.3 the Coyote connectors have always been
optional.  That's why I've kept it using j-t-c HEAD even with the 1.4
dependancy.  Of course, it's pretty mote until it's time to do a 3.3.3
release ;-).

> Possible solutions:
> 1. Use the 5.0 branch
> 2. Revert the patch and go back to using jakarta-regexp
> 3. Introduce an o.a.coyote.http11.tomcat4 package and place a copy of
> Http11Processor in it that uses jakarta-regexp.
>
> Pros/Cons
> 1. Would mean an awful lot of porting.
> 2. Quick but adds an unnecessary library to TC5 and leaves TC5 using two
> different regexp libs
> 3. Relatively quick but would need some build.xml tweaking for TC5
>
> Unless anyone has a better idea, I'll crack on with 3 over the weekend.
>

I've thought that it should be possible to do this with an Ant filter (so
that you don't have to maintain a separate copy of the file).  I've always
been too lazy to actually sit down and write it however. :).

> On the Subversion front, I have TC4 building with
jakarta-tomcat-connectors
> HEAD and will commit it once I have finished testing the various connector
and
> JVM combinations (I don't plan to provide APR support in TC4). Once I have
got
> this out of the way, I'll work with Henri on the test Watchdog migration.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Migration to Subversion

2005-07-29 Thread Mark Thomas

Yoav Shapira wrote:



Any and all comments appreciated. In particular:
a. Should more 3.x.x versions should be included in 4 & 5 above?
b. I have assumed that all releases before 5.5.x will use the 5.0 branch
of the connectors. Is this assumption valid?


I don't think so.  Some Tomcat 3.x versions, for example, already use the
latest connectors that are also used by Tomcat 5.5.


That is fine as long as you build and run on a 1.4+ JDK but when checking for 
1.3 compatibility the Coyote/HTTP connector fails. The root cause is the use 
of the 1.4 regexp API in o.a.coyote.http11.Http11Processor 
(http://marc.theaimsgroup.com/?l=tomcat-dev&m=109403344007532&w=2).


Possible solutions:
1. Use the 5.0 branch
2. Revert the patch and go back to using jakarta-regexp
3. Introduce an o.a.coyote.http11.tomcat4 package and place a copy of 
Http11Processor in it that uses jakarta-regexp.


Pros/Cons
1. Would mean an awful lot of porting.
2. Quick but adds an unnecessary library to TC5 and leaves TC5 using two 
different regexp libs

3. Relatively quick but would need some build.xml tweaking for TC5

Unless anyone has a better idea, I'll crack on with 3 over the weekend.

On the Subversion front, I have TC4 building with jakarta-tomcat-connectors 
HEAD and will commit it once I have finished testing the various connector and 
JVM combinations (I don't plan to provide APR support in TC4). Once I have got 
this out of the way, I'll work with Henri on the test Watchdog migration.


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Migration to Subversion

2005-07-29 Thread Henri Yandell
On 7/27/05, Mark Thomas <[EMAIL PROTECTED]> wrote:
> All,
> 
> Following up on my offer to trial a Subversion migration using Watchdog, I
> started to think that it would be a good idea to have an idea of what we want
> our eventual Subversion layout to look like so we could target the Watchdog
> conversion to that layout and save rework at a later date.

Let me know whenever you want to migrate it into the test/live repo.
I'm doing lots of the SVN migrations nowadays.

> Once we have agreement on this, I'll put in a request for the Watchdog
> migration and also kick off a discussion with infra on how best to go about
> the overall migration. It might be the case that they do a default migration
> for each module and we (I am happy to do it) move the directories around
> afterwards.

Probably a mixture of both. Some of the migration bits will be easy,
but things like splitting the tags and branches automatically into
their own versioned directories would involve a post-migration script
and I or you can do them by hand.

> Finally, my intention with the migration of Watchdog is to see what, if any,
> performance differences there are between CVS and SVN. If there is no major
> performance hit moving to SVN, great, we can migrate the other modules
> whenever we choose. If there is a performance hit, we will have some hard
> evidence on which to base our decision about how to move forward.

We can start whenever you'd like.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Migration to Subversion

2005-07-27 Thread Yoav Shapira
Hi,


> Any and all comments appreciated. In particular:
> a. Should more 3.x.x versions should be included in 4 & 5 above?
> b. I have assumed that all releases before 5.5.x will use the 5.0 branch
> of the connectors. Is this assumption valid?

I don't think so.  Some Tomcat 3.x versions, for example, already use the
latest connectors that are also used by Tomcat 5.5.

> The build scripts are obviously going to need quite a lot of work but I
> think that will be the case however we do this migration.

Yes.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]