Re: ajp13 and tomcat restart - next (final) release + AJ13 PROPOSAL
Henri, 1) Moving op-recoverable -- I looked more carefully, and you're right -- the uploadmode flag is guarding against the situation I was thinking about. So it's fine the way it was. One (minor) naming note -- that flag gets set if there is more than 8K of request data, which can happen due to a file upload, but could also just happen normally (via a few big TEXTAREA's, for instance). So it's more large_request_mode, than upload_mode. Just to mention it... 2) Adding context/webapp load/unload. Great idea, but... One of the biggest problems with ajp13 right now is that there is no general way for TC to send a message to the Web Server. The commands you're adding would need to be sent from Tomcat to Apache, but that can only be done once Apache has forwarded a request to Tomcat and is waiting for a response (and a user servlet has its hands on the connection at that point). So I'm not sure how to add the feature you're looking for. If we could add that, we could also have Tomcat inform the web server of a general shutdown, so we could be more proactive about recycling TCP connections. -Dan GOMEZ Henri wrote: Looks about ready for more general testing. I like the new ajp13_operation. Two things: 1) l. 648 (op-recoverable = JK_FALSE). I set op-recoverable to JK_FALSE just after detected upload mode (dropped var) Find included the latest .c since I miss diff cmd under W2K rigth now. Where could we put code in Ajp13Interceptor which could be informed of context load/unload ? I'd like to add context/webapp load/unload la mod_warp :) will be new cmds in JK : LOADEDCONTEXT + WEBAPP STRING #define JK_AJP13_LOADED_CONTEXT (unsigned char)8 UNLOADEDCONTEXT + WEBAPP STRING #define JK_AJP13_UNLOADED_CONTEXT (unsigned char)9 Another proposal Strongest ACL (LOGIN + SECRET STRING + PROTOCOL SETS) #define JK_AJP13_LOGIN (unsigned char)10 Comments ? Name: jk_ajp13_worker.c jk_ajp13_worker.cType: unspecified type (application/octet-stream) Encoding: quoted-printable -- Dan Milstein // [EMAIL PROTECTED]
Re: ajp13 and tomcat restart - next (final) release
Henri (+ Larry), Looks about ready for more general testing. I like the new ajp13_operation. Two things: 1) l. 672 (op-recoverable = JK_FALSE). I believe that should be outside of the if statement (i.e. immediately after the connection_tcp_send_message). The whole thing becomes unrecoverable as soon as the 2nd buffer of data gets sent over to TC (at line 669), not just if there was an error during that send. 2) Larry -- what's your feeling about putting this in the next 3.3 milestone? It's certainly a very heavily requested feature, but I wouldn't want to swear to its correctness/robustness just yet. -Dan GOMEZ Henri wrote: Hi, You could find here the latest patch for ajp13/mod_jk when tc is restarted. Seems fine and ready to be commited. PS: I'll add timestamp in mod_jk logs but I'd like also to remove the datasync in log since it's just to much I/O consuming in debug mode (Ok ?) Name: jk_ajp13_worker.c.diff jk_ajp13_worker.c.diffType: unspecified type (application/octet-stream) Encoding: quoted-printable -- Dan Milstein // [EMAIL PROTECTED]
RE: ajp13 and tomcat restart - next (final) release
Henri (+ Larry), Looks about ready for more general testing. I like the new ajp13_operation. Two things: 1) l. 672 (op-recoverable = JK_FALSE). I'll check that. I believe that should be outside of the if statement (i.e. immediately after the connection_tcp_send_message). The whole thing becomes unrecoverable as soon as the 2nd buffer of data gets sent over to TC (at line 669), not just if there was an error during that send. Ok 2) Larry -- what's your feeling about putting this in the next 3.3 milestone? It's certainly a very heavily requested feature, but I wouldn't want to swear to its correctness/robustness just yet. I'd like to have it in m3. After all mx are also here to test fixes. All in one the previous code was seriously damaged. I strongly think we must commit it to have report on it and fixes before beta 1.
RE: ajp13 and tomcat restart - next (final) release
I don't anticipate a TC3.3 Milestone 3 this week. Maybe next week. I'm okay to commit it since there will some time before TC 3.3 Beta 1. We can review then whether it is working well enough to be kept for Beta 1. Larry -Original Message- From: Dan Milstein [mailto:[EMAIL PROTECTED]] Sent: Monday, March 26, 2001 4:05 PM To: [EMAIL PROTECTED] Subject: Re: ajp13 and tomcat restart - next (final) release Henri (+ Larry), Looks about ready for more general testing. I like the new ajp13_operation. Two things: 1) l. 672 (op-recoverable = JK_FALSE). I believe that should be outside of the if statement (i.e. immediately after the connection_tcp_send_message). The whole thing becomes unrecoverable as soon as the 2nd buffer of data gets sent over to TC (at line 669), not just if there was an error during that send. 2) Larry -- what's your feeling about putting this in the next 3.3 milestone? It's certainly a very heavily requested feature, but I wouldn't want to swear to its correctness/robustness just yet. -Dan GOMEZ Henri wrote: Hi, You could find here the latest patch for ajp13/mod_jk when tc is restarted. Seems fine and ready to be commited. PS: I'll add timestamp in mod_jk logs but I'd like also to remove the datasync in log since it's just to much I/O consuming in debug mode (Ok ?) -- -- Name: jk_ajp13_worker.c.diff jk_ajp13_worker.c.diffType: unspecified type (application/octet-stream) Encoding: quoted-printable -- Dan Milstein // [EMAIL PROTECTED]
RE: ajp13 and tomcat restart - next (final) release + AJ13 PROPOSAL
Looks about ready for more general testing. I like the new ajp13_operation. Two things: 1) l. 648 (op-recoverable = JK_FALSE). I set op-recoverable to JK_FALSE just after detected upload mode (dropped var) Find included the latest .c since I miss diff cmd under W2K rigth now. Where could we put code in Ajp13Interceptor which could be informed of context load/unload ? I'd like to add context/webapp load/unload la mod_warp :) will be new cmds in JK : LOADEDCONTEXT + WEBAPP STRING #define JK_AJP13_LOADED_CONTEXT (unsigned char)8 UNLOADEDCONTEXT + WEBAPP STRING #define JK_AJP13_UNLOADED_CONTEXT (unsigned char)9 Another proposal Strongest ACL (LOGIN + SECRET STRING + PROTOCOL SETS) #define JK_AJP13_LOGIN (unsigned char)10 Comments ? jk_ajp13_worker.c
