Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 The two patches look good to me. I also checked that a 32bit and 64bit
 build with those two patches are still working for me on a Windows 7 VM.

 I cherry-picked the tor-browser commit as
 `4b8a33af9610111d87dc5a901d06bcc20f1cc7b0`, and merged the tor-browser-
 build commit with `effde40cc5643080d45670d889a2fd81a6d39c67`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 How does it work for e.g. libcxx if it is not enabled globally?
 `llvm-mingw` seems to be made for UCRT explicitly, so it can follow clang-
 cl's defaults and avoid dependency on GCC. Talk to Martin about it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:33 cypherpunks]:
 > Is there any advantage of this approach vs. `SSPStrong` (via UCRT?)
 enabled by default in clang-cl?

 I don't know to be honest. I feel we are on the safer side following
 `llvm-mingw` here as that approach seems to be working. I'd be happy
 looking over a patch for your approach, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Is there any advantage of this approach vs. `SSPStrong` (via UCRT?)
 enabled by default in clang-cl?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW: I am not really sure how to test that for Windows stack canaries are
 embedded in the binaries but I can see that the linker is at least loading
 `libssp.a` for `___stack_chk_fail` during linking.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, GeorgKoppen201910, tbb-9.0, TorBrowserTeam201910 =>
 tbb-rbm, GeorgKoppen201910, tbb-9.0, TorBrowserTeam201910R
 * status:  new => needs_review
 * actualpoints:   => 1.5


Comment:

 Replying to [comment:27 gk]:
 > So, not adding `libssp.dll.a` solves actually both issues I had (the
 dynamically linking and the crashes). I might be tempted to pick this up
 to get it still into 9.0 or 9.5a1 if the former is too risky. :) (thanks
 again, Martin)

 Here we are. `bug_29013_v5` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_29013_v5=562fe8f1df0de8912c9eaf7ff8c3b4d989d4aa01)
 in my `tor-browser-build` repo and `bug_29013_v2`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_29013_v2=cb5ccc9e3b50e9d37a4c7a34a0c81418df38adfe)
 in my `tor-browser` one.

 The first patch is using our own `mingw-w64` which we build anyway and is
 just copying the .a libs over. The `tor-browser` patch essentially backs
 out the special treatment of mingw-w64-clang.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201910,  |  Actual Points:
  tbb-9.0, TorBrowserTeam201910  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, GeorgKoppen201908, tbb-9.0, TorBrowserTeam201910 =>
 tbb-rbm, GeorgKoppen201910, tbb-9.0, TorBrowserTeam201910


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 So, not adding `libssp.dll.a` solves actually both issues I had (the
 dynamically linking and the crashes). I might be tempted to pick this up
 to get it still into 9.0 or 9.5a1 if the former is too risky. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, GeorgKoppen201908, TorBrowserTeam201909, tbb-9.0
 -must-alpha => tbb-rbm, GeorgKoppen201908, TorBrowserTeam201909,
 tbb-9.0
 * parent:  #30322 =>


Comment:

 I might not get to that in time...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:23 gk]:
 > Replying to [comment:21 gk]:
 > > I guess what we can do, instead of building libssp with `build-
 libssp.sh` in a separate step, is to just use the static libraries we
 build for `mingw-w64` anyway.
 >
 > That approach is not working very well it seems. I used my `bug_29013`
 branch for `tor-browser` and `bug_29013_v2` for `tor-browser-build`.
 >
 > First of all for some reason we need the *.dll as well in the Browser
 dir (I thought ssp got statically linked in) but copying it over results
 in crashes both on 32bit and 64bit versions during start-up.
 >
 > More digging is needed here.

 Using the `llvm-mingw` approach results in the same problems. I guess I
 need to look closer in a debugger what's crashing here. Might help to
 solve #31546 first, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 o_0 and libcxx?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:21 gk]:
 > I guess what we can do, instead of building libssp with `build-
 libssp.sh` in a separate step, is to just use the static libraries we
 build for `mingw-w64` anyway.

 That approach is not working very well it seems. I used my `bug_29013`
 branch for `tor-browser` and `bug_29013_v2` for `tor-browser-build`.

 First of all for some reason we need the *.dll as well in the Browser dir
 (I thought ssp got statically linked in) but copying it over results in
 crashes both on 32bit and 64bit versions during start-up.

 More digging is needed here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 FWIW, starting from GCC 8, there is `--disable-libssp` configure time
 option, because "On many targets library support is provided by the C
 library instead."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I guess what we can do, instead of building libssp with `build-libssp.sh`
 in a separate step, is to just use the static libraries we build for
 `mingw-w64` anyway.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1492225

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201908,  |  Actual Points:
  TorBrowserTeam201909, tbb-9.0-must-alpha   |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, GeorgKoppen201908, TorBrowserTeam201909 => tbb-rbm,
 GeorgKoppen201908, TorBrowserTeam201909, tbb-9.0-must-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201908,   |  Actual Points:
  GeorgKoppen201908  |
Parent ID:  #30322   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #28238 => #30322


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

[Tor Bug Tracker & Wiki]

#29013: Provide stack smashing protection for mingw-clang builds
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201901,
 |  GeorgKoppen201901
Actual Points:   |  Parent ID:  #28238
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Currently with our mingw-w64/gcc builds we provide among other things
 stack smashing protection (SSP). We want to do the same for
 mingw-w64/clang builds.

 https://bugzilla.mozilla.org/show_bug.cgi?id=1511073 is the upstream bug.
 https://bugzilla.mozilla.org/show_bug.cgi?id=1503589#c19 has a good
 summary to get us started (pointing e.g. to https://github.com/mstorsjo
 /llvm-mingw/blob/master/build-libssp.sh)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs