Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  diagnostics, consider-backport-  |  Actual Points:  0.9
  after-042-stable, 042-should, android, macos,  |
  041-backport, BugSmashFund |
Parent ID:  #31614   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund
 =>
 diagnostics, consider-backport-after-042-stable, 042-should, android,
 macos, 041-backport, BugSmashFund
 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


Comment:

 This change caused issues for debugging using LeakSanitizer and
 AddressSanitizer in some contexts, so we should not backport it any
 further. See #33087 for more details.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund|
Parent ID:  #31614   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * parent:   => #31614


Comment:

 This change doesn't seem to make much of a difference, still thinking "no
 backport".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund|
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I'm leaning towards "no backport" on this ticket, unless we discover a
 specific bug.
 Leaving open, so we check again after 042-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund|
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Merged to 0.4.1; marking for further possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund|
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * keywords:
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund, asn-merge
 =>
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged to master! Moving to 041 for possible backports.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund, asn-  |
  merge  |
Parent ID:   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * parent:  #31571 =>


Comment:

 This ticket is independent of its parent,

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, consider-backport-if-   |  Actual Points:  0.9
  needed, consider-backport-after-042-stable,|
  042-should, android, macos, 040-backport-  |
  maybe, 041-backport-maybe, BugSmashFund, asn-  |
  merge  |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund
 =>
 diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe, BugSmashFund, asn-merge
 * status:  needs_review => merge_ready


Comment:

 This looks plausible to me.  Let's try it in 0.4.2!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, consider- |  Actual Points:  0.9
  backport-if-needed, consider-backport- |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => assigned
 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, consider- |  Actual Points:  0.9
  backport-if-needed, consider-backport- |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, consider- |  Actual Points:  0.9
  backport-if-needed, consider-backport- |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I also squashed the branch and did a backport to 0.4.0.
 (The backport to 0.3.5 was too complex.)

 Here is the PR to merge:
 * 0.4.0: https://github.com/torproject/tor/pull/1303

 The merge forward was clean.

 Here are the test branches for merging forwards:
 * ​​https://github.com/teor2345/tor/branches/all?query=bug31594_

 I don't think we should backport this fix, unless the bug is actually
 causing issues in older versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, consider- |  Actual Points:  0.9
  backport-if-needed, consider-backport- |
  after-042-stable, 042-should, android, macos,  |
  040-backport-maybe, 041-backport-maybe |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * keywords:
 BugSmash, diagnostics, 042-should, android, macos, 035-backport,
 040-backport, 041-backport
 =>
 BugSmash, diagnostics, consider-backport-if-needed, consider-backport-
 after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
 -backport-maybe
 * actualpoints:  0.7 => 0.9


Comment:

 I split #31614 and #31615 into their own PRs, the code is pretty
 independent. And the backport versions are different.

 I updated the PR with some fixups and a changes file:
 * fixups on master: https://github.com/torproject/tor/pull/1289

 I don't know if we need to do #31635.
 If we do, we should do it on master, after all these other branches merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.7
  android, macos, 035-backport, 040-backport,|
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 * changes files
 * split up PR into clean_up_backtrace_handler() / subsystem / log split
 * list of changes in PR
 * list of changes in child tickets

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.7
  android, macos, 035-backport, 040-backport,|
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * actualpoints:  0.5 => 0.7


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.5
  android, macos, 035-backport, 040-backport,|
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 diagnostics, 042-should, android, macos, 035-backport, 040-backport,
 041-backport
 =>
 BugSmash, diagnostics, 042-should, android, macos, 035-backport,
 040-backport, 041-backport


Comment:

 Fixing this bug also helps us smash other bugs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:6 teor]:
 > Replying to [comment:5 nickm]:
 > > I've left a couple of comments on the review. I've not reviewed the
 fsync commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.
 >
 > I didn't modify subsystem_list.c, I'll fix it when I revise the branch.
 > The subsystem levels vs subsystem_list.c order could be a unit test?
 > I'll see if I can make that happen.

 They are already a test on tor startup:
 https://trac.torproject.org/projects/tor/ticket/31634#comment:3

 So our CI won't pass if we mess this order up. (Any check that launches
 tor should fail, including keys, zero-length files, rebind, chutney and
 stem.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:5 nickm]:
 > I've left a couple of comments on the review. I've not reviewed the
 fsync commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.

 I didn't modify subsystem_list.c, I'll fix it when I revise the branch.
 The subsystem levels vs subsystem_list.c order could be a unit test?
 I'll see if I can make that happen.

 > Here are my current thoughts on your questions, but for all of these
 cases, I'll defer to your judgment.
 >
 > > when we clear the list of error fds, should we use -1 or 0 as the
 placeholder value?
 >
 > If the n_sigsafe_log_fds value is zero, it should not matter what the
 empty entries contain.
 >
 > That said, -1 is more commonly used in our code for "not a valid FD."
 (''That'' said, we already use 0 here, and it might be better to leave
 that unchanged in this branch.)

 I opened #31635 for follow up. I wonder if we should do it on this branch,
 so we don't end up with backport conflicts, if we decide to backport.

 > > are any of these bugs serious? Do they need a backport?
 >
 > IMO they don't currently warrant a backport, but they might warrant a
 backport some day.  They strike me as the kind of issue that we might
 change our mind about and really wish we had backported at some point in
 the future.  On the other hand, they also strike me as subtle enough to
 warrant extensive testing before we think of a backport.

 I'll do them on 0.3.5, mark them as "test in 0.4.2-stable before
 backport", and mark them as a "maybe-not" backport.

 > > should I split this PR up into multiple PRs?
 >
 > I don't think so, unless you want to. Maybe. (At first I thought that if
 we are considering a backport, we might want to backport only part of this
 branch.  But on the other hand, if we backport only part of this branch,
 we risk backporting something unstable that has not had testing.)

 I think I want a clean_up_backtrace_handler() / subsystem / log split.
 These sets of changes are pretty independent, so backporting them
 independently should be ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I've left a couple of comments on the review. I've not reviewed the fsync
 commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.

 Here are my current thoughts on your questions, but for all of these
 cases, I'll defer to your judgment.

 > when we clear the list of error fds, should we use -1 or 0 as the
 placeholder value?

 If the n_sigsafe_log_fds value is zero, it should not matter what the
 empty entries contain.

 That said, -1 is more commonly used in our code for "not a valid FD."
 (''That'' said, we already use 0 here, and it might be better to leave
 that unchanged in this branch.)

 > are any of these bugs serious? Do they need a backport?

 IMO they don't currently warrant a backport, but they might warrant a
 backport some day.  They strike me as the kind of issue that we might
 change our mind about and really wish we had backported at some point in
 the future.  On the other hand, they also strike me as subtle enough to
 warrant extensive testing before we think of a backport.

 > should I split this PR up into multiple PRs?

 I don't think so, unless you want to. Maybe. (At first I thought that if
 we are considering a backport, we might want to backport only part of this
 branch.  But on the other hand, if we backport only part of this branch,
 we risk backporting something unstable that has not had testing.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 I'll review everything but the fsync commit, and try to answer your
 questions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:2 teor]:
 > Hmm, it looks like I forgot a header that Windows needs. I'll fix that
 when I fix everything else.

 fsync() doesn't do what we want here: I should delete most of the last
 commit, and just keep one of the comment changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Hmm, it looks like I forgot a header that Windows needs. I'll fix that
 when I fix everything else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, android,|  Actual Points:  0.5
  macos, 035-backport, 040-backport, |
  041-backport   |
Parent ID:  #31571   | Points:  0.3
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.5


Comment:

 There were a lot of really tricky related bugs here. And I'm not sure if I
 got them right. So I made a separate child ticket for each one.

 Here is a draft PR that I think fixes all those bugs:
 * master: https://github.com/torproject/tor/pull/1289

 Here's what I still need to do:
 * changes files

 Here's what I don't know:
 * when we clear the list of error fds, should we use -1 or 0 as the
 placeholder value?
 * are any of these bugs serious? Do they need a backport?
 * should I split this PR up into multiple PRs?
   * the subsys changes are independent
   * the backtrace changes are independent
   * the torerr changes need to be merged before the log changes

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs