Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
+--
 Reporter:  weasel  |  Owner:  cypherpunks
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:  Tor: 0.2.8.5-rc
 Severity:  Normal  | Resolution:
 Keywords:  lorax, integration  |  Actual Points:
Parent ID:  | Points:  .1
 Reviewer:  nickm   |Sponsor:
+--
Changes (by teor):

 * keywords:  easy, lorax, integration => lorax, integration


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 |  cypherpunks
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-15   |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by arma):

 The poor cypherpunks who has been trying to help here for 8 months -- and
 the ticket still has the 'easy' tag? :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 |  cypherpunks
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-14   |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 |  cypherpunks
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-14   |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 I think it would be much better to stop using file_status() whenever we
 don't absolutely have to do so.  That's for a couple of reasons:

* The st_size field is not reliable on S_IFCHR devices, so anything
 that distinguishes between FN_EMPTY and FN_FILE will get the wrong answer.
* Generally, when we want to see whether we can read a file, it's
 better to just try to read the file and see what happens.  To do otherwise
 invites race conditions.  The only time when it makes sense to have a
 separate "does this file exist" check is when we *aren't* going to open
 the file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
--+
 Reporter:  weasel|  Owner:  cypherpunks
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.5-rc
 Severity:  Normal| Resolution:
 Keywords:  easy, lorax, integration  |  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 Attached a fixup patch which changes the header to the expected format,
 adds a category, reflows the text, adds the ticket number in the expected
 format and adds the Tor version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
--+
 Reporter:  weasel|  Owner:  cypherpunks
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.5-rc
 Severity:  Normal| Resolution:
 Keywords:  easy, lorax, integration  |  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 The related code was introduced in commit
 92acbe12bc9512100b9282d7e9d61fe86b5a60bb which is Tor version 0.0.2pre13.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
--+
 Reporter:  weasel|  Owner:  cypherpunks
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.5-rc
 Severity:  Normal| Resolution:
 Keywords:  easy, lorax, integration  |  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 The changes file is not in the expected format. This can be verified with
 `make check-changes`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
--+
 Reporter:  weasel|  Owner:  cypherpunks
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.5-rc
 Severity:  Normal| Resolution:
 Keywords:  easy, lorax, integration  |  Actual Points:
Parent ID:| Points:  .1
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 |  cypherpunks
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-10   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 |  cypherpunks
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-10   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:   => cypherpunks
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-10   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I've reviewed this patch, and it seems simple enough, and trivially
 correct.
 And it does solve the problem in general for almost all files read by tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-10   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 Hmmm, thought about this some more.

 The patch here does not whitelist /dev/null specifically. Instead, it
 makes `file_status()` accept any character device and return it as "a non-
 empty regular file, or a FIFO on unix-like systems". We use
 `file_status()` in various places in the codebase, like when
 opening/saving the torrc, or state files, or crypto keys.

 I wonder if there are any operations that we can't do with a character
 device file that are required for the features above (like seek, or
 unlink, or whatever).

 I did some tests by setting my state file and my consensus file to be a
 character device, and everything worked fine because Tor just replaced
 them. I'm just wondering if there is some crazy Unix thing that might bite
 us here. But I guess this can only occur if our users specify a character
 device file themselves, so that's OK.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
-+-
 Reporter:  weasel   |  Owner:
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  easy, lorax, integration, review-|  Actual Points:
  group-10   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 The fix is correct here.

 However, it's missing a changes file. cypherpunks would you like to
 provide one? See here for info:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n56

 And also ideally provide a proper git branch, instead of a patches file?

 Apart from that all is good here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
+
 Reporter:  weasel  |  Owner:
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.2.8.5-rc
 Severity:  Normal  | Resolution:
 Keywords:  easy lorax integration  |  Actual Points:
Parent ID:  | Points:  .1
 Reviewer:  |Sponsor:
+
Changes (by cypherpunks):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
+
 Reporter:  weasel  |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.2.8.5-rc
 Severity:  Normal  | Resolution:
 Keywords:  easy lorax integration  |  Actual Points:
Parent ID:  | Points:  .1
 Reviewer:  |Sponsor:
+

Comment (by cypherpunks):

 It looks like this was actually failing because file_status does not
 currently support character special devices. The quickest fix was to just
 add support for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19661 [Core Tor/Tor]: tor refuses to use /dev/null as a config file

[Tor Bug Tracker & Wiki]

#19661: tor refuses to use /dev/null as a config file
+
 Reporter:  weasel  |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.2.8.5-rc
 Severity:  Normal  | Resolution:
 Keywords:  easy lorax integration  |  Actual Points:
Parent ID:  | Points:  .1
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * keywords:   => easy lorax integration
 * points:   => .1
 * milestone:   => Tor: 0.3.0.x-final


Comment:

 To fix this, switch the function that loads the torrc from
 read_file_to_str to use read_file_to_str_until_eof instead.  A patch would
 be welcome.  This could be a good intro task.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs