Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  implemented
  fix|  Actual Points:
Parent ID:   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Both merged to 'master' and/or squashed as appropriate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  teor |Sponsor:
-+-
Changes (by isis):

 * reviewer:  isis, teor => teor


Comment:

 Replying to [comment:7 teor]:
 > I'm not sure if isis also wants to review this code.

 Nope, your review looks good! Thanks, teor! I'll take review on #25818 in
 place of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  isis, teor   |Sponsor:
-+-

Comment (by nickm):

 Also see branch `bug24378_spec` in my torspec repo for the requested dir-
 spec changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  isis, teor   |Sponsor:
-+-

Comment (by nickm):

 Added some fixup/squash commits to resolve your concerns above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  isis, teor   |Sponsor:
-+-
Changes (by teor):

 * reviewer:  isis => isis, teor


Comment:

 Looks good to me, I left a review on github with two nitpick changes:
 * fix some missing words in a commit message
 * please don't remove a unit test for a far future consensus method

 We will also need a dir-spec change like this one:
 {{{
 [ As of 0.2.6.1-alpha, authorities no longer advertise or negotiate
   any consensus methods lower than 13. ]
 }}}

 I'm not sure if isis also wants to review this code.

 Let's also make sure someone has run "make test-network-all" on this
 branch on an IPv6/mixed system, with tor-stable linked to 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:  isis |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 See my branch `remove_old_consensus_methods_2018`, available for review at
 https://github.com/torproject/tor/pull/45

 To note:
   * There are a few places where I changed `if (x) {` to `{` because I
 felt that the block structure kept the code more organized.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop290, 034-triage-20180328, fast-  |  Actual Points:
  fix|
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  (none) => nickm
 * keywords:  needs-proposal, 034-triage-20180328, 034-removed-20180328 =>
 prop290, 034-triage-20180328, fast-fix
 * points:  2 => .5
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24378 [Core Tor/Tor]: Prune the list of supported consensus methods

[Tor Bug Tracker & Wiki]

#24378: Prune the list of supported consensus methods
+
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  needs-proposal  |  Actual Points:
Parent ID:  | Points:  2
 Reviewer:  |Sponsor:
+

Comment (by teor):

 See #10163, for how we did this last time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs