Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

[Tor Bug Tracker & Wiki]

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-+
 Reporter:  irl  |  Owner:  irl
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Alright, as discussed at today's team meeting, merged and deployed. Saving
 the 4.x upgrade for later. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

[Tor Bug Tracker & Wiki]

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Replying to [comment:3 karsten]:
 >  - Is there a way to redefine this function in our own JavaScript and
 have it override the one in Bootstrap? Sorry, if this is too naive.

 Not easily, as this is a function that is called by the tooltip library,
 so we would have to modify the tooltip library or do this for every view
 where we might use tooltips.

 >  - Should we downgrade to 3.3.5? What possible downsides does that have?

 Looking at the changelogs there are quite a few bug fixes but I've not
 checked whether or not they would affect us.

 >  - Should we upgrade to 4.x? What can possibly go wrong?

 There's likely to be a lot of API issues. I've already updated Relay
 Search from Bootstrap 2.0.0 to 3.3.7, it's going to be the same amount of
 work again to go to 4.x so I'd really rather not do that unless we have
 someone do a new 4.x design.

 > And if neither of these makes sense and we decide we need to make this
 change to the minimized JavaScript file, is there anything that we link
 where others have done the same thing before?

 https://stackoverflow.com/questions/42315216/bootstrap-tooltip-wrong-
 position-on-svg-element-when-page-is-scrolled-down#44802960

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

[Tor Bug Tracker & Wiki]

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Hmmm. Can we first evaluate possible alternatives before editing libraries
 ourselves? For example:
  - Is there a way to redefine this function in our own JavaScript and have
 it override the one in Bootstrap? Sorry, if this is too naive.
  - Should we downgrade to 3.3.5? What possible downsides does that have?
  - Should we upgrade to 4.x? What can possibly go wrong?

 And if neither of these makes sense and we decide we need to make this
 change to the minimized JavaScript file, is there anything that we link
 where others have done the same thing before?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

[Tor Bug Tracker & Wiki]

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * cc: metrics-team (added)
 * status:  accepted => needs_review


Comment:

 Please review my branch [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/25254|task/25254]].

 Where the getPosition function is defined, the innards of that function
 are replaced with the minimised innards of the getPosition function from
 the 3.3.5 release. There are no references to minimised variables that
 were not defined in the function (at least as far as I could follow it).

 I've tested this out with Relay Search and it works as expected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

[Tor Bug Tracker & Wiki]

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * owner:  metrics-team => irl
 * status:  new => accepted


Comment:

 Looking at this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs