Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thank you so much for the immediate feedback, teor! Could you please help me to review the requirements (TODO list) below: * %include /etc/torrc.d means parsing all the files in the directory * implement %include /etc/torrc.d/*.extension syntax *

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

> On 6 Feb 2018, at 05:37, iry wrote: > > … > > I went through all Tor packages listed here: > https://trac.torproject.org/projects/tor/wiki/doc/packages and no > distros shipped a torrc with %include line enabled. > > I know Whonix will not use torrc.d before next stable

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi teor! > Could you please look at existing .d folders of any other projects > tell me what you think? Perhaps discuss this with Tor Project. > [...] From my quick search, it appears that the Debian feature > request is still open, and no other

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

On 5 Feb 2018, at 08:09, iry wrote: >> Since this is a breaking change, we might want to check if any >> distribution has adopted another naming scheme, and avoid breaking >> that naming schem > I agree. I will wait for a little bit before implementing it so that > we may get

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > To be more precise, most tools accept files ending in ".conf". We > might want tor to accept ".conf" for consistency. > > I suggest we also accept files called "torrc", or ending in > ".torrc". This should probably also include files called

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

> On 4 Feb 2018, at 15:04, iry wrote: > >>> Therefore, may I propose to let Tor parse only the files whose >>> name ends with .torrc ? >> >> Yes, this is standard behaviour among many tools. To be more precise, most tools accept files ending in ".conf". We might want tor to

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> Therefore, may I propose to let Tor parse only the files whose >> name ends with .torrc ? > > Yes, this is standard behaviour among many tools. > >> Or maybe even only parse number_filename.torrc for better >> consistency and for more clear

Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory

> On 4 Feb 2018, at 09:37, iry wrote: > > In best case users will just be frustrated because Tor does not work > as expected and in worst case this could be dangerous. This could be a > severe problem especially because of the following reasons: > 1. filename.torrc~

[tor-dev] Proposal: only parse .torrc files in torrc.d directory

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Dear Tor Developers, I have been testing and using the torrc.d feature for a while, and here is a potential improvement we may make. Currently, when using a torrc.d directory, for example: > %include /etc/torrc.d/ Every file in the directory will