[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-04-12 Thread Pat McGowan
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1535480 Title: Icon

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-03-19 Thread Timo Jyrinki
** Also affects: canonical-devices-system-image Importance: Undecided Status: New ** Changed in: canonical-devices-system-image Assignee: (unassigned) => Zoltan Balogh (bzoltan) ** Changed in: canonical-devices-system-image Status: New => Fix Committed ** Changed in:

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-03-09 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1872+16.04.20160308-0ubuntu1 --- ubuntu-ui-toolkit (1.3.1872+16.04.20160308-0ubuntu1) xenial; urgency=medium [ Timo Jyrinki ] * Fix gles unit test skipping. * Add s390x to the unit test skipping architectures * UITK

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-03 Thread Zsombor Egri
See comment #2. And let me come with an example Qt screwed up from one version to the other. MultiPointTouchArea. The default component was handling only touch events, not taking care of the Mouse events. In order to handle mouse event you had to put a MouseArea inside of it, and then one handled

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-03 Thread Andrea Bernabei
Of course it is a behavioural break, I was just wondering whether it has many drawbacks, or it was actually worth it because of the improvements in smoothness it could bring. If there's an issue with the Scrollbar, that's a separate bug ;) but yes, I get your point that the same may happen with

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-02 Thread Andrea Bernabei
Icon is our component, not Qt's, so we have the power to change the default values. Can you please argue why sync should be a default instead of async? I'm just looking for a valid point here, otherwise we just get smoothness penalty for no real reason. -- You received this bug notification

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Launchpad Bug Tracker
** Branch linked: lp:~zsombi/ubuntu-ui-toolkit/icon_async -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1535480 Title: Icon image loading is synchronous

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Zsombor Egri
The default behaviour will be true, so backwards compatibility is kept. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1535480 Title: Icon image loading is

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Zsombor Egri
Yes, agree on this. However, to avoid the other parties, who want to load synchronously, the best will be to expose the property to the Icon API. ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New => Confirmed ** Changed in: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided => High

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Andrea Bernabei
does it make sense to keep backward compatibility in this case? it sounds more like just a performance issue here...or is there any strong usecase where you absolutely need the Image to load syncronously? -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Zsombor Egri
Andrea, whenever you add a property you should not change the previous behaviour of the component, right? So yes, it has to be kept as Image.asynchronous default is. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Andrea Bernabei
it depends if the previous behaviour was a bug. And this case, I could argue it is...unless we have strong reasons for having it sync by default -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu.

[Touch-packages] [Bug 1535480] Re: Icon image loading is synchronous

2016-02-01 Thread Zsombor Egri
No, the previous behaviour wasn't a bug. Neither Image's default behaviour is a bug. Therefore we must obey the default behaviour and default it to whatever Image's default is, which is synchronous. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages,