[Touch-packages] [Bug 1277227] Re: LabelVisual.isInsideOverlay() performance issue
Unfortunately there's no better way to detect in what context the label is used, is it in a popover or not. Perhaps a better solution would be to get subtheming to solve this. The new ListItem brings more flexibility and this and almost all components from the Ubuntu.Components.ListItems module will be deprecated, so maintaining this component would be impossible. ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Confirmed = Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1277227 Title: LabelVisual.isInsideOverlay() performance issue Status in ubuntu-ui-toolkit package in Ubuntu: Won't Fix Bug description: I ran my app (lp:ureadit) in the QtCreator analyzer and the following code accounted for 30% of the rendering time: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/trunk/view/head:/modules/Ubuntu/Components/ListItems/LabelVisual.qml#L28 // FIXME: very ugly hack to detect whether the list item is inside a Popover property bool overlay: isInsideOverlay(label) function isInsideOverlay(item) { if (!item.parent) return false; return item.parent.hasOwnProperty(pointerTarget) || label.isInsideOverlay(item.parent) } Location TypeTime in Percent Total Time Calls Mean Time Median Time Longest TimeShortest Time Details LabelVisual.qml:27Binding 8.10 % 125.849 ms 152 827.955 µs 894.083 µs 2.305 ms466.326 µs property bool overlay: isInsideOverlay(label) Location Time in Percent Total Time Self Time in PercentSelf Time Details LabelVisual.qml:28158.82 %885.349 ms 27.91 % 88.852 ms isInsideOverlay To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1277227/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1277227] Re: LabelVisual.isInsideOverlay() performance issue
** No longer affects: ubuntu-ui-toolkit -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1277227 Title: LabelVisual.isInsideOverlay() performance issue Status in ubuntu-ui-toolkit package in Ubuntu: Confirmed Bug description: I ran my app (lp:ureadit) in the QtCreator analyzer and the following code accounted for 30% of the rendering time: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/trunk/view/head:/modules/Ubuntu/Components/ListItems/LabelVisual.qml#L28 // FIXME: very ugly hack to detect whether the list item is inside a Popover property bool overlay: isInsideOverlay(label) function isInsideOverlay(item) { if (!item.parent) return false; return item.parent.hasOwnProperty(pointerTarget) || label.isInsideOverlay(item.parent) } Location TypeTime in Percent Total Time Calls Mean Time Median Time Longest TimeShortest Time Details LabelVisual.qml:27Binding 8.10 % 125.849 ms 152 827.955 µs 894.083 µs 2.305 ms466.326 µs property bool overlay: isInsideOverlay(label) Location Time in Percent Total Time Self Time in PercentSelf Time Details LabelVisual.qml:28158.82 %885.349 ms 27.91 % 88.852 ms isInsideOverlay To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1277227/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1277227] Re: LabelVisual.isInsideOverlay() performance issue
** Also affects: ubuntu-ui-toolkit Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1277227 Title: LabelVisual.isInsideOverlay() performance issue Status in Ubuntu UI Toolkit: New Status in ubuntu-ui-toolkit package in Ubuntu: Confirmed Bug description: I ran my app (lp:ureadit) in the QtCreator analyzer and the following code accounted for 30% of the rendering time: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/trunk/view/head:/modules/Ubuntu/Components/ListItems/LabelVisual.qml#L28 // FIXME: very ugly hack to detect whether the list item is inside a Popover property bool overlay: isInsideOverlay(label) function isInsideOverlay(item) { if (!item.parent) return false; return item.parent.hasOwnProperty(pointerTarget) || label.isInsideOverlay(item.parent) } Location TypeTime in Percent Total Time Calls Mean Time Median Time Longest TimeShortest Time Details LabelVisual.qml:27Binding 8.10 % 125.849 ms 152 827.955 µs 894.083 µs 2.305 ms466.326 µs property bool overlay: isInsideOverlay(label) Location Time in Percent Total Time Self Time in PercentSelf Time Details LabelVisual.qml:28158.82 %885.349 ms 27.91 % 88.852 ms isInsideOverlay To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1277227/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1277227] Re: LabelVisual.isInsideOverlay() performance issue
** Changed in: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided = Critical ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1277227 Title: LabelVisual.isInsideOverlay() performance issue Status in Ubuntu UI Toolkit: Confirmed Status in “ubuntu-ui-toolkit” package in Ubuntu: Confirmed Bug description: I ran my app (lp:ureadit) in the QtCreator analyzer and the following code accounted for 30% of the rendering time: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/trunk/view/head:/modules/Ubuntu/Components/ListItems/LabelVisual.qml#L28 // FIXME: very ugly hack to detect whether the list item is inside a Popover property bool overlay: isInsideOverlay(label) function isInsideOverlay(item) { if (!item.parent) return false; return item.parent.hasOwnProperty(pointerTarget) || label.isInsideOverlay(item.parent) } Location TypeTime in Percent Total Time Calls Mean Time Median Time Longest TimeShortest Time Details LabelVisual.qml:27Binding 8.10 % 125.849 ms 152 827.955 µs 894.083 µs 2.305 ms466.326 µs property bool overlay: isInsideOverlay(label) Location Time in Percent Total Time Self Time in PercentSelf Time Details LabelVisual.qml:28158.82 %885.349 ms 27.91 % 88.852 ms isInsideOverlay To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1277227/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1277227] Re: LabelVisual.isInsideOverlay() performance issue
** No longer affects: ubuntu-ui-toolkit -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in Ubuntu. https://bugs.launchpad.net/bugs/1277227 Title: LabelVisual.isInsideOverlay() performance issue Status in “ubuntu-ui-toolkit” package in Ubuntu: Confirmed Bug description: I ran my app (lp:ureadit) in the QtCreator analyzer and the following code accounted for 30% of the rendering time: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui- toolkit/trunk/view/head:/modules/Ubuntu/Components/ListItems/LabelVisual.qml#L28 // FIXME: very ugly hack to detect whether the list item is inside a Popover property bool overlay: isInsideOverlay(label) function isInsideOverlay(item) { if (!item.parent) return false; return item.parent.hasOwnProperty(pointerTarget) || label.isInsideOverlay(item.parent) } Location TypeTime in Percent Total Time Calls Mean Time Median Time Longest TimeShortest Time Details LabelVisual.qml:27Binding 8.10 % 125.849 ms 152 827.955 µs 894.083 µs 2.305 ms466.326 µs property bool overlay: isInsideOverlay(label) Location Time in Percent Total Time Self Time in PercentSelf Time Details LabelVisual.qml:28158.82 %885.349 ms 27.91 % 88.852 ms isInsideOverlay To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1277227/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp