[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-18 Thread Robie Basak
Could we have a justification for why this is important for SRU, please? As written, the Impact statement describes a bug, but doesn't present any explanation of why it is important for Ubuntu to fix it in its stable releases. If it is just that the output might be wrong and we'd like it to be

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-18 Thread Robie Basak
(unsubscribing ~ubuntu-sponsors as given my previous comment there is now nothing remaining to sponsor) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu. https://bugs.launchpad.net/bugs/2035061 Title:

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-18 Thread Steve Langasek
marking resolved for the devel series, per description. ** Changed in: procps (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu.

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-18 Thread Robert Malz
Hi Andreas, Regarding output, non-human-readable output of uptime is not modified. I had to modify code flow a little bit to not change upminutes and uphours after initial calculation in case of "-p", thus I hid it under if(!human_readable). Code flow for !human_readable should stay exactly as

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-15 Thread Andreas Hasenack
Time calculations can be so tricky! The patch is also changing the non-human-readable case (without -p), if I understood it correctly. I think this also needs to be tested. I think it would be beneficial to include the upcoming fix for the other corner case you found, when uptime is exactly 60s,

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-15 Thread Robert Malz
** Description changed: - [IMPACT] + [ Impact ] - uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool. - Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749. + uptime

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-15 Thread Robert Malz
Added new debdiffs, updated bug description. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu. https://bugs.launchpad.net/bugs/2035061 Title: uptime -p reports incorrect output after 52 weeks Status in

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-15 Thread Robert Malz
** Patch added: "focal debdiff" https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5701220/+files/uptime_focal.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu.

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-14 Thread Robert Malz
History is a little bit tricky, patch hhttps://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749 (applied in current debdiff) was merged to the master branch but probably was lost while repository was moving to a "newlib". Last released version

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-12 Thread Dan Bungert
Hi Robert, thanks for the update to the description. I would like to see two things 1. (Like Paride, I don't have a SRU hat to wear) While this updated description elaborates on what has changed, it doesn't really go into the "what can go wrong" territory. This is an important field for SRU

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-12 Thread Robert Malz
** Description changed: [IMPACT] uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool. Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749. Latest procps

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-12 Thread Robert Malz
Thanks Paride for feedback. 1. Old calculation is a little bit wrong. It assumes that we have 52 weeks in the year - which is 60*60*24*7*52 -> 31449600 seconds (31449600 - 1) will result in 51 weeks, 31449600 will result in 0 weeks (it is assuming year has passed). However year calculation is

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-12 Thread Paride Legovini
Hello, I had a look at the debdiffs and they look good (clean upstream cherry-picks). I think the packages are ready for sponsoring, but before doing so I have a couple of questions. 1. The issue only happens *exactly* after 52 weeks, or something like that, am I right? as I have systems that

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-11 Thread Ubuntu Foundations Team Bug Bot
The attachment "uptime_jammy.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-11 Thread Dariusz Gadomski
** Tags added: se se-sponsor-dgadomski -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu. https://bugs.launchpad.net/bugs/2035061 Title: uptime -p reports incorrect output after 52 weeks Status in procps

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-11 Thread Robert Malz
debdiff with backport for focal ** Patch added: "uptime_focal.debdiff" https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699853/+files/uptime_focal.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-11 Thread Robert Malz
debdiff with backport for jammy ** Patch added: "uptime_jammy.debdiff" https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699852/+files/uptime_jammy.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 2035061] Re: uptime -p reports incorrect output after 52 weeks

2023-09-11 Thread Robert Malz
** Changed in: procps (Ubuntu) Assignee: (unassigned) => Robert Malz (rmalz) ** Also affects: procps (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: procps (Ubuntu Jammy) Importance: Undecided Status: New ** Changed in: procps (Ubuntu Focal)