Re: [Toybox] Question about ping.

2014-10-12 Thread Рысь
13 октября 2014 г. 13:53:48 KRAT, Rob Landley пишет: >On 10/13/14 00:29, Рысь wrote: >> 13 октября 2014 г. 8:51:13 KRAT, Rob Landley пишет: >>> My question is: should I _also_ include the old raw socket support >(as >>> a >>> fallback? With a config option?) or is it good enough to just have >t

Re: [Toybox] Question about ping.

2014-10-12 Thread Rob Landley
On 10/13/14 00:29, Рысь wrote: > 13 октября 2014 г. 8:51:13 KRAT, Rob Landley пишет: >> My question is: should I _also_ include the old raw socket support (as >> a >> fallback? With a config option?) or is it good enough to just have this >> and not support ping on 2.6 kernels? (It's easy enough t

Re: [Toybox] Question about ping.

2014-10-12 Thread Рысь
13 октября 2014 г. 8:51:13 KRAT, Rob Landley пишет: >My question is: should I _also_ include the old raw socket support (as >a >fallback? With a config option?) or is it good enough to just have this >and not support ping on 2.6 kernels? (It's easy enough to make it >compile even when it does wo

Re: [Toybox] Question about ping.

2014-10-12 Thread Isaac Dunham
On Sun, Oct 12, 2014 at 07:51:13PM -0500, Rob Landley wrote: > I've been working on ping (for far too long) and I finally tracked down > the "ping without root access" patch I remembered seeing a few years ago. > > It's https://lwn.net/Articles/420799/ and example code (well, diff > switching to u

Re: [Toybox] [Patches] - Some more static analysis fixes

2014-10-12 Thread Ashwini Sharma
Hi Rob, --- cp.c.patch: Why this change? -if (CFG_CP_MV && toys.which->name[0] == 'm') rc = rename(src, TT.destname); +if (CFG_CP_MV && toys.which->name[0] == 'm' && (toys.optflags & FLAG_f)) + rc = rename(src, TT.destname); $ strace mv umount umount.old 2>&1 | grep rename rename("

[Toybox] Question about ping.

2014-10-12 Thread Rob Landley
I've been working on ping (for far too long) and I finally tracked down the "ping without root access" patch I remembered seeing a few years ago. It's https://lwn.net/Articles/420799/ and example code (well, diff switching to use this) is at http://openwall.info/wiki/_media/segoon/iputils-ss020927

[Toybox] Architectural issue raised by kill.c fix.

2014-10-12 Thread Rob Landley
I was going through more of the static analysis fixes when I noticed that kill -l won't work if killall5 isn't enabled, because most of the command is in killall5's flag context (and flags are zeroed if the command is switched off). Which also means kill doesn't work right when built with scripts/