Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread Rob Landley
On 10/17/2018 04:51 PM, enh wrote: > i think what you have is broken even for static builds, since you have > an ODR violation from the missing `static inline` on your no-op > function: > > ld.lld: error: duplicate symbol: __android_log_write defined at portability.h:282

[Toybox] oh, the irony...

2018-10-17 Thread enh
$ ./toybox su --help toybox: Not root (see "toybox --help") not sure what the fix is there though. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

[Toybox] [PATCH] Some more --help consistency.

2018-10-17 Thread enh
>From eyeballing the output of for i in `./toybox | tr " " "\n"` ; do ./toybox $i --help ; done | \ grep '^-' | grep -v "\t" --- toys/net/microcom.c| 4 ++-- toys/net/netstat.c | 22 +++--- toys/net/ping.c| 22 +++--- toys/other/blockdev.c

[Toybox] [PATCH] main.c: don't assume anything starting with -- is --long.

2018-10-17 Thread enh
Test: `./toybox --oops` correctly shows help now --- main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/main.c b/main.c index 6f8490f..46f571e 100644 --- a/main.c +++ b/main.c @@ -202,9 +202,11 @@ void toybox_main(void) int fl = toy_list[i].flags; if (fl

[Toybox] --help annoyance

2018-10-17 Thread enh
i wanted to check that the Android scheduler policy output wasn't broken by recent changes, but i can't remember what the -O option is called... # ps -A -O ps: Missing argument to -O (see "ps --help") fair enough. (though maybe we should have a special case for things that take an option and

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread enh
On Wed, Oct 17, 2018 at 2:05 PM Rob Landley wrote: > > On 10/10/2018 11:43 AM, enh wrote: > >> Then it works with glibc and musl, but _not_ with the android NDKr18: > > > > yeah, hard to know what to do with something non-standard like that, > > but if we're in a world where some have one and

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread Rob Landley
On 10/10/2018 11:43 AM, enh wrote: >> Then it works with glibc and musl, but _not_ with the android NDKr18: > > yeah, hard to know what to do with something non-standard like that, > but if we're in a world where some have one and others have the other, > we usually end up having both. Indeed.

Re: [Toybox] NDK r18 build.

2018-10-17 Thread Rob Landley
On 10/08/2018 01:52 PM, enh wrote: > On Sun, Oct 7, 2018 at 6:13 PM Rob Landley wrote: >> >> I downloaded the release 18 NDK and installed it: >> >> sudo build/tools/make_standalone_toolchain.py --arch x86_64 --api 28 \ >> --install-dir /opt/android/x86_64 >> >> Then in order to build: