[Toybox] IFCONFIG doubt

Hello enh, Android's original ifconfig was only showing the ip address for interface and flags. Otherwise ifconfig on other platforms gives out lot of other details. Does it do so on Android? I interested in how to get the MAC address at the ndk level. As earlier i saw that SIOCGIFHWADDR is

[Toybox] sed {N;N;} cmd test failure

Hi Rob, While testing thru busybox sed tests, it failed at this test case. # first three lines are deleted; 4th line is matched and printed by 2,3 and by 4 ranges testing sed with N skipping lines past ranges on next cmds \ sed -n '1{N;N;d};1p;2,3p;3p;4p' \ 4\n4\n 1\n2\n3\n4\n My

Re: [Toybox] What does the du.c patch do?

Hi Rob, My patch was +// is recursive tree +static int is_recursive_loop(struct dirtree *node) +{ + struct dirtree *tmp = node; + + while ((tmp = tmp-parent)) { +if ((tmp-st.st_ino == node-st.st_ino) +(tmp-st.st_dev == node-st.st_dev)) + return 1; + } + return 0; +} + //

[Toybox] [PATCH] New toys TR CRONTAB

Hi Rob, list Attached are new toys TR and CRONTAB. Any inputs welcome. * tr.c*: It translate, squezze and delete characters. Supported classes are alpha, alnum, digit, lower, upper space, blank, puct, cntrl and xdigit. *crontab.c*: Companion of crond. It

Re: [Toybox] bunzip2 - bzcat as bunzip2

, Ashwini Sharma wrote: Hi Rob, List, I was looking into 'bzcat' code. Can't this be used as bunzip2 or as __base__ to bunzip2, as I am interested in bunzip2 utility. At a glance it looked to me that it can be used, please share your opinion. Yes, it can. The only reason I haven't

Re: [Toybox] [Patches] - Some more static analysis fixes

Hi Rob, --- cp.c.patch: Why this change? -if (CFG_CP_MV toys.which-name[0] == 'm') rc = rename(src, TT.destname); +if (CFG_CP_MV toys.which-name[0] == 'm' (toys.optflags FLAG_f)) + rc = rename(src, TT.destname); $ strace mv umount umount.old 21 | grep rename rename(umount,

[Toybox] [Patches] - Issue fixes

Hi Rob, List, While verifying toybox on one of our products, came across few issues. Attached are the patches to those. 1. cp.c : For __mv__ with __-f__ and __-i__ user was prompted. 2. date.c: added support for additional date format parsing, a SIGSEGV for setdate, output in __-u__. 3.

[Toybox] [Patches] - Some more static analysis fixes

Hi Rob, List, Attached are few more static analysis fixes. This includes issues like resource leaks, logical dead codes etc... chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled. Garbage output was there. comm.c: loop error id.c: single build issue for OLD_TOYs, same issue is

[Toybox] [Patch] - touch, kill and umount fixes

Hi Rob, Attached are the patches. This has fixes for touch: 1. while setting access or modify times of a file, this was causing a hang due to non-increment of ss. 2. handling the time format for __-d__ option as per the spec (

[Toybox] [New Toy] - ip

Hi Rob, Earlier had sent a version of ip, which had many TODO items. Attached is the updated version, having complete support for ip _link_, _addr_, _rule_, _route_ and _tunnel_ options. Please see to it, if this can be added to the hg. regards, Ashwini ip.c.patch Description: Binary data

Re: [Toybox] [Patch] - touch, kill and umount fixes

Attached is the updated patch. On Fri, Sep 19, 2014 at 12:33 AM, Rob Landley r...@landley.net wrote: On 09/18/14 05:38, Ashwini Sharma wrote: Hi Rob, Hi. Your last round of fixes (which I've applied a little over half of) touched some of the files needing cleanup outside of the pending

Re: [Toybox] [Issue] - mounting a device again

, 2014 at 6:20 PM, Rob Landley r...@landley.net wrote: On 09/15/14 23:14, Ashwini Sharma wrote: Hi Rob, Encountered an issue while mounting a device which is already mounted. when __-t__ is not specified, the mount tries with the first device filesystem it finds from /proc/filesystems

[Toybox] [Issue] - mounting a device again

Hi Rob, Encountered an issue while mounting a device which is already mounted. when __-t__ is not specified, the mount tries with the first device filesystem it finds from /proc/filesystems. __mount()__ return an EBUSY, at this point no other file system is tried for mounting instead mount

[Toybox] [Patches] - Static analysis fixes

Hi Rob, Attached are few fixes for issues reported in static analysis. Do have a look and share your inputs. regards, Ashwini bootchartd.c.patch Description: Binary data cpio.c.patch Description: Binary data cut.c.patch Description: Binary data find.c.patch Description: Binary data

[Toybox] [Issue] - single build

Hi Rob, When doing a single build toy_list is populated with the command to be built and all it __aliases__ in the chronological ascending order. This is creating issue, use case is __grep__ this enables __egrep__, __fgrep__ and __grep__. The default selected command is egrep, as it is first in

[Toybox] [Issues] - grep

Hi List, While verifying the command grep and analysing/comparing the behavior with GNU and busybox. I notices following 1. __-H__ and __-h__ options, we prefer -H over -h, GNU and Busybox prefer the last one mentioned on command line. 2. links are not followed for doing grep, i.e. grep search

[Toybox] [Patch] - args.c failure for group [-abc]

Hi Rob, For the group __ [-abc] __ handling, while clearing the flags for the options to be disabled, it cleared args, for any of the set options until then. Additional check is added to determine the options arg to be cleared. for (clr=gof-opts, i=1; clr; clr = clr-next, i=1) - if

[Toybox] [Patches] - Static analysis fixes

Hi Rob, List, Attached are the patches to commands for issues reported from static analysis tool. portability.h.patch - it is for O_CLOEXEC, as compiler complained of it. Makefile.patch - for cleaning generated/*.o files and libopts.dat file regards, Ashwini arp.c.patch Description: Binary

Re: [Toybox] [Patches] - Static analysis fixes

compiler I used is gcc version 4.4.3 on ubuntu 64-bit with linux kernel 2.6.32. This complained of undeclared O_CLOEXEC. Ashwini On Mon, Aug 11, 2014 at 6:47 PM, Rob Landley r...@landley.net wrote: On 08/11/2014 04:27 AM, Ashwini Sharma wrote: Hi Rob, List, Attached are the patches

Re: [Toybox] [Patches] - Static analysis fixes

Hi Andre, I used _prevent_ by Coverity and also a proprietary tool. regards, Ashwini On Tue, Aug 12, 2014 at 1:07 AM, Andre Renaud an...@bluewatersys.com wrote: Hi Ashwini, Attached are the patches to commands for issues reported from static analysis tool. Just out of curiosity, which

[Toybox] [New Toy] - Blockdev

Hi Rob, List, A patch for a toy _BLOCKDEV_ to get/set block device properties is attached here with. Your inputs are welcome. regards, Ashwini blockdev.c.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] [New toys] - diff, userdel

, Rob Landley r...@landley.net wrote: On 08/03/14 15:39, Bobby Bingham wrote: On Sat, Aug 02, 2014 at 11:39:21AM -0500, Rob Landley wrote: On 08/01/14 06:08, Ashwini Sharma wrote: Hi Rob, List, Attached are the new toys unified DIFF and USERDEL. Your inputs are welcome. Query

[Toybox] [New toys] - diff, userdel

Hi Rob, List, Attached are the new toys unified DIFF and USERDEL. Your inputs are welcome. regards, Ashwini diff.c.patch Description: Binary data userdel.c.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

[Toybox] [Patches] - fsck, fdisk and ftpget

Hi Rob, Attached are the patches for fdisk : partitions 60, are deleted, offset entry for extended partitions was wrong. fsck: memory leak/segfault resolved. ftpget : warning for unused variable 'ptr' removed. Thanks, Ashwini fdisk.c.patch Description: Binary data fsck.c.patch Description:

Re: [Toybox] [CLEANUP] groupdel

On Mon, Jul 7, 2014 at 10:25 AM, Rob Landley r...@landley.net wrote: Haven't checked this in yet because it needs more testing, but patch is attached: GROUP is always toys.optargs[toys.optc-1] so let's move the getgrnam() before the two if/else cases so it's not duplicated. (Speaking of

[Toybox] [Patch] - last, typo issue

Hi Rob, List, Due to a type in last.c the build is broken. The callback function to __llist_traverse()__ is typed wrong. diff -Naur b/toybox-ee18ddbb783b/toys/pending/last.c a/toybox-ee18ddbb783b/toys/pending/last.c --- b/toybox-ee18ddbb783b/toys/pending/last.c 2014-05-23 08:03:10.0

[Toybox] [Patch] dhcp client - crash fix

Hi Rob, list, dhcp client had a segfault, when DHCP message contained 'pad' option. The parsing logic kept checking for other options beyond __pad__ option, without checking if it was __end__ option after that or not. --- a/toys/pending/dhcp.c 2014-05-14 06:15:01.0 +0530 +++

[Toybox] [New Toy] - lsattr chattr

Hi Rob, List, Attached is the patch for __lsattr__ and __chattr__ implementation. This is the modified and better version from the last one I sent. It is having the both the mains (__lsattr_main()__ and __chattr_main()__ ) in single file. Also removed the dependency of additional file in lib,

Re: [Toybox] Sorry about the build breakage...

Hi Rob, I was about to send it across... anyways. Attached is the patch for build break fix. regards, Ashwini On Thu, Apr 17, 2014 at 4:47 AM, Rob Landley r...@landley.net wrote: Should be fixed now. I _still_ get bitten by hg import checking in every modified file in my entire tree. It's

[Toybox] [New Toy] - printf

Hello Rob, List, An implementation of __printf__ is attached. Would love to have your inputs on the same. __PATCH__: An issue in ifconfig while verifying the HW Address, which is assumed to be of the format __C2:79:38:95:CD:AB__ but can be of form __C2:79:38:95:D:A__. In this case the HW

[Toybox] [New Toy] - reset

Hi List, A tool to reset the terminal. This implementation depends on the _stty_ 'sane' settings. Is this approach fine, or should the _stty_ __sane__ stuff be done in __reset__ command itself. Your inputs are welcome. regards, Ashwini /* reset.c - A program to reset the terminal. * *

[Toybox] [Patch] - ifconfig hw address Makefile clean target

Hi Rob, List, Encountered couple of issues, 1. ifconfig - while setting hw address, the condition check was wrong. 2. Makefile - Clean target didn't remove generated/globals.h and testdir. attached are the patches for the same. regards, Ashwini Makefile.patch Description: Binary data

Re: [Toybox] [New toy] rudimentary getty

Hi, What a coincidence, even I was about to send getty implementation in this forum. Attached is a little largeish version of getty. Supporting TERM settings, baud rate setting, issue file, updating utmp entries if this suits, can add to the tree. Looking forward to your inputs. regards,

[Toybox] [New Toy] - modprobe

Hi List, An implementation for modprobe is attached. go thru the same and let me know your inputs. regards, Ashwini /* modprobe.c - modprobe utility. * * Copyright 2012 Madhur Verma mad.fl...@gmail.com * Copyright 2013 Kyungwan Han asura...@gmail.com * * No Standard.

[Toybox] [New Toy] - brctl

Hi List, An implementation for brctl (ethernet bridge control) is attached here with. Open to your comments on this. regards, Ashwini /* brctl.c - ethernet bridge control * * Copyright 2013 Ashwini Kumar ak.ashwini1...@gmail.com * Copyright 2013 Kyungwan Han asura...@gmail.com * * No

Re: [Toybox] Issue with names_to_pid(), pidof, killall

Its good to see you back on the list!! there was a typo!!, I did mean __non-existing__ process instead of __non-exiting__ -Ashwini On Tue, Dec 17, 2013 at 7:50 PM, Rob Landley r...@landley.net wrote: On 11/22/2013 12:26:14 AM, Ashwini Sharma wrote: Hi All, Due to some issue with my email

Re: [Toybox] FTP commands

Hi, The input parameter port was kept as string, so that the user can also give service name like ftp instead of numeric PORT. Which will be resolved by getaddrinfo() using /etc/services. regards, Ashwini On Thu, Dec 12, 2013 at 1:27 PM, ibid...@gmail.com wrote: Thanks! Noticed a few

[Toybox] [New Toys] - chattr and lsattr

Hi Rob, list, attached is a patch implementing __chattr__ and __lsattr__. For this, few macros are added into __e2fs.h__ and a new file lib/e2fs.c implementing a function, used in both chattr and lsattr, for getting the file attributes is added. Your inputs are welcome. regards, Ashwini PS:-

Re: [Toybox] FTP commands

Hi List, The last attachment was not the proper version. Please use the latest one attached here with. regards, Ashwini On Tue, Dec 10, 2013 at 11:22 AM, Ashwini Sharma ak.ashwini1...@gmail.comwrote: Hi Rob, List, Attached is an implementation for ftpget/put commands. Your inputs

[Toybox] [Patch] - vconfig use atolx_range() instead of strtorange()

Hi List, atolx_range() is already added into lib/lib.c, in vconfig.c, __ atolx_range()__ can be used in place of locally defined __ strtorange()__ function. Attached is the patch for the same. regards, Ashwini vconfig.c.patch Description: Binary data

[Toybox] [Patch] - adding '-B' to grep

Hi Rob, list, _-B_ option support for printing leading context lines, before the match, is added to grep command. The implementation is based on the queue. Used sys/queue for the purpose. Have a glance at the same. Regards, Ashwini grep.c.patch Description: Binary data

[Toybox] [New Toys] - telnet daemon and client

Hi List, attached is a patch for the telnet daemon and client implementation. Have a look at the same and pass on your inputs. Thanks, Ashwini telnet.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

[Toybox] [New Toys] - More and Last commands

Hi All, An implementation for More and last commands is attached. Your inputs are welcome. regards, Ashwini /* last.c - Show listing of last logged in users. * * Copyright 2013 Ranjan Kumar ranjankumar@gmail.com * Copyright 2013 Kyungwan Han asura...@gmail.com * * No Standard.

[Toybox] [Patch] - Traceroute with IPv6 support

Hi All, IPv6 support is added into traceroute command. traceroute6 is made as an old toy of traceroute. Attached is the updated file. Have a look at the same and let me know for inputs. Thanks, Ashwini Sharma /* traceroute - trace the route to host. * * Copyright 2012 Madhur Verma mad.fl

[Toybox] [New Toy] - groupdel

Hi Rob, list, Attached is an implementation for groupdel. This is aliased to delgroup, for a requirement at my end. Also lib/password.c is modified to along with. Have a look at this and give your inputs on the same. regards, Ashwini groupdel.patch Description: Binary data

Re: [Toybox] [Patch] - Traceroute with IPv6 support

Thanks Jeroen. Updating the email id in Copyright. Thanks, Ashwini On Mon, Nov 25, 2013 at 5:24 PM, Ashwini Sharma ak.ashwini1...@gmail.comwrote: Hi All, IPv6 support is added into traceroute command. traceroute6 is made as an old toy of traceroute. Attached is the updated file. Have

[Toybox] [patch] - add '-v' for ln and mkdir

, Ashwini Sharma ln.c.patch Description: Binary data mkdir.c.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

[Toybox] [Patch] - killall fixed, -l requiring argument and added -s SIGNAL

Hi Rob, list, killall implementation had a requirement to pass an argument even if user wanted to list the signals using _ -l _ option. Modified the code to not require argument for _ -l _ option. Also added the support for killall to accept _ -s SIGNAL _ option on the lines of _kill_ command,

[Toybox] [Patch] - ifconfig, fixes for IPv6 and SEGFAULT

() _ function, which again used the toybuf to read data into. Hence corrupting the _name_. Fixed this by making a copy of name and then freeing it after use. Your inputs are welcome. regards, Ashwini Sharma ifconfig.c.patch Description: Binary data

[Toybox] Issue with names_to_pid(), pidof, killall

for non-signalled processes. Like to have your opinion. regards, Ashwini Sharma ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] FTP commands

: Hello, Is anyone working on ftpget and ftpput? I will likely be able to contribute these around the start of next month. Not that I know of. If anyone is, it would be Ashwini Sharma; but he seems to be working on a different set of commands at the moment. Maybe I can also provide

Re: [Toybox] - Add DD

!) Rob On 10/16/2013 01:09:29 AM, Ashwini Sharma wrote: Hi Rob, incase you missed this mail, just to bring it on the top of ur list. regards, Ashwini On Tue, Sep 3, 2013 at 2:53 PM, Ashwini Sharma ak.ashw...@gmail.com wrote: Hi Rob, Attached is the patch for DD. I have also

[Toybox] [New Toy] - Add tftpd

Hi Rob, All, Attached is the TFTPD implementation. Add it to hg, if you find it fine. Let me know for any comments/improvements. -Ashwini /* tftpd.c - TFTP server. * * Copyright 2013 Ranjan Kumar ranjankumar@gmail.com * Copyright 2013 Kyungwan Han asura...@gmail.com * * No Standard.

Re: [Toybox] - Add DD

Hi Rob, incase you missed this mail, just to bring it on the top of ur list. regards, Ashwini On Tue, Sep 3, 2013 at 2:53 PM, Ashwini Sharma ak.ashw...@gmail.com wrote: Hi Rob, Attached is the patch for DD. I have also modified _du.c_, _pending.c_ and _lib.h_ to make a common function

Re: [Toybox] [New Toys] - groupadd, useradd, mkpasswd and modified passwd, lib/password

On Thu, Oct 17, 2013 at 6:46 AM, Rob Landley r...@landley.net wrote: On 10/02/2013 03:49:21 AM, Ashwini Sharma wrote: Hi list, Attached are the implementations for groupadd, useradd and mkpasswd commands. Ok, I've caught up to this... Patches are as follows 1. __lib.patch__

[Toybox] [New Toys] - groupadd, useradd, mkpasswd and modified passwd, lib/password

Hi list, Attached are the implementations for groupadd, useradd and mkpasswd commands. Patches are as follows 1. __lib.patch__ : this includes changes made to lib/lib.h and __lib/password.c__. lib/passowrd.c is modified to share the function __update_password()__ among groupadd, useradd

[Toybox] [New toy] - top

Hi Rob, list, Attached is the top command implementation. '-m' option supported is for displaying memory details. This is purely based on the requirement at hand. Have a look at the implementation and pass on your comments. regards, Ashwini /* top.c - Provide a view of process activity in real

Re: [Toybox] [Patch - New Toy] Add traceroute

On Sun, Sep 15, 2013 at 1:24 PM, Isaac ibid...@gmail.com wrote: On Sun, Sep 15, 2013 at 11:59:42AM +0900, Ashwini Sharma wrote: On Fri, Sep 13, 2013 at 11:31 PM, Isaac ibid...@gmail.com wrote: I note that it appears to revert one of the recent changes to lib/pending.c. (Would you

Re: [Toybox] [Patch - New Toy] Add traceroute

see, there will be lot many if/else checks for IPv4/IPv6 cases. Like for the incoming packet parsing. Any suggestions are welcome. regards, Ashwini On Fri, Sep 13, 2013 at 11:31 PM, Isaac ibid...@gmail.com wrote: On Fri, Sep 13, 2013 at 03:10:24PM +0900, Ashwini Sharma wrote: Hi All

[Toybox] [Patch - New Toy] Add traceroute

Hi All, Attached is the traceroute patch. This supports IPv4 destination trace. Have a look at the same and pass on your comments. Thanks. Ashwini Kumar traceroute.c.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] - Add route

On Sat, Sep 7, 2013 at 11:47 PM, Isaac ibid...@gmail.com wrote: On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote: HI Rob list, Attached is the patch for _route_ command. It does display, add and del functions for routing tables. Have a look at it. regards

[Toybox] Fwd: [New Toy - patch] add ps watch

Hi Rob, Attached are the patches for _watch_ and _ps_ command. Sent _ps_ again, just in case you lost the last one. This one also have a copyright update. regards, Ashwini -- Forwarded message -- From: Ashwini Sharma ak.ashw...@gmail.com Date: Wed, Aug 7, 2013 at 6:17 PM

Re: [Toybox] [New Toy] : add udhcpd

HI Rob, Need to include headers, which are added in toynet.h at my end. The files reuired are #include netinet/ip.h #include netinet/udp.h #include netpacket/packet.h regards, Ashwini On Tue, Aug 13, 2013 at 5:26 PM, Rob Landley r...@landley.net wrote: On 08/12/2013 04:29:25 AM, Ashwini

[Toybox] [New Toy] : add udhcpd

Hi Rob, In the continuation to DHCP client sent to you last week, attached here with is the DHCP server implementation. Have a look at the same and let me know for any comments. regards, Ashwini udhcpd.c.patch Description: Binary data ___ Toybox

Re: [Toybox] (no subject)

On Fri, Jul 26, 2013 at 4:11 AM, Rob Landley r...@landley.net wrote: On 07/19/2013 05:02:40 AM, Ashwini Sharma wrote: Hi Rob, Attached is the syslogd patch. Features supported are usage: syslogd [-a socket] [-p socket] [-O logfile] [-f config file] [-m interval] [-p socket] [-s SIZE

Re: [Toybox] toynet.h to be included in toys.h

And from 2~3 days I don't see the link to download the latest source from Mercurial. -Ashwini On Fri, May 3, 2013 at 11:35 AM, Ashwini Sharma ak.ashw...@gmail.comwrote: Hi Rob, I think we should include toynet.h in toys.h, before we include #include generated/newtoys.h #include

Re: [Toybox] [groups] : ! More than one in group is error

Hi Rob, With your fix, it doesn't segfault now. But does it matter, to give the proper option name in error message. If yes, then the fix fails in that. e.g. when running *./toybox touch -d 12 -r f2 f1* it throws the error message as *touch: No 'r' with 't'*. I feel the error message is not

[Toybox] long options support and yesno()

Hi Rob, As for the command options FLAG_xxx macros are auto generated. Is the long options support in there and working? Another usage issue I came across is in yesno() function. In that you check for the tty fd. As '0' is also tty, you print the prompt data onto 'stdin' which doesn't show up

[Toybox] Compile errors when compiling for ARM

Hi Rob, I was working on the latest changeset 711. When I compile it for x86 machine, it works fine, but when building for my ARM board, compiler shouts* O_DIRECTORY undecalred in xabspath()*. Am I missing something or the tree has this issue, please comment. regards, Ashwini Kumar

[Toybox] Defect in Argument parsing for # and -

Hi Rob, I was using '#' for accepting a integer parameter. As per the parsing logic you used function atolx(), for converting the string to long. This function assumes suffixes with the supplied string. There are possibilities that user may not want suffixes to be there, i.e. any alpha char in